Skip to content

Commit b925e32

Browse files
committed
replaced promisify with native alternatives
1 parent a07ea04 commit b925e32

File tree

3 files changed

+5
-13
lines changed

3 files changed

+5
-13
lines changed

lib/util/files/finder.js

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,5 @@
1-
let fs = require("fs");
1+
let { readdir, stat } = require("fs/promises");
22
let path = require("path");
3-
let { promisify } = require("util");
4-
5-
let stat = promisify(fs.stat);
6-
let readDir = promisify(fs.readdir);
73

84
module.exports = class FileFinder {
95
constructor(directory, { skipDotfiles, filter = () => true } = {}) {
@@ -36,7 +32,7 @@ function tree(filepath, referenceDir = filepath) {
3632
return [path.relative(referenceDir, filepath)];
3733
}
3834

39-
return readDir(filepath).
35+
return readdir(filepath).
4036
then(entries => {
4137
let res = Promise.all(entries.map(entry => {
4238
return tree(path.join(filepath, entry), referenceDir);

lib/util/files/index.js

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,13 @@
11
"use strict";
22

33
let { abort, repr } = require("../");
4-
let fs = require("fs");
4+
let { writeFile } = require("fs/promises");
5+
let { mkdirSync } = require("fs");
56
let path = require("path");
6-
let { promisify } = require("util");
77

88
let KNOWN = {}; // avoids redundant `mkdirp` invocations
99
let LOCKS = {};
1010

11-
let writeFile = promisify(fs.writeFile);
12-
1311
// avoids concurrent write operations and creates target directory if necessary
1412
module.exports = function createFile(filepath, contents) {
1513
let lock = LOCKS[filepath];
@@ -34,7 +32,7 @@ module.exports = function createFile(filepath, contents) {
3432
function mkdirpSync(directory) {
3533
try {
3634
// NB: `recursive` option was introduced in Node v10.12.0
37-
fs.mkdirSync(directory, { recursive: true });
35+
mkdirSync(directory, { recursive: true });
3836
} catch(err) {
3937
abort(`ERROR: auto-creating ${repr(directory)} requires ` +
4038
"Node v10.12.0 or above");

lib/util/index.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,8 @@
22

33
let path = require("path");
44
let crypto = require("crypto");
5-
let { promisify } = require("util");
65

76
exports.abort = abort;
8-
exports.promisify = promisify; // deprecated
97
exports.repr = repr;
108

119
// reports success or failure for a given file path (typically regarding

0 commit comments

Comments
 (0)