removed support for legacy plugin API

this effectively reverts 4d8b1ac and
d5f4016

Author: FND

lib/plugins.js

@@ -46,14 +46,6 @@ function pluginsByBucket(config, defaults) {
 		}
 
 		let { bucket, plugin } = _plugin;
-		// special-casing for default plugins' legacy versions
-		if(_plugin.default && plugin.substr) {
-			let __plugin = loadExtension(plugin, "ERROR: missing plugin");
-			if(__plugin.call) { // legacy plugin version
-				plugin = __plugin;
-			}
-		}
-
 		buckets[bucket].push({
 			plugin: plugin.call ? plugin : loadPlugin(plugin).plugin,
 			config: pluginConfig
@@ -66,10 +58,6 @@ function pluginsByBucket(config, defaults) {
 // `{ key, bucket, plugin }` object`, with `key` being the configuration key and
 // `plugin` being either a function or a package identifier
 function determinePlugins(plugins = [], defaults = DEFAULTS) {
-	if(!plugins.pop) { // for backwards compatibility
-		plugins = modernize(plugins);
-	}
-
 	let registry = {};
 	// NB: default plugins are resolved lazily because eager loading would
 	//     result in them becoming a hard dependency rather than a convenience
@@ -126,17 +114,3 @@ function loadPlugin(pkg) {
 	} = loadExtension(pkg, "ERROR: missing plugin");
 	return { key, bucket, plugin };
 }
-
-// converts legacy `{ key: { bucket, plugin } }` format
-function modernize(plugins) {
-	return Object.entries(plugins).map(([key, _plugin]) => {
-		let { bucket, plugin } = _plugin;
-		if(plugin.substr) {
-			plugin = loadExtension(plugin, "ERROR: missing plugin");
-			if(!plugin.call) { // non-legacy plugin
-				plugin = plugin.plugin;
-			}
-		}
-		return { key, bucket, plugin };
-	});
-}

test/fixtures/node_modules/faucet-pipeline-legacy/index.js

@@ -103,64 +103,6 @@ describe("plugin registration", _ => {
 			markup: []
 		});
 	});
-
-	it("ensures backwards compatibility", () => {
-		let defaults = [{
-			key: "legacy",
-			bucket: "static",
-			plugin: path.resolve(CUSTOM_NODE_PATH, "faucet-pipeline-legacy")
-		}];
-		let res = pluginsByBucket({
-			legacy: [{ foo: "lorem" }]
-		}, defaults);
-		assertDeep(normalizeAll(res), {
-			static: [{
-				plugin: "<Function faucetLegacy>",
-				config: [{ foo: "lorem" }]
-			}],
-			scripts: [],
-			styles: [],
-			markup: []
-		});
-
-		res = pluginsByBucket({
-			dummy: [{ foo: "lorem" }],
-			plugins: {
-				dummy: {
-					bucket: "static",
-					plugin: path.resolve(CUSTOM_NODE_PATH, "faucet-pipeline-dummy")
-				}
-			}
-		});
-		assertDeep(normalizeAll(res), {
-			static: [{
-				plugin: "<Function faucetDummy>",
-				config: [{ foo: "lorem" }]
-			}],
-			scripts: [],
-			styles: [],
-			markup: []
-		});
-
-		res = pluginsByBucket({
-			legacy: [{ bar: "ipsum" }],
-			plugins: {
-				legacy: {
-					bucket: "static",
-					plugin: path.resolve(CUSTOM_NODE_PATH, "faucet-pipeline-legacy")
-				}
-			}
-		});
-		assertDeep(normalizeAll(res), {
-			static: [{
-				plugin: "<Function faucetLegacy>",
-				config: [{ bar: "ipsum" }]
-			}],
-			scripts: [],
-			styles: [],
-			markup: []
-		});
-	});
 });
 
 describe("plugin resolution", _ => {

test/test_plugins.js

@@ -45,7 +45,6 @@ describe("FileFinder", _ => {
 					"node_modules/faucet-pipeline-invalid-b/index.js",
 					"node_modules/faucet-pipeline-invalid-c/index.js",
 					"node_modules/faucet-pipeline-js/index.js",
-					"node_modules/faucet-pipeline-legacy/index.js",
 					"node_modules/faucet-pipeline-sass/index.js",
 					"node_modules/faucet-pipeline-static/index.js"
 				]);
@@ -68,7 +67,6 @@ describe("FileFinder", _ => {
 					"node_modules/faucet-pipeline-invalid-b/index.js",
 					"node_modules/faucet-pipeline-invalid-c/index.js",
 					"node_modules/faucet-pipeline-js/index.js",
-					"node_modules/faucet-pipeline-legacy/index.js",
 					"node_modules/faucet-pipeline-sass/index.js",
 					"node_modules/faucet-pipeline-static/index.js"
 				]);
@@ -90,7 +88,6 @@ describe("FileFinder", _ => {
 					"node_modules/faucet-pipeline-invalid-b/index.js",
 					"node_modules/faucet-pipeline-invalid-c/index.js",
 					"node_modules/faucet-pipeline-js/index.js",
-					"node_modules/faucet-pipeline-legacy/index.js",
 					"node_modules/faucet-pipeline-sass/index.js",
 					"node_modules/faucet-pipeline-static/index.js"
 				]);