removed browserslist #168
Open
removed browserslist #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a breaking change, as browsers will no longer be passed to the plugins, which moves the responsibility for determining the correct browserslist to the plugin.
|
I'm a little uncertain about the implications of this: I vaguely remember us talking about plugins (e.g. faucet-js and faucet-css) having independent browserslist instances/configuration or at least doing redundant discovery. Is that a concern worth exploring? PS: This kinda renders 2a19f94 moot; we should probably drop that commit and raise the Node version elsewhere. |
|
Yes, this is the most "controversial" of the PRs. Back in April, I created the PR for the change for faucet-pipeline-sass. We would need a similar PR for faucet-pipeline-js and faucet-pipeline-css. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change, as browsers will no longer be passed to the plugins, which moves the responsibility for determining the correct browserslist to the plugin.