Skip to content

Commit 9192394

Browse files
committed
improved error reporting
not entirely sure about the respective origins (Babel vs. Rollup), but this seems to work
1 parent 7d064b1 commit 9192394

File tree

1 file changed

+11
-5
lines changed

1 file changed

+11
-5
lines changed

lib/util.js

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,10 @@ exports.generateError = err => {
1616
let msg = `ERROR: ${err}`;
1717
console.error(`✗ ${msg}`);
1818
if(err.code) { // Rollup-augmented exception; emit in full detail
19-
let { codeFrame } = err; // excerpt, provided by Babel
20-
if(codeFrame) {
21-
delete err.codeFrame;
22-
console.error(err);
23-
console.error(`\n${codeFrame}\n`);
19+
if(err.codeFrame) { // excerpt, provided by Babel
20+
reportCodeFrame(err, "codeFrame");
21+
} else if(err.frame) { // excerpt, provided by Rollup
22+
reportCodeFrame(err, "frame");
2423
} else {
2524
console.error(err);
2625
}
@@ -32,3 +31,10 @@ exports.generateError = err => {
3231
}
3332
return `${NOTIFY}("${msg.replace(/"/g, '\\"')}");`;
3433
};
34+
35+
function reportCodeFrame(err, prop) {
36+
let frame = err[prop];
37+
delete err[prop];
38+
console.error(err);
39+
console.error(`\n${frame}\n`);
40+
}

0 commit comments

Comments
 (0)