improved watch-mode test

this should avoid CI test failures due to what seems like a race
condition on slow CPUs - though it also speed up tests in general by
avoiding unnecessary delays

in the process, updated dependencies and fixed linting

Author: FND

package.json

@@ -20,7 +20,7 @@
 		"test": "npm-run-all lint --parallel test:unit test:cli",
 		"test:cli": "./test/cli/run",
 		"test:unit": "mocha test/unit/test_*.js",
-		"lint": "eslint --cache --ext .js --ext .jsx *.js bin samples && echo ✓"
+		"lint": "eslint --cache --ext .js --ext .jsx *.js bin/* samples && echo ✓"
 	},
 	"engines": {
 		"node": ">=6"
@@ -33,7 +33,7 @@
 		"rollup-plugin-node-resolve": "^3.0.3"
 	},
 	"devDependencies": {
-		"eslint-config-fnd-jsx": "^1.1.0",
+		"eslint-config-fnd-jsx": "^1.3.0",
 		"faucet-pipeline-esnext": "file:pkg/faucet-pipeline-esnext",
 		"faucet-pipeline-jsx": "file:pkg/faucet-pipeline-jsx",
 		"faucet-pipeline-typescript": "file:pkg/faucet-pipeline-typescript",

test/unit/test_watch.js

@@ -18,7 +18,7 @@ describe("watcher", () => {
 		watcher.terminate();
 	});
 
-	it("responds to file changes in watch mode", done => {
+	it("responds to file changes in watch mode", function(done) {
 		let config = [{
 			source: entryPoint.relative,
 			target: "./dist/bundle.js"
@@ -55,11 +55,21 @@ console.log(\`[…] $\{util}\`); // eslint-disable-line no-console
 		setTimeout(_ => {
 			fs.writeFileSync(entryPoint.absolute, src + 'console.log("…");');
 		}, 50);
-		// check result
-		setTimeout(_ => { // FIXME: hacky
-			assetManager.assertWrites(expectedBundles);
+		// check result by polling
+		let timer = 0;
+		let interval = 50;
+		let threshold = this.timeout() - 2 * interval;
+		let check = _ => {
+			timer += interval;
+			if(timer > threshold ||
+					assetManager._writes.length === expectedBundles.length) {
+				assetManager.assertWrites(expectedBundles);
+				conclude();
+				return;
+			}
 
-			conclude();
-		}, 500);
+			setTimeout(check, interval); // retry
+		};
+		setTimeout(check, interval);
 	});
 });