remove images option

Author: moonglum

.github/workflows/tests.yml

@@ -15,6 +15,6 @@ jobs:
         - uses: actions/[email protected]
           with:
               node-version: ${{ matrix.node-version }}
-        - run: npm run test:prepare && npm install-test
+        - run: npm install-test
           env:
               CI: true

CHANGELOG.md

@@ -2,6 +2,23 @@ faucet-pipeline-static version history
 ======================================
 
 
+v2.0.0
+------
+
+_?_
+
+breaking changes:
+
+* support for legacy node versions is dropped
+* the `compact: images` option has been removed
+
+changes for end users:
+
+* guard against disappearing files
+
+no significant changes for developers
+
+
 v1.2.0
 ------
 

index.js

@@ -1,6 +1,7 @@
 let { readFile, stat } = require("fs").promises;
 let path = require("path");
 let FileFinder = require("faucet-pipeline-core/lib/util/files/finder");
+let { abort } = require("faucet-pipeline-core/lib/util");
 
 module.exports = {
 	key: "static",
@@ -45,11 +46,7 @@ function determinePlugins(compact, copyConfig) {
 	}
 
 	if(copyConfig.compact === "images") {
-		return {
-			jpg: require("imagemin-mozjpeg")({ quality: 80 }),
-			png: require("imagemin-pngquant")(),
-			svg: require("imagemin-svgo")()
-		};
+		abort("images compaction option has been removed - see https://www.faucet-pipeline.org/static"); // eslint-disable-line max-len
 	}
 
 	return copyConfig.compact || {};

package.json

@@ -1,12 +1,11 @@
 {
 	"name": "faucet-pipeline-static",
-	"version": "1.2.0",
+	"version": "2.0.0",
 	"description": "static files for faucet-pipeline",
 	"main": "index.js",
 	"scripts": {
 		"test": "npm-run-all --parallel lint test:cli",
 		"test:cli": "./test/run",
-		"test:prepare": "./test/prepare",
 		"lint": "eslint --cache index.js test && echo ✓"
 	},
 	"repository": {
@@ -24,9 +23,6 @@
 	},
 	"devDependencies": {
 		"eslint-config-fnd": "^1.8.0",
-		"imagemin-mozjpeg": "^8.0.0",
-		"imagemin-pngquant": "^8.0.0",
-		"imagemin-svgo": "^7.1.0",
 		"json-diff": "^0.5.4",
 		"npm-run-all": "^4.1.5",
 		"release-util-fnd": "^2.0.0"

test/prepare

@@ -82,44 +82,4 @@ begin "$root/test_match_multiple"
 	assert_missing "./dist/nope.json"
 end
 
-begin "$root/test_compact_undefined"
-	faucet --compact
-	assert_identical src/test.txt dist/test.txt
-	assert_identical src/example.jpg dist/example.jpg
-	assert_identical src/example.png dist/example.png
-	assert_identical src/example.gif dist/example.gif
-	assert_identical src/example.svg dist/example.svg
-	assert_identical src/example.webp dist/example.webp
-end
-
-begin "$root/test_compact_images"
-	faucet
-	assert_identical src/test.txt dist/test.txt
-	assert_identical src/example.jpg dist/example.jpg
-	assert_identical src/example.png dist/example.png
-	assert_identical src/example.gif dist/example.gif
-	assert_identical src/example.svg dist/example.svg
-	assert_identical src/example.webp dist/example.webp
-end
-
-begin "$root/test_compact_images"
-	faucet --compact
-	assert_identical src/test.txt dist/test.txt
-	assert_smaller_size src/example.jpg dist/example.jpg
-	assert_smaller_size src/example.png dist/example.png
-	assert_identical src/example.gif dist/example.gif
-	assert_smaller_size src/example.svg dist/example.svg
-	assert_identical src/example.webp dist/example.webp
-end
-
-begin "$root/test_compact_custom"
-	faucet --compact
-	assert_identical src/test.txt dist/test.txt
-	assert_identical src/example.jpg dist/example.jpg
-	assert_identical src/example.png dist/example.png
-	assert_identical src/example.gif dist/example.gif
-	assert_smaller_size src/example.svg dist/example.svg
-	assert_identical src/example.webp dist/example.webp
-end
-
 echo; echo "SUCCESS: all tests passed"