Merge pull request #147 from fauna/OSS-693-remove-warnings

OSS-693: Remove all warnings

Author: shestakovg

FaunaDB.Client.Test/ClientTest.cs

@@ -892,9 +892,13 @@ [Test] public async Task TestEvalContainsExpressions()
             var favoritesObj = Obj("favorites", foodsObj);
 
             // Deprecated
-
+#pragma warning disable CS0618 // Type or member is obsolete
             Assert.AreEqual(BooleanV.True,
                 await client.Query(Contains(Path("favorites", "foods"), favoritesObj)));
+#pragma warning restore CS0618 // Type or member is obsolete
+
+            Assert.AreEqual(BooleanV.True,
+                await client.Query(ContainsPath(Path("favorites", "foods"), favoritesObj)));
 
             // Field
 
@@ -1066,7 +1070,7 @@ [Test] public async Task TestEvalDivideExpression()
             Assert.AreEqual(10L, res.To<long>().Value);
         }
 
-        [Test] public async Task TestEvalDivideExpressionWrongArgument()
+        [Test] public void TestEvalDivideExpressionWrongArgument()
         {
             var ex = Assert.ThrowsAsync<BadRequest>(
                     async() => await client.Query(Divide(Null(), 10))
@@ -2587,7 +2591,7 @@ public async Task TestToDouble()
         }
 
         [Test]
-        public async Task TestThrowBadRequestOnDouble()
+        public void TestThrowBadRequestOnDouble()
         {
             var ex = Assert.ThrowsAsync<BadRequest>(
                 async () => await adminClient.Query(ToDouble(Now()))
@@ -2609,7 +2613,7 @@ public async Task TestToInteger()
         }
 
         [Test]
-        public async Task TestThrowBadRequestOnInteger()
+        public void TestThrowBadRequestOnInteger()
         {
             var ex = Assert.ThrowsAsync<BadRequest>(
                 async () => await adminClient.Query(ToInteger(Now()))

FaunaDB.Client.Test/DecoderTest.cs

@@ -46,12 +46,22 @@ struct Point
         {
             public int X;
             public int Y;
+            public Point(int x, int y)
+            {
+                X = x;
+                Y = y;
+            }
         }
 
         struct Rect
         {
             public Point UpperLeft;
-            public Point BottonRight;
+            public Point BottomRight;
+            public Rect(Point upperLeft, Point bottomRight)
+            {
+                UpperLeft = upperLeft;
+                BottomRight = bottomRight;
+            }
         }
 
         [Test]
@@ -78,7 +88,7 @@ public void TestNullToValueTypes()
 
             Assert.AreEqual(default(Rect), Decode<Rect>(NullV.Instance));
             Assert.AreEqual(default(Rect), Decode<Rect>(ObjectV.Empty));
-            Assert.AreEqual(default(Rect), Decode<Rect>(ObjectV.With("UpperLeft", NullV.Instance, "BottonRight", NullV.Instance)));
+            Assert.AreEqual(default(Rect), Decode<Rect>(ObjectV.With("UpperLeft", NullV.Instance, "BottomRight", NullV.Instance)));
 
             //
 
@@ -214,6 +224,11 @@ public override bool Equals(object obj)
                     Created == product.Created &&
                     LastUpdated == product.LastUpdated;
             }
+
+            public override int GetHashCode()
+            {
+                return base.GetHashCode();
+            }
         }
 
         [Test]
@@ -369,7 +384,7 @@ class MissingPropertiesOnConstructor
             public string Field1 { get; set; }
 
             [FaunaField("a_missing_field")]
-            string field2;
+            string field2 = default(string);
 
             public string Field2 { get { return field2; } }
 
@@ -399,7 +414,7 @@ class MissingPropertiesOnMethodCreator
             public string Field1 { get; set; }
 
             [FaunaField("a_missing_field")]
-            string field2;
+            string field2 = default(string);
 
             public string Field2 { get { return field2; } }
 
@@ -701,13 +716,24 @@ struct NestedStruct
         {
             public byte? aByte;
             public short? aShort;
+            public NestedStruct(byte? abyte, short? ashort)
+            {
+                aByte = abyte;
+                aShort = ashort;
+            }
         }
 
         struct StructWithNullableFields
         {
             public int? anInteger;
             public double? aDouble;
             public NestedStruct? aStruct;
+            public StructWithNullableFields(int? intVal, double? doubleVal, NestedStruct? structVal)
+            {
+                anInteger = intVal;
+                aDouble = doubleVal;
+                aStruct = structVal;
+            }
         }
 
         [Test]

FaunaDB.Client.Test/FaunaDB.Client.Test.csproj

@@ -12,7 +12,11 @@
      net45         => applicable for .net framework version up to 4.8, means if you target
                       .net frameworks net45 till net48, FaunaDB.Client net45 build will be used
      -->
-    <TargetFrameworks>net45;netcoreapp1.1;netcoreapp2.1;netcoreapp3.1;net5.0</TargetFrameworks>
+    <TargetFrameworks>net45;netcoreapp2.1;netcoreapp3.1;net5.0</TargetFrameworks>
+  </PropertyGroup>
+  <PropertyGroup Condition="'$(Configuration)|$(TargetFramework)|$(Platform)'=='Debug|net45|AnyCPU'">
+    <WarningsAsErrors>;NU1605</WarningsAsErrors>
+    <NoWarn>1701;1702;</NoWarn>
   </PropertyGroup>
 
   <ItemGroup>

FaunaDB.Client.Test/SerializationTest.cs

@@ -755,8 +755,17 @@ [Test] public void TestEquals()
 
         [Test] public void TestContains()
         {
+#pragma warning disable CS0618 // Type or member is obsolete
             AssertJsonEqual(Contains(Arr("favorites", "foods"), Obj("favorites", Obj("foods", Arr("crunchings", "munchings", "lunchings")))),
                 "{\"contains\":[\"favorites\",\"foods\"],\"in\":{\"object\":{\"favorites\":{\"object\":{\"foods\":[\"crunchings\",\"munchings\",\"lunchings\"]}}}}}");
+#pragma warning restore CS0618 // Type or member is obsolete
+        }
+
+        [Test]
+        public void TestContainsPath()
+        {
+            AssertJsonEqual(ContainsPath(Arr("favorites", "foods"), Obj("favorites", Obj("foods", Arr("crunchings", "munchings", "lunchings")))),
+                "{\"contains_path\":[\"favorites\",\"foods\"],\"in\":{\"object\":{\"favorites\":{\"object\":{\"foods\":[\"crunchings\",\"munchings\",\"lunchings\"]}}}}}");
         }
 
         [Test] public void TestSelect()

FaunaDB.Client.Test/StreamingTest.cs

@@ -25,7 +25,7 @@ async Task SetUpAsync()
         }
 
         [Test]
-        public async Task TestThatStreamFailsIfTargetDoesNotExist()
+        public void TestThatStreamFailsIfTargetDoesNotExist()
         {
             AsyncTestDelegate doc = async () => { await adminClient.Stream(Get(Ref(Collection("streams_test"), "1234"))); };
 
@@ -35,7 +35,7 @@ public async Task TestThatStreamFailsIfTargetDoesNotExist()
         }
 
         [Test]
-        public async Task TestStreamFailsIfIncorrectValuePassedToStreamMethod()
+        public void TestStreamFailsIfIncorrectValuePassedToStreamMethod()
         {
             AsyncTestDelegate doc = async () => { await adminClient.Stream(Collection("streams_test")); };
 
@@ -45,7 +45,7 @@ public async Task TestStreamFailsIfIncorrectValuePassedToStreamMethod()
         }
 
         [Test]
-        public async Task TestStreamFailsIfQueryIsNotReadOnly()
+        public void TestStreamFailsIfQueryIsNotReadOnly()
         {
             AsyncTestDelegate doc = async () => { await adminClient.Stream(CreateCollection(Collection("streams_test"))); };