Fix some code style warnings

Author: fbdtemme

benchmark/plots/utils.py

@@ -1,9 +1,10 @@
 import pandas as pd
 import numpy as np
-from pathlib  import Path
+from pathlib import Path
 import json
 import matplotlib.pyplot as plt
 
+
 def load_json_benchmarks(file_path: Path) -> pd.DataFrame:
     """Load the benchmark results from a google benchmark json file."""
     with open(file_path, "r") as f:
@@ -12,8 +13,8 @@ def load_json_benchmarks(file_path: Path) -> pd.DataFrame:
     return pd.DataFrame(data["benchmarks"])
 
 
-def filter_results(df : pd.DataFrame, library: str) -> pd.DataFrame:
-    """"Remove mean, median and stddev from the results"""
+def filter_results(df: pd.DataFrame, library: str) -> pd.DataFrame:
+    """Remove mean, median and stddev from the results."""
     df_means = df.name.str.contains("mean")
     df_medians = df.name.str.contains("median") 
     df_stddev = df.name.str.contains("stddev") 
@@ -82,4 +83,4 @@ def plot_comparison(df):
 
     ax.legend(libraries, bbox_to_anchor=(1.05, 1), loc='upper left')
 
-    return ax
+    return ax

include/bencode/detail/event_connector.hpp

@@ -95,6 +95,7 @@ class event_connector
     {
         if (!stack_.empty() && stack_.top() == connector_state::expect_dict_key) [[unlikely]] {
             error_ = encoding_errc::invalid_dict_key;
+            return;
         }
         stack_.push(connector_state::expect_list_value);
         consumer_.begin_list();
@@ -104,6 +105,7 @@ class event_connector
     {
         if (!stack_.empty() && stack_.top() == connector_state::expect_dict_key) [[unlikely]] {
             error_ = encoding_errc::invalid_dict_key;
+            return;
         }
         stack_.push(connector_state::expect_dict_key);
         consumer_.begin_dict();
@@ -113,6 +115,7 @@ class event_connector
     {
         if (stack_.empty() || stack_.top() != connector_state::expect_list_value) [[unlikely]] {
             error_ = encoding_errc::unexpected_end_list;
+            return;
         }
 
         stack_.pop();
@@ -127,6 +130,7 @@ class event_connector
     {
         if (stack_.empty() || stack_.top() != connector_state::expect_dict_key) [[unlikely]] {
             error_ = encoding_errc::unexpected_end_dict;
+            return;
         }
 
         stack_.pop();
@@ -139,20 +143,19 @@ class event_connector
 
     template <typename U, typename T = std::remove_cvref_t<U>>
     requires event_producer<T>
-    inline bool handle_dict_key(U&& key)
+    inline void handle_dict_key(U&& key)
     {
         Expects(!stack_.empty());
         Expects(stack_.top() == connector_state::expect_dict_key);
 
         if constexpr (!serializable_to<T, bencode_type::string>) [[unlikely]] {
             error_ = encoding_errc::invalid_dict_key;
-            return false;
+            return;
         }
 
         stack_.top() = connector_state::expect_dict_value;
         connect(consumer_, std::forward<U>(key));
         consumer_.dict_key();
-        return true;
     }
 
     template <typename U, typename T = std::remove_cvref_t<U>>

include/bencode/detail/parser/from_chars.hpp

@@ -147,13 +147,12 @@ constexpr from_chars_result from_chars(
         const char* first, const char* last, bool& value, implementation_tag<0>)
 {
     std::uint8_t v = (*first - '0');
-    bool is_digit = v <= 9;
 
     if (v <= 1) [[likely]] {
         value = v;
         return {++first, parsing_errc{}};
     }
-    else if (v == is_digit) {
+    else if (v <= 9) {
         return {++first, parsing_errc::result_out_of_range};
     }
     else {

tests/parser/test_from_chars.cpp

@@ -92,7 +92,7 @@ TEMPLATE_TEST_CASE("test from_chars - serial", "[integer]", std::int32_t, std::i
 
 inline std::string operator""_padded(const char* s, std::size_t len)
 {
-    auto str = std::string(s, strlen(s));
+    auto str = std::string(s, len);
     str.resize(32, '\0');
     return str;
 }