Skip to content

Vignettes are outdated #10

@lrnv

Description

@lrnv

Hi,

The vignette https://cran.r-project.org/web/packages/plsRglm/vignettes/plsRglm.pdf section 3.3.1 proposes the following code :

library(plsRglm)
data(aze)
Xaze<-aze[,2:34]
yaze<-aze$y
cv.modpls<-cv.plsRglm(dataY=yaze,dataX=Xaze,nt=10,modele="pls-glm-logistic",K=8)

which prints lots of stuff (avoidable with verbose=FALSE), but then ends up on :

Error in PLS_glm_kfoldcv(dataX = Xaze, nt = 10, modele = "pls-glm-logistic",  :         
  argument "dataY" is missing, with no default

Which is coherent with ?cv.plsRglm, which explicitly states the cv.plsRglm(formula,dataX,...) syntax and not the cv.plsRglm(dataY,dataX,...) syntax, which (i guess?) is now outdated.

Last but not least, it looks like this vignette was not compiled since 2014 : maybe it should be fixed and set to recompile regularly (at least on CI) so that these issues are caught quicker ?

Happy to discuss


EDIT: I could not find the code corresponding to that vignette in this repo. It looks like pkgdown should contain a html compiled version of that vignette, but it does not, and only link to the CRAN pdf. Could you gently point me to the script ?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions