Skip to content

Commit 46f7e32

Browse files
committed
fix: small fixes
fix: added doc link fix: updated bootstrap to 1.1.4 release
1 parent a0c3b59 commit 46f7e32

File tree

8 files changed

+24
-17
lines changed

8 files changed

+24
-17
lines changed

CHANGELOG.md

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,13 @@ All notable changes to this project will be documented in this file.
44

55
The changelog format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
66

7-
## [0.0.1] - NEXT
7+
## [0.0.1] - Feb-4-2022
88

99
**Milestone**: Mainnet(1.0.3.1)
1010

11-
| Package | Version | Link |
12-
| -------------- | ------- | -------------------------------------------------------------- |
13-
| Symbol Network | v0.0.1 | [symbol-network](https://www.npmjs.com/package/symbol-network) |
11+
| Package | Version | Link |
12+
|------------------|---------|--------------------------------------------------------------------|
13+
| Symbol Bootstrap | v1.1.4 | [symbol-bootstrap](https://www.npmjs.com/package/symbol-bootstrap) |
14+
| Symbol Network | v0.0.1 | [symbol-bootstrap](https://www.npmjs.com/package/symbol-network) |
1415

1516
- Very first version of the tool!

README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,8 @@ To handle dozens or hundreds of Symbol Nodes in "cattle" style, where nodes are
2727

2828
If you are creating a Symbol node for the first time, please have look at the [symbol-bootstrap](https://github.com/fboucquez/symbol-bootstrap) cli.
2929

30+
For more information, checkout this [guide/blog post](https://dev.to/fboucquez/how-to-create-a-symbol-testnet-network-4hdd).
31+
3032
# Requirements
3133

3234
- Node 12.0.0+

package-lock.json

Lines changed: 7 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@
6464
"lodash": "^4.17.21",
6565
"remove": "^0.1.5",
6666
"rxjs": "^7.5.2",
67-
"symbol-bootstrap": "^1.1.4-alpha-7dcd80b",
67+
"symbol-bootstrap": "^1.1.4",
6868
"symbol-sdk": "^1.0.4-alpha-202112211435",
6969
"tslib": "^2.3.1",
7070
"winston": "^3.5.1"

src/commands/generateNemesis.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ After running this command, your new network nemesis seed would be created. It a
5959
logger.info('');
6060
logger.info('Nemesis block has been generated. To verify the block using a demo box run:');
6161
logger.info('');
62-
logger.info(`$ symbol-bootstrap start -t ${nemesisTargetFolder} --noPassword --detached --healthCheck --report`);
62+
logger.info(`$ symbol-bootstrap start -t ${nemesisTargetFolder} --noPassword --detached --healthCheck --report --pullImages`);
6363
logger.info('');
6464
logger.info(`Try the demo node by going to:`);
6565
logger.info(' - Rest Accounts - http://localhost:3000/accounts');

src/services/NetworkAccountResolver.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ export class NetworkAccountResolver implements AccountResolver {
4040
if (!nodeName) {
4141
return this.promptAccount(networkType, account, keyName, nodeName, operationDescription, generateErrorMessage);
4242
}
43-
this.logger.info(`Loading ${keyName} Key for ${nodeName} of ${this.node.number}. Operation ${operationDescription}`);
43+
this.logger.info(`Loading ${keyName} Key for ${nodeName} number ${this.node.number}. Operation ${operationDescription}`);
4444
const storedAccount = await this.keyStore.getNodeAccount(networkType, keyName, nodeName, this.node, true);
4545
if (!storedAccount) {
4646
throw new Error(`${keyName} for node ${nodeName} does not exist!`);

src/services/NetworkConfigurationService.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -274,7 +274,7 @@ export class NetworkConfigurationService {
274274
this.logger.info('');
275275
this.logger.info(`The ${NetworkUtils.NETWORK_FILE} file has been updated!`);
276276
this.logger.info('');
277-
this.logger.info(`Nodes have been created/upgraded. `);
277+
this.logger.info(`Nodes have been created/upgraded. You can deploy them!`);
278278
this.logger.info('');
279279
}
280280

src/utils/InitService.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ export interface InitServiceParams {
5656

5757
export class InitService {
5858
constructor(private readonly logger: Logger, private readonly workingDir: string, private readonly params: InitServiceParams) {}
59+
5960
async execute(): Promise<void> {
6061
const networkInputFile = NetworkUtils.NETWORK_INPUT_FILE;
6162
const customNetworkPresetFile = NetworkUtils.NETWORK_PRESET_FILE;
@@ -391,10 +392,13 @@ export class InitService {
391392
const nickName = await this.promptName(`Nodes's Nick Name`, 'The nick name of the these nodes', metadata.nickName);
392393

393394
const restProtocol = metadata.api ? await this.promptRestProtocol() : undefined;
395+
394396
const { confirmCreate } = await prompt([
395397
{
396398
default: true,
397-
message: `Do you want to create ${total} nodes of type ${nodeTypeName} each with balance of ${balances.join(', ')}?`,
399+
message: balances.find((b) => b > 0)
400+
? `Do you want to create ${total} nodes of type ${nodeTypeName} each with balance of ${balances.join(', ')}?`
401+
: `Do you want to create ${total} nodes of type ${nodeTypeName}?`,
398402
type: 'confirm',
399403
name: 'confirmCreate',
400404
},
@@ -512,6 +516,7 @@ export class InitService {
512516
public async generateRandomKey(fieldName: string, message: string, networkType: NetworkType): Promise<string> {
513517
return this.promptText(fieldName, message, Account.generateNewAccount(networkType).privateKey, CommandUtils.isValidPrivateKey);
514518
}
519+
515520
public async promptName(fieldName: string, message: string, defaultValue: string | undefined): Promise<string> {
516521
return this.promptText(fieldName, message, defaultValue, this.isValidName);
517522
}
@@ -563,7 +568,6 @@ export class InitService {
563568
fieldName: string,
564569
message: string,
565570
defaultValue: string | undefined,
566-
567571
validate?: (input: any) => boolean | string | Promise<boolean | string>,
568572
): Promise<string> {
569573
return this.confirmedPrompt(

0 commit comments

Comments
 (0)