fix: latest debug to latest release

Author: eagleoflqj

src/config/about.swift

@@ -59,6 +59,7 @@ struct AboutView: View {
   @State private var uninstallFailed = false
   // The value is based on check update, and is only used for upgrading to release.
   // If upgrading/switching to debug, always use latest regardless of this value.
+  // If switching from latest debug to latest release, this value is nil.
   @State private var targetTag: String? = nil
   // If current version is latest, this is still true (for build type switch).
   @State private var latestAvailable = false
@@ -343,7 +344,11 @@ struct AboutView: View {
 
   func update(debug: Bool) {
     // See comment of targetTag.
-    guard let tag = debug && latestAvailable ? "latest" : targetTag else {
+    guard
+      let tag = getTag(
+        currentDebug: isDebug, targetDebug: debug, latestAvailable: latestAvailable,
+        targetTag: targetTag)
+    else {
       FCITX_ERROR("Calling update with nil tag")
       return
     }

src/config/tag.swift

@@ -0,0 +1,14 @@
+func getTag(currentDebug: Bool, targetDebug: Bool, latestAvailable: Bool, targetTag: String?)
+  -> String?
+{
+  if targetDebug && latestAvailable {
+    return "latest"
+  }
+  if targetTag != nil {
+    return targetTag
+  }
+  if currentDebug && !targetDebug && latestAvailable {
+    return "latest"
+  }
+  return nil
+}

tests/CMakeLists.txt

@@ -36,3 +36,8 @@ target_compile_options(KeySwift PUBLIC
 )
 target_link_libraries(KeySwift Keycode)
 add_test(NAME KeySwift COMMAND KeySwift)
+
+add_executable(TagSwift testtag.swift
+    ${PROJECT_SOURCE_DIR}/src/config/tag.swift
+)
+add_test(NAME TagSwift COMMAND TagSwift)

tests/testtag.swift

@@ -0,0 +1,57 @@
+import Foundation
+
+@_cdecl("main")
+func main() -> Int {
+// targetTag can be nil, version or latest. When latestAvailable is false, targetTag can't be latest.
+// So it's a combination of 2*2*5 = 20 cases.
+
+// Release to Release
+  // latest >> stable = current
+  assert(getTag(currentDebug: false, targetDebug: false, latestAvailable: false, targetTag: nil) == nil)
+  // latest >> stable > current
+  assert(getTag(currentDebug: false, targetDebug: false, latestAvailable: false, targetTag: "1") == "1")
+  // latest = current
+  assert(getTag(currentDebug: false, targetDebug: false, latestAvailable: true, targetTag: nil) == nil)
+  // stable > current
+  assert(getTag(currentDebug: false, targetDebug: false, latestAvailable: true, targetTag: "1") == "1")
+  // latest > current >= stable
+  assert(getTag(currentDebug: false, targetDebug: false, latestAvailable: true, targetTag: "latest") == "latest")
+
+// Release to Debug
+  // latest >> stable = current
+  let _ = getTag(currentDebug: false, targetDebug: true, latestAvailable: false, targetTag: nil) // Switch button not clickable.
+  // latest >> stable > current
+  let _ = getTag(currentDebug: false, targetDebug: true, latestAvailable: false, targetTag: "1") // Switch button not clickable.
+  // latest = current
+  assert(getTag(currentDebug: false, targetDebug: true, latestAvailable: true, targetTag: nil) == "latest")
+  // stable > current
+  assert(getTag(currentDebug: false, targetDebug: true, latestAvailable: true, targetTag: "1") == "latest")
+  // latest > current >= stable
+  assert(getTag(currentDebug: false, targetDebug: true, latestAvailable: true, targetTag: "latest") == "latest")
+
+// Debug to Release
+  // latest >> stable = current
+  let _ = getTag(currentDebug: true, targetDebug: false, latestAvailable: false, targetTag: nil) // We don't provide debug stable.
+  // latest >> stable > current
+  assert(getTag(currentDebug: true, targetDebug: false, latestAvailable: false, targetTag: "1") == "1")
+  // latest = current
+  assert(getTag(currentDebug: true, targetDebug: false, latestAvailable: true, targetTag: nil) == "latest")
+  // stable > current
+  assert(getTag(currentDebug: true, targetDebug: false, latestAvailable: true, targetTag: "1") == "1")
+  // latest > current >= stable
+  assert(getTag(currentDebug: true, targetDebug: false, latestAvailable: true, targetTag: "latest") == "latest")
+
+// Debug to Debug
+  // latest >> stable = current
+  let _ = getTag(currentDebug: true, targetDebug: true, latestAvailable: false, targetTag: nil) // We don't provide debug stable.
+  // latest >> stable > current
+  let _ = getTag(currentDebug: true, targetDebug: true, latestAvailable: false, targetTag: "1") // Update button not clickable.
+  // latest = current
+  let _ = getTag(currentDebug: true, targetDebug: true, latestAvailable: true, targetTag: nil) // Update button not clickable.
+  // stable > current
+  assert(getTag(currentDebug: true, targetDebug: true, latestAvailable: true, targetTag: "1") == "latest")
+  // latest > current >= stable
+  assert(getTag(currentDebug: true, targetDebug: true, latestAvailable: true, targetTag: "latest") == "latest")
+
+  return 0
+}