Skip to content

Commit f13de36

Browse files
committed
slight test refactor to make them more robust
1 parent a94283a commit f13de36

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

FluentCommandLineParser.Tests/FluentCommandLineParserTests.cs

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -932,37 +932,37 @@ public void Ensure_Additional_Arguments_Callback_Not_Called_When_No_Additional_A
932932
{
933933
var parser = CreateFluentParser();
934934

935-
var capturedAdditionalArgs = new List<string>();
935+
bool wasCalled = false;
936936

937937
parser.Setup<string>("my-option")
938-
.CaptureAdditionalArguments(capturedAdditionalArgs.AddRange);
938+
.CaptureAdditionalArguments(addArgs => wasCalled = true);
939939

940940
var result = parser.Parse(new[] { "--my-option", "value" });
941941

942942
Assert.IsFalse(result.HasErrors);
943943
Assert.IsFalse(result.EmptyArgs);
944944
Assert.IsFalse(result.HelpCalled);
945945

946-
Assert.IsEmpty(capturedAdditionalArgs);
946+
Assert.IsFalse(wasCalled);
947947
}
948948

949949
[Test]
950950
public void Ensure_Additional_Arguments_Callback_Not_Called_When_No_Additional_Args_Follow_A_Double_Dash()
951951
{
952952
var parser = CreateFluentParser();
953953

954-
var capturedAdditionalArgs = new List<string>();
954+
bool wasCalled = false;
955955

956956
parser.Setup<string>("my-option")
957-
.CaptureAdditionalArguments(capturedAdditionalArgs.AddRange);
957+
.CaptureAdditionalArguments(addArgs => wasCalled = true);
958958

959959
var result = parser.Parse(new[] { "--my-option", "value", "--" });
960960

961961
Assert.IsFalse(result.HasErrors);
962962
Assert.IsFalse(result.EmptyArgs);
963963
Assert.IsFalse(result.HelpCalled);
964964

965-
Assert.IsEmpty(capturedAdditionalArgs);
965+
Assert.IsFalse(wasCalled);
966966
}
967967

968968
[Test]
@@ -1011,7 +1011,7 @@ public void Ensure_Additional_Args_Can_Be_Captured_For_Different_Options()
10111011
Assert.IsTrue(option1AddArgs.Contains("addArg1"));
10121012
Assert.IsTrue(option1AddArgs.Contains("addArg2"));
10131013

1014-
Assert.AreEqual(2, option1AddArgs.Count());
1014+
Assert.AreEqual(2, option2AddArgs.Count());
10151015
Assert.IsTrue(option2AddArgs.Contains("addArg3"));
10161016
Assert.IsTrue(option2AddArgs.Contains("addArg4"));
10171017
}

0 commit comments

Comments
 (0)