fix: use spawn instead of block_on in TestDatabase Drop to avoid runtime nesting

The tokio #[tokio::test] macro creates its own runtime, so calling
block_on from Drop causes a 'Cannot start a runtime from within a
runtime' panic in CI. Using spawn() detaches the cleanup task instead.

Author: fcoury

crates/tsql/tests/common/mod.rs

@@ -73,17 +73,16 @@ impl TestDatabase {
 
         Ok(client)
     }
-
 }
 
 impl Drop for TestDatabase {
     fn drop(&mut self) {
         let admin_client = self.admin_client.clone();
         let db_name = self.db_name.clone();
 
-        // Use block_on to run the cleanup synchronously in Drop
-        // This ensures the database is dropped even if the test panics
-        let _ = self.rt.block_on(async move {
+        // Spawn the cleanup as a background task
+        // We can't use block_on inside an async runtime, so we spawn and detach
+        self.rt.spawn(async move {
             let client = admin_client.lock().await;
 
             // Terminate connections
@@ -178,10 +177,7 @@ mod tests {
         });
 
         let result = admin_client
-            .query(
-                "SELECT 1 FROM pg_database WHERE datname = $1",
-                &[&db_name],
-            )
+            .query("SELECT 1 FROM pg_database WHERE datname = $1", &[&db_name])
             .await
             .unwrap();
 

crates/tsql/tests/integration_tests.rs

@@ -2,7 +2,7 @@
 
 mod common;
 
-use common::{TestDatabase, get_test_database_url};
+use common::{get_test_database_url, TestDatabase};
 
 /// Test that we can connect to a PostgreSQL database successfully.
 #[tokio::test]
@@ -47,7 +47,9 @@ async fn test_query_error_message() {
     let client = test_db.connect().await.unwrap();
 
     // Execute an invalid query
-    let result = client.simple_query("SELECT * FROM nonexistent_table_xyz").await;
+    let result = client
+        .simple_query("SELECT * FROM nonexistent_table_xyz")
+        .await;
 
     assert!(result.is_err(), "Query should fail");