Skip to content

Commit fc1068c

Browse files
Awethonvlovgr
andauthored
removed retries value override (#1405)
Co-authored-by: Viktor Rudebeck <1163201+vlovgr@users.noreply.github.com>
1 parent cea58e4 commit fc1068c

File tree

2 files changed

+1
-7
lines changed

2 files changed

+1
-7
lines changed

docs/src/main/mdoc/producers.md

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -127,10 +127,6 @@ ProducerSettings(
127127

128128
### Default Settings
129129

130-
The following Java Kafka producer properties are overridden by default.
131-
132-
- `max.retries` is set to `0`, to avoid the risk of records being produced out-of-order. If we don't need to produce records in-order, then this can be set to some positive integer value. An alternative is to enable retries and use `withMaxInFlightRequestsPerConnection(1)` or `withEnableIdempotence(true)`. The blog post [Does Kafka really guarantee the order of messages?](https://blog.softwaremill.com/does-kafka-really-guarantee-the-order-of-messages-3ca849fd19d2) provides more detail on this topic.
133-
134130
The following settings are specific to the library.
135131

136132
- `withCloseTimeout` controls the timeout when waiting for producer shutdown. Default is 60 seconds.

modules/core/src/main/scala/fs2/kafka/ProducerSettings.scala

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -332,9 +332,7 @@ object ProducerSettings {
332332
keySerializer = keySerializer,
333333
valueSerializer = valueSerializer,
334334
customBlockingContext = None,
335-
properties = Map(
336-
ProducerConfig.RETRIES_CONFIG -> "0"
337-
),
335+
properties = Map.empty,
338336
closeTimeout = 60.seconds,
339337
failFastProduce = false
340338
)

0 commit comments

Comments
 (0)