core submodule update, warning fixes

Author: AlePalu

fdaPDE/core

@@ -76,7 +76,6 @@ struct fe_de_separable {
     }
     // injects penalty tuple into discretize()
     template <typename GeoFrame, typename Penalty> void discretize_loop_(const GeoFrame& gf, Penalty&& penalty) {
-        using Penalty_ = std::decay_t<Penalty>;
         auto pen_tuple = tuplify_penalty_(gf, penalty);
         internals::apply_index_pack<n_lambda>([&]<int... Ns_>() { discretize(std::get<Ns_>(pen_tuple)...); });
         return;
@@ -280,7 +279,6 @@ struct fe_de_separable {
         // one penalty must be on a FeSpace
         fdapde_static_assert(is_fe_space_v<FS1> || is_fe_space_v<FS2>, NO_FINITE_ELEMENT_SPACE_DETECTED);
         constexpr int fe_space_index = is_fe_space_v<FS1> ? 0 : 1;
-        using FeSpace = std::tuple_element_t<fe_space_index, FunctionSpaces>;
         constexpr int bs_space_index = is_fe_space_v<FS1> ? 1 : 0;
         using BsSpace = std::tuple_element_t<bs_space_index, FunctionSpaces>;
 	// enforce a space-time (or SpaceMajor) expansion: index 0 refer to the spatial finite element discretization

fdaPDE/src/solvers/fe_de_separable.h

@@ -808,7 +808,6 @@ struct fe_ls_parabolic_ieul {
         y_ = y;
 	// correct \Psi for missing observations
         auto nan_pattern = na_matrix(y);
-        int old_n_obs = n_obs_;
         if (nan_pattern.any()) {
             n_obs_ = n_locs_ - nan_pattern.count();
             B_.resize(m_);

fdaPDE/src/solvers/fe_ls_parabolic.h

@@ -111,7 +111,6 @@ class fe_ls_separable_mono {
     }
     // unrolls the penalty tuple and injects them into discretize()
     template <typename Penalty> void discretize_loop_(Penalty&& penalty) {
-        using Penalty_ = std::decay_t<Penalty>;
         internals::apply_index_pack<n_lambda>(
           [&]<int... Ns_>() { discretize([&]() { return std::get<Ns_>(penalty); }()...); });
         return;
@@ -164,7 +163,6 @@ class fe_ls_separable_mono {
         // one penalty must be on a FeSpace
         fdapde_static_assert(is_fe_space_v<FS1> || is_fe_space_v<FS2>, NO_FINITE_ELEMENT_SPACE_DETECTED);
         constexpr int fe_space_index = is_fe_space_v<FS1> ? 0 : 1;
-        using FeSpace = std::tuple_element_t<fe_space_index, FunctionSpaces>;
         constexpr int bs_space_index = is_fe_space_v<FS1> ? 1 : 0;
         using BsSpace = std::tuple_element_t<bs_space_index, FunctionSpaces>;
         // we enforce a space-time (or SpaceMajor) expansion of the field by reordering the forms so that, index 0