Fixed template parsing with several <<>> placeholders, and also when template has both <<>> and normal placeholders and null replacement is passed.

The function may be a bit more complex now, but simpler solutions were 4-5 times slower, which was a considerable amount. In the cases where the previous implementation worked fine, the new one is as fast, or in some benchmarks even faster.

Author: Neverbirth

External/Plugins/ASCompletion/Completion/TemplateUtils.cs

@@ -157,20 +157,34 @@ public static string CallParametersString(MemberModel member)
 
         public static string ReplaceTemplateVariable(string template, string var, string replace)
         {
-            Match m = Regex.Match(template, String.Format(template_variable, var));
-            if (m.Success)
+            MatchCollection mc = Regex.Matches(template, String.Format(template_variable, var));
+            int mcCount = mc.Count;
+            if (mcCount > 0)
             {
-                if (replace == null)
+                var sb = new System.Text.StringBuilder();
+                int pos = 0;
+                for (int i = 0; i < mcCount; i++)
                 {
-                    template = template.Substring(0, m.Index) + template.Substring(m.Index + m.Length);
-                    return template;
-                }
-                else
-                {
-                    string val = m.Value;
-                    val = val.Substring(2, val.Length - 4);
-                    template = template.Substring(0, m.Index) + val + template.Substring(m.Index + m.Length);
+                    Match m = mc[i];
+                    int endIndex = m.Index + m.Length;
+                    sb.Append(template.Substring(pos, m.Index - pos));
+                    if (replace != null)
+                    {
+                        string val = m.Value;
+                        val = val.Substring(2, val.Length - 4);
+                        sb.Append(val);
+                    }
+                    if (i == mcCount - 1)
+                        sb.Append(template.Substring(endIndex));
+                    else
+                    {
+                        int next = mc[i + 1].Index;
+                        sb.Append(template.Substring(endIndex, next - endIndex));
+                        pos += next;
+                    }
                 }
+
+                template = sb.ToString();
             }
             template = template.Replace("$(" + var + ")", replace);
             return template;