Do not crash when no Haxe SDK is defined.

Do not set Haxe env every time a haxelib is resolved.

Author: elsassph

External/Plugins/HaXeContext/Completion/CompilerCompletionHandler.cs

@@ -15,7 +15,7 @@ public CompilerCompletionHandler(Process haxeProcess)
 
         public string GetCompletion(string[] args)
         {
-            if (args == null)
+            if (args == null || haxeProcess == null)
                 return string.Empty;
             haxeProcess.StartInfo.Arguments = String.Join(" ", args);
             haxeProcess.Start();

External/Plugins/HaXeContext/Completion/CompletionServerCompletionHandler.cs

@@ -24,7 +24,6 @@ public CompletionServerCompletionHandler(Process haxeProcess, int port)
         {
             this.haxeProcess = haxeProcess;
             this.port = port;
-            //haxeProcess.Start(); // deferred to first use
             Environment.SetEnvironmentVariable("HAXE_SERVER_PORT", "" + port);
         }
 
@@ -41,9 +40,9 @@ public bool IsRunning()
 
         public string GetCompletion(string[] args)
         {
-            if (!IsRunning()) StartServer();
-            if (args == null)
+            if (args == null || haxeProcess == null)
                 return string.Empty;
+            if (!IsRunning()) StartServer();
             try
             {
                 var client = new TcpClient("127.0.0.1", port);
@@ -70,7 +69,7 @@ public string GetCompletion(string[] args)
 
         public void StartServer()
         {
-            if (IsRunning()) return;
+            if (haxeProcess == null || IsRunning()) return;
             haxeProcess.Start();
             if (!listening)
             {
@@ -90,7 +89,6 @@ void haxeProcess_OutputDataReceived(object sender, DataReceivedEventArgs e)
         void haxeProcess_ErrorDataReceived(object sender, DataReceivedEventArgs e)
         {
             if (e.Data == null) return;
-            //TraceManager.AddAsync(e.Data);
             if (Regex.IsMatch(e.Data, "Error.*--wait"))
             {
                 if (!failure && FallbackNeeded != null) 

External/Plugins/HaXeContext/Context.cs

@@ -162,7 +162,7 @@ private List<string> LookupLibrary(string lib)
                 string hxPath = currentSDK;
                 if (hxPath != null && Path.IsPathRooted(hxPath))
                 {
-                    SetHaxeEnvironment(hxPath);
+                    if (hxPath != currentEnv) SetHaxeEnvironment(hxPath);
                     haxelib = Path.Combine(hxPath, haxelib);
                 }
 
@@ -242,14 +242,14 @@ public void LoadMetadata()
             features.metadata = new Dictionary<string, string>();
 
             Process process = createHaxeProcess("--help-metas");
+            if (process == null) return;
             process.Start();
 
             String metaList = process.StandardOutput.ReadToEnd();
             process.Close();
 
             Regex regex = new Regex("@:([a-zA-Z]*)(?: : )(.*?)(?= @:[a-zA-Z]* :)");
             metaList = Regex.Replace(metaList, "\\s+", " ");
-            metaList += "@:fake :";
 
             MatchCollection matches = regex.Matches(metaList);
 
@@ -1129,11 +1129,8 @@ private Process createHaxeProcess(string args)
             // compiler path
             var hxPath = currentSDK ?? ""; 
             var process = Path.Combine(hxPath, "haxe.exe");
-            /*if (!File.Exists(process))
-            {
-                ErrorManager.ShowInfo(String.Format(TextHelper.GetString("Info.HaXeExeError"), "\n"));
+            if (!File.Exists(process))
                 return null;
-            }*/
 
             // Run haxe compiler
             Process proc = new Process();