Skip to content

Commit 883692e

Browse files
committed
- DefaultBuildTargets is now preferred over TargetBuildTypes if both are used
- Now only whitespace around commas are stripped in DefaultBuildTargets
1 parent 99a8aee commit 883692e

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

External/Plugins/ProjectManager/Controls/FDMenus.cs

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -130,18 +130,18 @@ public void CloseProject()
130130
public void ProjectChanged(Project project)
131131
{
132132
TargetBuildSelector.Items.Clear();
133-
if (project.MovieOptions.TargetBuildTypes != null)
133+
if (project.MovieOptions.DefaultBuildTargets != null && project.MovieOptions.DefaultBuildTargets.Length > 0)
134+
{
135+
TargetBuildSelector.Items.AddRange(project.MovieOptions.DefaultBuildTargets);
136+
TargetBuildSelector.Text = project.MovieOptions.DefaultBuildTargets[0];
137+
}
138+
else if (project.MovieOptions.TargetBuildTypes != null && project.MovieOptions.TargetBuildTypes.Length > 0)
134139
{
135140
TargetBuildSelector.Items.AddRange(project.MovieOptions.TargetBuildTypes);
136141
string target = project.TargetBuild ?? project.MovieOptions.TargetBuildTypes[0];
137-
if (target != "" && !TargetBuildSelector.Items.Contains(target)) TargetBuildSelector.Items.Insert(0, target);
142+
if (!String.IsNullOrEmpty(target) && !TargetBuildSelector.Items.Contains(target)) TargetBuildSelector.Items.Insert(0, target);
138143
TargetBuildSelector.Text = target;
139144
}
140-
else if (project.MovieOptions.DefaultBuildTargets != null && project.MovieOptions.DefaultBuildTargets.Length > 0)
141-
{
142-
TargetBuildSelector.Items.AddRange(project.MovieOptions.DefaultBuildTargets);
143-
TargetBuildSelector.Text = project.MovieOptions.DefaultBuildTargets[0];
144-
}
145145
else
146146
{
147147
string target = project.TargetBuild ?? "";

External/Plugins/ProjectManager/Projects/ProjectReader.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -189,8 +189,8 @@ public void ReadProjectOptions()
189189
case "defaultBuildTargets":
190190
if (!String.IsNullOrEmpty(Value.Trim()) && Value.IndexOf(",") > -1)
191191
{
192-
String trimmed = new String(Value.Where(c => !Char.IsWhiteSpace(c)).ToArray());
193-
project.MovieOptions.DefaultBuildTargets = trimmed.Split(',');
192+
String[] cleaned = Value.Trim().Split(',').Select(x => x.Trim()).ToArray<String>();
193+
project.MovieOptions.DefaultBuildTargets = cleaned;
194194
}
195195
break;
196196

0 Bytes
Binary file not shown.

0 commit comments

Comments
 (0)