Replace 'string_value != null && string_value != string.Empty' by '!string.IsNullOrEmpty(string_value)'

SlavaRa · SlavaRa · commit 8ab7c14896bf · 2015-09-17T21:39:35.000+03:00
diff --git a/External/Tools/FDBuild/Mono/GetOptions/OptionDetails.cs b/External/Tools/FDBuild/Mono/GetOptions/OptionDetails.cs
@@ -252,7 +252,7 @@ public override string ToString()
             {
                 string text1;
                 string text2;
-                bool flag1 = (this.LongForm != null) && (this.LongForm != string.Empty);
+                bool flag1 = !string.IsNullOrEmpty(this.LongForm);
                 if (this.OptionBundle.ParsingMode == OptionsParsingMode.Windows)
                 {
                     text2 = "/";
@@ -279,7 +279,7 @@ public override string ToString()
                     this.optionHelp = this.optionHelp + "[+|-]";
                 }
                 this.optionHelp = this.optionHelp + ("\t" + this.ShortDescription);
-                if ((this.AlternateForm != string.Empty) && (this.AlternateForm != null))
+                if (!string.IsNullOrEmpty(this.AlternateForm))
                 {
                     this.optionHelp = this.optionHelp + (" [short form: " + text2 + this.AlternateForm + "]");
                 }

Original file line number	Diff line number	Diff line change
`@@ -252,7 +252,7 @@ public override string ToString()`
`252`	`252`	`{`
`253`	`253`	`string text1;`
`254`	`254`	`string text2;`
`255`		`- bool flag1 = (this.LongForm != null) && (this.LongForm != string.Empty);`
	`255`	`+ bool flag1 = !string.IsNullOrEmpty(this.LongForm);`
`256`	`256`	`if (this.OptionBundle.ParsingMode == OptionsParsingMode.Windows)`
`257`	`257`	`{`
`258`	`258`	`text2 = "/";`
`@@ -279,7 +279,7 @@ public override string ToString()`
`279`	`279`	`this.optionHelp = this.optionHelp + "[+\|-]";`
`280`	`280`	`}`
`281`	`281`	`this.optionHelp = this.optionHelp + ("\t" + this.ShortDescription);`
`282`		`- if ((this.AlternateForm != string.Empty) && (this.AlternateForm != null))`
	`282`	`+ if (!string.IsNullOrEmpty(this.AlternateForm))`
`283`	`283`	`{`
`284`	`284`	`this.optionHelp = this.optionHelp + (" [short form: " + text2 + this.AlternateForm + "]");`
`285`	`285`	`}`