Document list access improvements...

Author: Meychi

External/Plugins/FlashDebugger/Debugger/BreakPointManager.cs

@@ -191,9 +191,9 @@ public Boolean ShouldBreak(SourceFile file, int line, Frame frame)
         public void SetBreakPointsToEditor(PluginCore.ITabbedDocument[] documents)
         {
             m_bAccessable = false;
-            for (int i = 0; i < documents.Length; i++)
+            foreach (ITabbedDocument document in documents)
             {
-                ScintillaControl sci = documents[i].SciControl;
+                ScintillaControl sci = document.SciControl;
                 if (sci == null) continue;
                 if (Path.GetExtension(sci.FileName) == ".as" || Path.GetExtension(sci.FileName) == ".mxml")
                 {
@@ -213,10 +213,9 @@ public void SetBreakPointsToEditor(PluginCore.ITabbedDocument[] documents)
         public void SetBreakPointsToEditor(string filefullpath)
         {
             m_bAccessable = false;
-            ITabbedDocument[] documents = PluginBase.MainForm.Documents;
-            for (int i = 0; i < documents.Length; i++)
+            foreach (ITabbedDocument document in PluginBase.MainForm.Documents)
             {
-                ScintillaControl sci = documents[i].SciControl;
+                ScintillaControl sci = document.SciControl;
                 if (sci == null) continue;
                 if (sci.FileName.Equals(filefullpath, StringComparison.OrdinalIgnoreCase))
                 {

FlashDevelop/MainForm.cs

@@ -644,13 +644,12 @@ public DockContent OpenEditableDocument(String org, Encoding encoding, Boolean r
             }
             try
             {
-                Int32 count = this.Documents.Length;
-                for (Int32 i = 0; i < count; i++)
+                foreach (ITabbedDocument doc in this.Documents)
                 {
-                    if (this.Documents[i].IsEditable && this.Documents[i].FileName.ToUpper() == file.ToUpper())
+                    if (doc.IsEditable && doc.FileName.ToUpper() == file.ToUpper())
                     {
-                        this.Documents[i].Activate();
-                        return null;
+                        doc.Activate();
+                        return doc as DockContent;
                     }
                 }
             }

FlashDevelop/Managers/TabbingManager.cs

@@ -41,10 +41,11 @@ private static void OnTabTimer(Object sender, System.EventArgs e)
         /// </summary>
         public static void UpdateSequentialIndex(ITabbedDocument document)
         {
-            Int32 count = Globals.MainForm.Documents.Length;
+            ITabbedDocument[] documents = Globals.MainForm.Documents;
+            Int32 count = documents.Length;
             for (Int32 i = 0; i < count; i++)
             {
-                if (document == Globals.MainForm.Documents[i])
+                if (document == documents[i])
                 {
                     SequentialIndex = i;
                     return;

PluginCore/PluginCore/Managers/DocumentManager.cs

@@ -66,7 +66,7 @@ public static void MoveDocuments(String oldPath, String newPath)
             foreach (ITabbedDocument document in PluginBase.MainForm.Documents)
             {
                 /* We need to check for virtual models, another more generic option would be 
-                 *  Path.GetFileName(document.FileName).IndexOfAny(Path.GetInvalidFileNameChars()) == -1
+                 * Path.GetFileName(document.FileName).IndexOfAny(Path.GetInvalidFileNameChars()) == -1
                  * But this one is used in more places */
                 if (document.IsEditable && !document.Text.StartsWith("[model] "))
                 {
@@ -114,13 +114,11 @@ public static void ActivateDocument(Int32 index)
         /// </summary>
         public static ITabbedDocument FindDocument(String filename)
         {
-            Int32 count = PluginBase.MainForm.Documents.Length;
-            for (Int32 i = 0; i < count; i++)
+            foreach (ITabbedDocument document in PluginBase.MainForm.Documents)
             {
-                ITabbedDocument current = PluginBase.MainForm.Documents[i];
-                if (current.IsEditable && current.FileName == filename)
+                if (document.IsEditable && document.FileName == filename)
                 {
-                    return current;
+                    return document;
                 }
             }
             return null;
@@ -131,13 +129,11 @@ public static ITabbedDocument FindDocument(String filename)
         /// </summary>
         public static ITabbedDocument FindDocument(ScintillaControl sci)
         {
-            Int32 count = PluginBase.MainForm.Documents.Length;
-            for (Int32 i = 0; i < count; i++)
+            foreach (ITabbedDocument document in PluginBase.MainForm.Documents)
             {
-                ITabbedDocument current = PluginBase.MainForm.Documents[i];
-                if (current.IsEditable && current.SciControl == sci)
+                if (document.IsEditable && document.SciControl == sci)
                 {
-                    return current;
+                    return document;
                 }
             }
             return null;