Replace 'string_value != null && string_value.Length > 0' by '!string.isNullOrEmpty(string_value)'

SlavaRa · SlavaRa · commit af853beddd0c · 2015-08-25T09:23:04.000+03:00
diff --git a/External/Plugins/ASCompletion/Completion/ASComplete.cs b/External/Plugins/ASCompletion/Completion/ASComplete.cs
@@ -1868,7 +1868,7 @@ static private bool HandleDotCompletion(ScintillaControl Sci, bool autoHide)
                 int line = Sci.LineFromPosition(position);
                 if (cMember == null && !ASContext.Context.CurrentClass.IsVoid())
                 {
-                    if (expr.Value != null && expr.Value.Length > 0)
+                    if (!string.IsNullOrEmpty(expr.Value))
                         return HandleDeclarationCompletion(Sci, expr.Value, autoHide);
                     else if (ASContext.Context.CurrentModel.Version >= 2)
                         return ASGenerator.HandleGeneratorCompletion(Sci, autoHide, features.overrideKey);
@@ -3613,7 +3613,7 @@ private static ComaExpression DisambiguateComa(ScintillaControl Sci, int positio
         static public MemberList ParseLocalVars(ASExpr expression)
         {
             FileModel model;
-            if (expression.FunctionBody != null && expression.FunctionBody.Length > 0)
+            if (!string.IsNullOrEmpty(expression.FunctionBody))
             {
                 MemberModel cm = expression.ContextMember;
                 string functionBody = Regex.Replace(expression.FunctionBody, "function\\s*\\(", "function __anonfunc__("); // name anonymous functions
diff --git a/External/Plugins/ASCompletion/Completion/ASDocumentation.cs b/External/Plugins/ASCompletion/Completion/ASDocumentation.cs
@@ -430,7 +430,7 @@ static public string GetTipShortDetails(CommentBlock cb, string highlightParam)
             string details = "";
             
             // get parameter detail
-            if (highlightParam != null && highlightParam.Length > 0 && cb.ParamName != null)
+            if (!string.IsNullOrEmpty(highlightParam) && cb.ParamName != null)
             {
                 for(int i=0; i<cb.ParamName.Count; i++)
                 {
@@ -445,9 +445,9 @@ static public string GetTipShortDetails(CommentBlock cb, string highlightParam)
             // get description extract
             if (ASContext.CommonSettings.SmartTipsEnabled)
             {
-                if (cb.InfoTip != null && cb.InfoTip.Length > 0)
+                if (!string.IsNullOrEmpty(cb.InfoTip))
                     details += "\n"+cb.InfoTip;
-                else if (cb.Description != null && cb.Description.Length > 0) 
+                else if (!string.IsNullOrEmpty(cb.Description)) 
                     details += Get2LinesOf(cb.Description, cb.IsFunctionWithArguments);
             }
 
diff --git a/External/Plugins/ASCompletion/Completion/ASGenerator.cs b/External/Plugins/ASCompletion/Completion/ASGenerator.cs
@@ -2166,7 +2166,7 @@ private static int GetContextOwnerEndPos(ScintillaControl Sci, int worsStartPos)
 
         static public string Capitalize(string name)
         {
-            return name != null && name.Length > 0 ? Char.ToUpper(name[0]) + name.Substring(1) : name;
+            return !string.IsNullOrEmpty(name) ? Char.ToUpper(name[0]) + name.Substring(1) : name;
         }
 
         static public string Camelize(string name)
@@ -3098,7 +3098,7 @@ private static string GuessVarName(string name, string type)
 
             if (name == "this" || type == name)
             {
-                if (type != null && type.Length > 0)
+                if (!string.IsNullOrEmpty(type))
                     name = Char.ToLower(type[0]) + type.Substring(1);
                 else
                     name = "p_this";
diff --git a/External/Plugins/ASCompletion/Completion/TemplateUtils.cs b/External/Plugins/ASCompletion/Completion/TemplateUtils.cs
@@ -75,7 +75,7 @@ public static string ToDeclarationString(MemberModel m, string template)
             // If method, insert arguments
             template = ReplaceTemplateVariable(template, "Arguments", ParametersString(m, true));
 
-            if (m.Type != null && m.Type.Length > 0)
+            if (!string.IsNullOrEmpty(m.Type))
             {
                 if ((m.Flags & FlagType.Setter) > 0 && m.Parameters != null && m.Parameters.Count == 1)
                     template = ReplaceTemplateVariable(template, "Type", FormatType(m.Parameters[0].Type));
@@ -111,7 +111,7 @@ public static string ParametersString(MemberModel member, bool formated)
 
                     one = ReplaceTemplateVariable(one, "PName", param.Name);
 
-                    if (param.Type != null && param.Type.Length > 0)
+                    if (!string.IsNullOrEmpty(param.Type))
                         one = ReplaceTemplateVariable(one, "PType", formated ? FormatType(param.Type) : param.Type);
                     else
                         one = ReplaceTemplateVariable(one, "PType", null);
diff --git a/External/Plugins/ASCompletion/CustomControls/ModelsExplorer.cs b/External/Plugins/ASCompletion/CustomControls/ModelsExplorer.cs
@@ -432,7 +432,7 @@ private void updateTimer_Tick(object sender, EventArgs e)
 
         private void FindPrevMatch(string search)
         {
-            if (search != null && allTypes != null && search.Length > 0)
+            if (!string.IsNullOrEmpty(search) && allTypes != null)
             {
                 typeIndex--;
                 if (typeIndex <= 0) typeIndex = allTypes.Count;
@@ -452,7 +452,7 @@ private void FindPrevMatch(string search)
 
         private void FindNextMatch(string search)
         {
-            if (search != null && allTypes != null && search.Length > 0)
+            if (!string.IsNullOrEmpty(search) && allTypes != null)
             {
                 while (typeIndex < allTypes.Count)
                 {
diff --git a/External/Plugins/ASCompletion/Model/ASFileParser.cs b/External/Plugins/ASCompletion/Model/ASFileParser.cs
@@ -244,7 +244,7 @@ private static MemberModel extractTypedCallbackModel(string comment)
             for (i = 0; i < l; i++)
             {
                 string pName = pMatches[i].Groups["pName"].Value;
-                if (pName != null && pName.Length > 0)
+                if (!string.IsNullOrEmpty(pName))
                 {
                     foreach (KeyValuePair<String,String> replEntry in qStrRepls)
                     {
@@ -257,7 +257,7 @@ private static MemberModel extractTypedCallbackModel(string comment)
                 }
 
                 string pType = pMatches[i].Groups["pType"].Value;
-                if (pType != null && pType.Length > 0)
+                if (!string.IsNullOrEmpty(pType))
                 {
                     foreach (KeyValuePair<String,String> replEntry in qStrRepls)
                     {
@@ -270,7 +270,7 @@ private static MemberModel extractTypedCallbackModel(string comment)
                 }
 
                 string pVal = pMatches[i].Groups["pVal"].Value;
-                if (pVal != null && pVal.Length > 0)
+                if (!string.IsNullOrEmpty(pVal))
                 {
                     if (qStrRepls.ContainsKey(pVal))
                     {
diff --git a/External/Plugins/ASCompletion/Model/ClassModel.cs b/External/Plugins/ASCompletion/Model/ClassModel.cs
@@ -448,7 +448,7 @@ static public string ClassDeclaration(ClassModel ofClass, bool qualified)
                     else modifiers += "intrinsic ";
                 }
                 else if (ofClass.InFile.Version > 2)
-                    if (ofClass.Namespace != null && ofClass.Namespace.Length > 0 
+                    if (!string.IsNullOrEmpty(ofClass.Namespace) 
                         && ofClass.Namespace != "internal") 
                     {
                     //  if ((ft & FlagType.Interface) == 0)
@@ -502,7 +502,7 @@ static public string MemberDeclaration(MemberModel member, bool preventVisibilit
                 if ((ft & FlagType.Extern) > 0) modifiers += "extern ";
                 else modifiers += "intrinsic ";
             }
-            else if (member.Namespace != null && member.Namespace.Length > 0 
+            else if (!string.IsNullOrEmpty(member.Namespace) 
                 && member.Namespace != "internal")
             {
                 if ((ft & FlagType.Interface) == 0)
diff --git a/External/Plugins/ASCompletion/Model/MemberModel.cs b/External/Plugins/ASCompletion/Model/MemberModel.cs
@@ -140,7 +140,7 @@ public string ToDeclarationString(bool wrapWithSpaces, bool concatValue)
                     if (Parameters != null && Parameters.Count > 0)
                     {
                         comment = "/*(" + ParametersString(true) + ")";
-                        if (Type != null && Type.Length > 0)
+                        if (!string.IsNullOrEmpty(Type))
                             comment += colon + FormatType(Type);
                         comment += "*/";
                     }
@@ -151,12 +151,12 @@ public string ToDeclarationString(bool wrapWithSpaces, bool concatValue)
                 }
             }
 
-            if ((type == null || type.Length == 0) && (Type != null && Type.Length > 0))
+            if (string.IsNullOrEmpty(type) && !string.IsNullOrEmpty(Type))
                 type = FormatType(Type);
 
             if ((Flags & FlagType.Constructor) > 0)
                 return res;
-            else if (type != null && type.Length > 0)
+            else if (!string.IsNullOrEmpty(type))
                 res += colon + type;
 
             res += comment;
diff --git a/External/Plugins/ASCompletion/PluginUI.cs b/External/Plugins/ASCompletion/PluginUI.cs
@@ -741,7 +741,7 @@ private void AddExtend(TreeNodeCollection tree, ClassModel aClass)
             //if ((aClass.Flags & FlagType.TypeDef) > 0 && aClass.Members.Count == 0)
             //    folder.Text = "Defines"; // TODO need a better word I guess
 
-            while (aClass.ExtendsType != null && aClass.ExtendsType.Length > 0 
+            while (!string.IsNullOrEmpty(aClass.ExtendsType) 
                 && aClass.ExtendsType != "Object" 
                 && (!aClass.InFile.haXe || aClass.ExtendsType != "Dynamic"))
             {
diff --git a/External/Plugins/ProjectManager/Controls/NewProjectDialog.cs b/External/Plugins/ProjectManager/Controls/NewProjectDialog.cs
@@ -362,7 +362,7 @@ void NewProjectDialog_Load(object sender, EventArgs e)
             createDirectoryBox.Checked = PluginMain.Settings.CreateProjectDirectory;
 
             string locationDir = PluginMain.Settings.NewProjectDefaultDirectory;
-            if (locationDir != null && locationDir.Length > 0 && Directory.Exists(locationDir))
+            if (!string.IsNullOrEmpty(locationDir) && Directory.Exists(locationDir))
                 locationTextBox.Text = locationDir;
             else locationTextBox.Text = ProjectPaths.DefaultProjectsDirectory;
             locationTextBox.SelectionStart = locationTextBox.Text.Length;
diff --git a/External/Plugins/ProjectManager/PluginMain.cs b/External/Plugins/ProjectManager/PluginMain.cs
@@ -863,7 +863,7 @@ void OpenSwf(string path)
             }
             else if (project.TestMovieBehavior == TestMovieBehavior.OpenDocument)
             {
-                if (project.TestMovieCommand != null && project.TestMovieCommand.Length > 0)
+                if (!string.IsNullOrEmpty(project.TestMovieCommand))
                 {
                     if (project.TraceEnabled && project.EnableInteractiveDebugger)
                     {
@@ -909,7 +909,7 @@ void OpenSwf(string path)
             }
             else if (project.TestMovieBehavior == TestMovieBehavior.Custom)
             {
-                if (project.TestMovieCommand != null && project.TestMovieCommand.Length > 0)
+                if (!string.IsNullOrEmpty(project.TestMovieCommand))
                 {
                     if (project.TraceEnabled && project.EnableInteractiveDebugger)
                     {
diff --git a/External/Plugins/ProjectManager/PluginUI.cs b/External/Plugins/ProjectManager/PluginUI.cs
@@ -218,7 +218,7 @@ private void tree_BeforeLabelEdit(Object sender, NodeLabelEditEventArgs e)
         /// </summary>
         private void tree_AfterLabelEdit(Object sender, NodeLabelEditEventArgs e)
         {
-            if (e.Label != null && Rename != null && e.Label.Length > 0)
+            if (!string.IsNullOrEmpty(e.Label) && Rename != null)
             {
                 if (!Rename((e.Node as GenericNode).BackingPath, e.Label))
                     e.CancelEdit = true;
diff --git a/External/Plugins/ProjectManager/Projects/AS2/AS2Project.cs b/External/Plugins/ProjectManager/Projects/AS2/AS2Project.cs
@@ -66,7 +66,7 @@ public override bool Clean()
         {
             try
             {
-                if (OutputPath != null && OutputPath.Length > 0 && File.Exists(GetAbsolutePath(OutputPath)))
+                if (!string.IsNullOrEmpty(OutputPath) && File.Exists(GetAbsolutePath(OutputPath)))
                     File.Delete(GetAbsolutePath(OutputPath));
                 return true;
             }
diff --git a/External/Plugins/ProjectManager/Projects/AS3/AS3Project.cs b/External/Plugins/ProjectManager/Projects/AS3/AS3Project.cs
@@ -107,7 +107,7 @@ public override bool Clean()
         {
             try
             {
-                if (OutputPath != null && OutputPath.Length > 0 && File.Exists(GetAbsolutePath(OutputPath)))
+                if (!string.IsNullOrEmpty(OutputPath) && File.Exists(GetAbsolutePath(OutputPath)))
                     File.Delete(GetAbsolutePath(OutputPath));
                 return true;
             }
diff --git a/External/Plugins/ProjectManager/Projects/Haxe/HaxeProject.cs b/External/Plugins/ProjectManager/Projects/Haxe/HaxeProject.cs
@@ -131,7 +131,7 @@ public override bool Clean()
         {
             try
             {
-                if (OutputPath != null && OutputPath.Length > 0 && File.Exists(GetAbsolutePath(OutputPath)))
+                if (!string.IsNullOrEmpty(OutputPath) && File.Exists(GetAbsolutePath(OutputPath)))
                 {
                     if (MovieOptions.HasPlatformSupport && MovieOptions.PlatformSupport.ExternalToolchain == null)
                         File.Delete(GetAbsolutePath(OutputPath));
@@ -240,7 +240,7 @@ public string[] BuildHXML(string[] paths, string outfile, bool release )
                 }
 
                 // add main class
-                if (CompilerOptions.MainClass != null && CompilerOptions.MainClass.Length > 0)
+                if (!string.IsNullOrEmpty(CompilerOptions.MainClass))
                     pr.Add("-main " + CompilerOptions.MainClass);
                 
                 // extra options
diff --git a/External/Plugins/XMLCompletion/XMLComplete.cs b/External/Plugins/XMLCompletion/XMLComplete.cs
@@ -169,14 +169,14 @@ private static void TryLoadDeclaration(string ext)
                     else defaultNS = defs.Attributes["defaultNS"].Value;
 
                     foreach(XmlNode tag in defs.ChildNodes)
-                    if (tag.Name != null && tag.Name.Length > 0 && tag.Name[0] != '#')
+                    if (!string.IsNullOrEmpty(tag.Name) && tag.Name[0] != '#')
                     {
                         isLeaf = tag.Attributes["leaf"];
                         ns = tag.Attributes["ns"];
                         htag = new HTMLTag(
                             (toUpper) ? tag.Name.ToUpper() : tag.Name, 
                             (ns != null) ? ns.Value : null, isLeaf != null && isLeaf.Value == "yes");
-                        if (htag.NS != null && htag.NS.Length > 0 && !namespaces.Contains(htag.NS))
+                        if (!string.IsNullOrEmpty(htag.NS) && !namespaces.Contains(htag.NS))
                             namespaces.Add(htag.NS);
                         htag.Attributes = new List<string>();
                         temp = tag.Attributes["at"].Value;
diff --git a/FlashDevelop/Managers/SnippetManager.cs b/FlashDevelop/Managers/SnippetManager.cs
@@ -52,7 +52,7 @@ public static Boolean InsertTextByWord(String word, Boolean emptyUndoBuffer)
                 canShowList = true;
                 word = sci.GetWordFromPosition(sci.CurrentPos);
             }
-            if (word != null && word.Length > 0)
+            if (!string.IsNullOrEmpty(word))
             {
                 snippet = GetSnippet(word, sci.ConfigurationLanguage, sci.Encoding);
             }
diff --git a/PluginCore/BBCode/BBCodeTagMatch.cs b/PluginCore/BBCode/BBCodeTagMatch.cs
@@ -42,7 +42,7 @@ private void _init(Boolean isTagOpener,
 
             _tagCloserInfos = new List<BBCodeTagInfo>();
 
-            if (autoGenerateCloserInfo && isTagOpener && tagName != null && tagName.Length > 0)
+            if (autoGenerateCloserInfo && isTagOpener && !string.IsNullOrEmpty(tagName))
                 _tagCloserInfos.Add(new BBCodeTagInfo(false, tagName, null));
         }
 
diff --git a/PluginCore/BBCode/BBCodeUtils.cs b/PluginCore/BBCode/BBCodeUtils.cs
@@ -108,7 +108,7 @@ public static void applyStyleToTextbox(BBCodeStyle style, RichTextBox tf, int se
             else if (style.fontSize < 0)
                 fontSize += (float)style.fontSize;
 
-            if (style.fontName != null && style.fontName.Length > 0)
+            if (!string.IsNullOrEmpty(style.fontName))
                 fontName = style.fontName;
 
 
diff --git a/PluginCore/PluginCore/Controls/CompletionList.cs b/PluginCore/PluginCore/Controls/CompletionList.cs
@@ -256,7 +256,7 @@ static private void DisplayList(Object sender, System.Timers.ElapsedEventArgs e)
             if (cl.Items.Count == 0) return;
 
             // measure control
-            if (needResize && widestLabel != null && widestLabel.Length > 0)
+            if (needResize && !string.IsNullOrEmpty(widestLabel))
             {
                 needResize = false;
                 Graphics g = cl.CreateGraphics();
diff --git a/PluginCore/ScintillaNet/Configuration/CharacterClass.cs b/PluginCore/ScintillaNet/Configuration/CharacterClass.cs
@@ -20,7 +20,7 @@ public string Characters
             get
             {
                 string result = val;
-                if (inherit != null && inherit.Length > 0)
+                if (!string.IsNullOrEmpty(inherit))
                 {
                     CharacterClass cc = _parent.MasterScintilla.GetCharacterClass(inherit);         
                     if (cc != null) result += cc.Characters;
diff --git a/PluginCore/ScintillaNet/Configuration/EditorStyle.cs b/PluginCore/ScintillaNet/Configuration/EditorStyle.cs
diff --git a/PluginCore/ScintillaNet/RTF.cs b/PluginCore/ScintillaNet/RTF.cs
diff --git a/PluginCore/SharpZipLib/Core/NameFilter.cs b/PluginCore/SharpZipLib/Core/NameFilter.cs
diff --git a/PluginCore/SharpZipLib/Core/WindowsPathUtils.cs b/PluginCore/SharpZipLib/Core/WindowsPathUtils.cs
diff --git a/PluginCore/SharpZipLib/Tar/TarArchive.cs b/PluginCore/SharpZipLib/Tar/TarArchive.cs
diff --git a/PluginCore/SharpZipLib/Zip/FastZip.cs b/PluginCore/SharpZipLib/Zip/FastZip.cs

Original file line number	Diff line number	Diff line change
`@@ -1868,7 +1868,7 @@ static private bool HandleDotCompletion(ScintillaControl Sci, bool autoHide)`
`1868`	`1868`	`int line = Sci.LineFromPosition(position);`
`1869`	`1869`	`if (cMember == null && !ASContext.Context.CurrentClass.IsVoid())`
`1870`	`1870`	`{`
`1871`		`- if (expr.Value != null && expr.Value.Length > 0)`
	`1871`	`+ if (!string.IsNullOrEmpty(expr.Value))`
`1872`	`1872`	`return HandleDeclarationCompletion(Sci, expr.Value, autoHide);`
`1873`	`1873`	`else if (ASContext.Context.CurrentModel.Version >= 2)`
`1874`	`1874`	`return ASGenerator.HandleGeneratorCompletion(Sci, autoHide, features.overrideKey);`
`@@ -3613,7 +3613,7 @@ private static ComaExpression DisambiguateComa(ScintillaControl Sci, int positio`
`3613`	`3613`	`static public MemberList ParseLocalVars(ASExpr expression)`
`3614`	`3614`	`{`
`3615`	`3615`	`FileModel model;`
`3616`		`- if (expression.FunctionBody != null && expression.FunctionBody.Length > 0)`
	`3616`	`+ if (!string.IsNullOrEmpty(expression.FunctionBody))`
`3617`	`3617`	`{`
`3618`	`3618`	`MemberModel cm = expression.ContextMember;`
`3619`	`3619`	`string functionBody = Regex.Replace(expression.FunctionBody, "function\\s*\\(", "function __anonfunc__("); // name anonymous functions`
Original file line number	Diff line number	Diff line change
`@@ -430,7 +430,7 @@ static public string GetTipShortDetails(CommentBlock cb, string highlightParam)`
`430`	`430`	`string details = "";`
`431`	`431`
`432`	`432`	`// get parameter detail`
`433`		`- if (highlightParam != null && highlightParam.Length > 0 && cb.ParamName != null)`
	`433`	`+ if (!string.IsNullOrEmpty(highlightParam) && cb.ParamName != null)`
`434`	`434`	`{`
`435`	`435`	`for(int i=0; i<cb.ParamName.Count; i++)`
`436`	`436`	`{`
`@@ -445,9 +445,9 @@ static public string GetTipShortDetails(CommentBlock cb, string highlightParam)`
`445`	`445`	`// get description extract`
`446`	`446`	`if (ASContext.CommonSettings.SmartTipsEnabled)`
`447`	`447`	`{`
`448`		`- if (cb.InfoTip != null && cb.InfoTip.Length > 0)`
	`448`	`+ if (!string.IsNullOrEmpty(cb.InfoTip))`
`449`	`449`	`details += "\n"+cb.InfoTip;`
`450`		`- else if (cb.Description != null && cb.Description.Length > 0)`
	`450`	`+ else if (!string.IsNullOrEmpty(cb.Description))`
`451`	`451`	`details += Get2LinesOf(cb.Description, cb.IsFunctionWithArguments);`
`452`	`452`	`}`
`453`	`453`
Original file line number	Diff line number	Diff line change
`@@ -2166,7 +2166,7 @@ private static int GetContextOwnerEndPos(ScintillaControl Sci, int worsStartPos)`
`2166`	`2166`
`2167`	`2167`	`static public string Capitalize(string name)`
`2168`	`2168`	`{`
`2169`		`- return name != null && name.Length > 0 ? Char.ToUpper(name[0]) + name.Substring(1) : name;`
	`2169`	`+ return !string.IsNullOrEmpty(name) ? Char.ToUpper(name[0]) + name.Substring(1) : name;`
`2170`	`2170`	`}`
`2171`	`2171`
`2172`	`2172`	`static public string Camelize(string name)`
`@@ -3098,7 +3098,7 @@ private static string GuessVarName(string name, string type)`
`3098`	`3098`
`3099`	`3099`	`if (name == "this" \|\| type == name)`
`3100`	`3100`	`{`
`3101`		`- if (type != null && type.Length > 0)`
	`3101`	`+ if (!string.IsNullOrEmpty(type))`
`3102`	`3102`	`name = Char.ToLower(type[0]) + type.Substring(1);`
`3103`	`3103`	`else`
`3104`	`3104`	`name = "p_this";`
Original file line number	Diff line number	Diff line change
`@@ -432,7 +432,7 @@ private void updateTimer_Tick(object sender, EventArgs e)`
`432`	`432`
`433`	`433`	`private void FindPrevMatch(string search)`
`434`	`434`	`{`
`435`		`- if (search != null && allTypes != null && search.Length > 0)`
	`435`	`+ if (!string.IsNullOrEmpty(search) && allTypes != null)`
`436`	`436`	`{`
`437`	`437`	`typeIndex--;`
`438`	`438`	`if (typeIndex <= 0) typeIndex = allTypes.Count;`
`@@ -452,7 +452,7 @@ private void FindPrevMatch(string search)`
`452`	`452`
`453`	`453`	`private void FindNextMatch(string search)`
`454`	`454`	`{`
`455`		`- if (search != null && allTypes != null && search.Length > 0)`
	`455`	`+ if (!string.IsNullOrEmpty(search) && allTypes != null)`
`456`	`456`	`{`
`457`	`457`	`while (typeIndex < allTypes.Count)`
`458`	`458`	`{`
Original file line number	Diff line number	Diff line change
`@@ -244,7 +244,7 @@ private static MemberModel extractTypedCallbackModel(string comment)`
`244`	`244`	`for (i = 0; i < l; i++)`
`245`	`245`	`{`
`246`	`246`	`string pName = pMatches[i].Groups["pName"].Value;`
`247`		`- if (pName != null && pName.Length > 0)`
	`247`	`+ if (!string.IsNullOrEmpty(pName))`
`248`	`248`	`{`
`249`	`249`	`foreach (KeyValuePair<String,String> replEntry in qStrRepls)`
`250`	`250`	`{`
`@@ -257,7 +257,7 @@ private static MemberModel extractTypedCallbackModel(string comment)`
`257`	`257`	`}`
`258`	`258`
`259`	`259`	`string pType = pMatches[i].Groups["pType"].Value;`
`260`		`- if (pType != null && pType.Length > 0)`
	`260`	`+ if (!string.IsNullOrEmpty(pType))`
`261`	`261`	`{`
`262`	`262`	`foreach (KeyValuePair<String,String> replEntry in qStrRepls)`
`263`	`263`	`{`
`@@ -270,7 +270,7 @@ private static MemberModel extractTypedCallbackModel(string comment)`
`270`	`270`	`}`
`271`	`271`
`272`	`272`	`string pVal = pMatches[i].Groups["pVal"].Value;`
`273`		`- if (pVal != null && pVal.Length > 0)`
	`273`	`+ if (!string.IsNullOrEmpty(pVal))`
`274`	`274`	`{`
`275`	`275`	`if (qStrRepls.ContainsKey(pVal))`
`276`	`276`	`{`
Original file line number	Diff line number	Diff line change
`@@ -448,7 +448,7 @@ static public string ClassDeclaration(ClassModel ofClass, bool qualified)`
`448`	`448`	`else modifiers += "intrinsic ";`
`449`	`449`	`}`
`450`	`450`	`else if (ofClass.InFile.Version > 2)`
`451`		`- if (ofClass.Namespace != null && ofClass.Namespace.Length > 0`
	`451`	`+ if (!string.IsNullOrEmpty(ofClass.Namespace)`
`452`	`452`	`&& ofClass.Namespace != "internal")`
`453`	`453`	`{`
`454`	`454`	`// if ((ft & FlagType.Interface) == 0)`
`@@ -502,7 +502,7 @@ static public string MemberDeclaration(MemberModel member, bool preventVisibilit`
`502`	`502`	`if ((ft & FlagType.Extern) > 0) modifiers += "extern ";`
`503`	`503`	`else modifiers += "intrinsic ";`
`504`	`504`	`}`
`505`		`- else if (member.Namespace != null && member.Namespace.Length > 0`
	`505`	`+ else if (!string.IsNullOrEmpty(member.Namespace)`
`506`	`506`	`&& member.Namespace != "internal")`
`507`	`507`	`{`
`508`	`508`	`if ((ft & FlagType.Interface) == 0)`
Original file line number	Diff line number	Diff line change
`@@ -140,7 +140,7 @@ public string ToDeclarationString(bool wrapWithSpaces, bool concatValue)`
`140`	`140`	`if (Parameters != null && Parameters.Count > 0)`
`141`	`141`	`{`
`142`	`142`	`comment = "/*(" + ParametersString(true) + ")";`
`143`		`- if (Type != null && Type.Length > 0)`
	`143`	`+ if (!string.IsNullOrEmpty(Type))`
`144`	`144`	`comment += colon + FormatType(Type);`
`145`	`145`	`comment += "*/";`
`146`	`146`	`}`
`@@ -151,12 +151,12 @@ public string ToDeclarationString(bool wrapWithSpaces, bool concatValue)`
`151`	`151`	`}`
`152`	`152`	`}`
`153`	`153`
`154`		`- if ((type == null \|\| type.Length == 0) && (Type != null && Type.Length > 0))`
	`154`	`+ if (string.IsNullOrEmpty(type) && !string.IsNullOrEmpty(Type))`
`155`	`155`	`type = FormatType(Type);`
`156`	`156`
`157`	`157`	`if ((Flags & FlagType.Constructor) > 0)`
`158`	`158`	`return res;`
`159`		`- else if (type != null && type.Length > 0)`
	`159`	`+ else if (!string.IsNullOrEmpty(type))`
`160`	`160`	`res += colon + type;`
`161`	`161`
`162`	`162`	`res += comment;`
Original file line number	Diff line number	Diff line change
`@@ -741,7 +741,7 @@ private void AddExtend(TreeNodeCollection tree, ClassModel aClass)`
`741`	`741`	`//if ((aClass.Flags & FlagType.TypeDef) > 0 && aClass.Members.Count == 0)`
`742`	`742`	`// folder.Text = "Defines"; // TODO need a better word I guess`
`743`	`743`
`744`		`- while (aClass.ExtendsType != null && aClass.ExtendsType.Length > 0`
	`744`	`+ while (!string.IsNullOrEmpty(aClass.ExtendsType)`
`745`	`745`	`&& aClass.ExtendsType != "Object"`
`746`	`746`	`&& (!aClass.InFile.haXe \|\| aClass.ExtendsType != "Dynamic"))`
`747`	`747`	`{`