Merge pull request #957 from SlavaRa/feature/refactor_Type_cast_is_redundant

[Code cleanup] Fixes redundant Type cast

Author: elsassph

External/Plugins/AS3Context/Compiler/FlexDebugger.cs

@@ -54,7 +54,7 @@ static void debugger_OnStarted(string line)
         {
             if (startMessage == null) 
                 return;
-            PluginBase.RunAsync((MethodInvoker)delegate
+            PluginBase.RunAsync(delegate
             {
                 // send message again
                 ignoreMessage = true;

External/Plugins/AS3Context/Compiler/FlexShells.cs

@@ -508,7 +508,7 @@ private void ascRunner_Error(object sender, string line)
         private void ascRunner_OutputError(object sender, string line)
         {
             if (line == null) return;
-            PluginBase.RunAsync((MethodInvoker)delegate
+            PluginBase.RunAsync(delegate
             {
                 if (line.StartsWith("Exception "))
                 {
@@ -563,7 +563,7 @@ private void mxmlcRunner_Error(object sender, string line)
 
         private void mxmlcRunner_Output(object sender, string line)
         {
-            PluginBase.RunAsync((MethodInvoker)delegate
+            PluginBase.RunAsync(delegate
             {
                 if (!notificationSent && line.StartsWith("Done("))
                 {

External/Plugins/AS3Context/PluginMain.cs

@@ -99,7 +99,7 @@ Object IPlugin.Settings
 
         static public AS3Settings Settings
         {
-            get { return settingObject as AS3Settings; }
+            get { return settingObject; }
         }
         #endregion
 
@@ -156,13 +156,13 @@ public void HandleEvent(Object sender, NotifyEvent e, HandlingPriority priority)
                             if (PluginBase.CurrentProject != null && PluginBase.CurrentProject.Language == "as3")
                                 e.Handled = OpenVirtualFileModel(de.Data as String);
                         }
-                        else if (!(settingObject as AS3Settings).DisableFDB && action == "AS3Context.StartDebugger")
+                        else if (!settingObject.DisableFDB && action == "AS3Context.StartDebugger")
                         {
                             string workDir = (PluginBase.CurrentProject != null)
                                 ? Path.GetDirectoryName(PluginBase.CurrentProject.ProjectPath)
                                 : Environment.CurrentDirectory;
 
-                            string flexSdk = (settingObject as AS3Settings).GetDefaultSDK().Path;
+                            string flexSdk = settingObject.GetDefaultSDK().Path;
 
                             // if the default sdk is not defined ask for project sdk
                             if (String.IsNullOrEmpty(flexSdk))

External/Plugins/ASCompletion/Context/ASContext.cs

@@ -691,7 +691,7 @@ public virtual bool SetTemporaryPath(string path)
                 return false;
             if (temporaryPath != null)
             {
-                while (classPath.Count > 0 && (classPath[0] as PathModel).IsTemporaryPath)
+                while (classPath.Count > 0 && classPath[0].IsTemporaryPath)
                 {
                     classPath[0].InUse = false;
                     classPath.RemoveAt(0);

External/Plugins/ASCompletion/Model/ClassModel.cs

@@ -306,7 +306,7 @@ public string GenerateIntrinsic(bool caching)
             char semi = ';';
             string tab0 = (!caching && InFile.Version == 3) ? "\t" : "";
             string tab = (caching) ? "" : ((InFile.Version == 3) ? "\t\t" : "\t");
-            bool preventVis = (bool)((this.Flags & FlagType.Interface) > 0);
+            bool preventVis = (this.Flags & FlagType.Interface) > 0;
 
             // SPECIAL DELEGATE
             /*if ((Flags & FlagType.Delegate) > 0)

External/Plugins/ASCompletion/Model/PathExplorer.cs

@@ -284,7 +284,7 @@ private bool ParseFoundFiles()
             {
                 if (stopExploration) return writeCache;
                 // parse
-                filename = foundFiles[i] as string;
+                filename = foundFiles[i];
                 if (!File.Exists(filename))
                     continue;
                 if (pathModel.HasFile(filename))

External/Plugins/ASCompletion/Model/PathModel.cs

@@ -68,7 +68,7 @@ static public PathModel GetModel(string path, IASContext context)
             PathModel aPath;
             if (pathes.ContainsKey(modelName))
             {
-                aPath = pathes[modelName] as PathModel;
+                aPath = pathes[modelName];
                 if (aPath.IsTemporaryPath || !aPath.IsValid || aPath.FilesCount == 0)
                 {
                     pathes[modelName] = aPath = new PathModel(path, context);

External/Plugins/AirProperties/Forms/AirWizard.cs

@@ -432,7 +432,7 @@ private String GetSelectedLocale()
 
         private Boolean GetSelectedLocaleIsDefault()
         {
-            return (Boolean)(LocalesField.SelectedIndex == 0);
+            return LocalesField.SelectedIndex == 0;
         }
 
         public void SetTitle(string projectName, string airVersion)
@@ -1473,8 +1473,8 @@ private void LocaleManagerButton_Click(object sender, EventArgs e)
                     {
                         //create the affected properties now, even though value is empty, so the locale 
                         //will be preserved if the user closes the form without specifying a value
-                        PropertyManager.CreateLocalizedProperty("name", locale, (Boolean)_locales[0].Equals(locale));
-                        PropertyManager.CreateLocalizedProperty("description", locale, (Boolean)_locales[0].Equals(locale));
+                        PropertyManager.CreateLocalizedProperty("name", locale, _locales[0].Equals(locale));
+                        PropertyManager.CreateLocalizedProperty("description", locale, _locales[0].Equals(locale));
                     }
                 }
                 //Re-initialize locales and refresh affected property fields

External/Plugins/CodeFormatter/Handlers/MXMLLexer.cs

@@ -50,13 +50,13 @@ public class MXMLLexer : Lexer {
        int lastCharPos=0;
        public void AddToken( CommonToken t, int type, int channel)
        {
-          ((CommonToken)t).Type = type;
-          ((CommonToken)t).Channel = channel;
+          t.Type = type;
+          t.Channel = channel;
           t.Line = lastLine;
           lastLine=input.Line;
           t.CharPositionInLine = lastCharPos;
           lastCharPos=input.CharPositionInLine;
-          mRawTokens.Add((CommonToken)t);
+          mRawTokens.Add(t);
        }
        public List<CommonToken> GetTokens()
        {

External/Plugins/CodeFormatter/PluginMain.cs

@@ -166,7 +166,7 @@ public void InitBasics()
         private void UpdateMenuItems()
         {
             if (this.mainMenuItem == null || this.contextMenuItem == null) return;
-            ITabbedDocument doc = PluginBase.MainForm.CurrentDocument as ITabbedDocument;
+            ITabbedDocument doc = PluginBase.MainForm.CurrentDocument;
             Boolean isValid = doc != null && doc.IsEditable && this.IsSupportedLanguage(doc.FileName);
             this.mainMenuItem.Enabled = this.contextMenuItem.Enabled = isValid;
         }