Skip to content

Commit d246c23

Browse files
author
SlavaRa
committed
Small refactoring
1 parent 5deda18 commit d246c23

File tree

2 files changed

+10
-9
lines changed

2 files changed

+10
-9
lines changed

External/Plugins/CodeRefactor/Commands/Rename.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -364,10 +364,10 @@ private String GetNewName(String originalName)
364364
String label = TextHelper.GetString("Label.NewName");
365365
String title = String.Format(TextHelper.GetString("Title.RenameDialog"), originalName);
366366
LineEntryDialog askName = new LineEntryDialog(title, label, originalName);
367-
DialogResult choice = askName.ShowDialog();
368-
if (choice == DialogResult.OK && askName.Line.Trim().Length > 0 && askName.Line.Trim() != originalName)
367+
if (askName.ShowDialog() == DialogResult.OK)
369368
{
370-
return askName.Line.Trim();
369+
string newName = askName.Line.Trim();
370+
if(newName.Length > 0 && newName != originalName) return newName;
371371
}
372372
return null;
373373
}

External/Plugins/CodeRefactor/Provider/RenamingHelper.cs

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,20 +24,21 @@ public static void AddToQueue(ASResult target)
2424
}
2525
public static void AddToQueue(ASResult target, bool outputResults)
2626
{
27-
string name = RefactoringHelper.GetRefactorTargetName(target);
27+
string originalName = RefactoringHelper.GetRefactorTargetName(target);
2828
string label = TextHelper.GetString("Label.NewName");
29-
string title = string.Format(TextHelper.GetString("Title.RenameDialog"), name);
30-
LineEntryDialog askName = new LineEntryDialog(title, label, name);
31-
if (askName.ShowDialog() == DialogResult.OK && askName.Line.Trim().Length > 0 && askName.Line.Trim() != name)
29+
string title = string.Format(TextHelper.GetString("Title.RenameDialog"), originalName);
30+
LineEntryDialog askName = new LineEntryDialog(title, label, originalName);
31+
if (askName.ShowDialog() == DialogResult.OK)
3232
{
3333
string newName = askName.Line.Trim();
34+
if (newName.Length == 0 || newName == originalName) return;
3435
queue.Add(new Rename(target, outputResults, newName));
3536
if (ASContext.Context.CurrentModel.haXe && target.Member != null &&
3637
(target.Member.Flags & (FlagType.Getter | FlagType.Setter)) > 0)
3738
{
3839
List<MemberModel> list = target.Member.Parameters;
39-
if (list[0].Name == "get") RenameMember(target.InClass, "get_" + name, "get_" + newName, outputResults);
40-
if (list[1].Name == "set") RenameMember(target.InClass, "set_" + name, "set_" + newName, outputResults);
40+
if (list[0].Name == "get") RenameMember(target.InClass, "get_" + originalName, "get_" + newName, outputResults);
41+
if (list[1].Name == "set") RenameMember(target.InClass, "set_" + originalName, "set_" + newName, outputResults);
4142
}
4243
if (currentCommand == null) ExecuteFirst();
4344
}

0 commit comments

Comments
 (0)