Fix TextTreeParser GetNode bounds

fdwr · fdwr · commit 42d2d60ea5c3 · 2024-09-03T23:44:54.000-07:00
diff --git a/source/TextTreeParser.ixx b/source/TextTreeParser.ixx
@@ -337,7 +337,7 @@ TextTree::Node::Type TextTree::Node::GetGenericType() const noexcept
 TextTree::Node& TextTree::GetNode(uint32_t nodeIndex)
 {
     assert(nodeIndex < nodes_.size());
-    if (nodeIndex > nodes_.size())
+    if (nodeIndex >= nodes_.size())
     {
         return *static_cast<Node*>(nullptr); // Force AV.
     }
@@ -348,7 +348,7 @@ TextTree::Node& TextTree::GetNode(uint32_t nodeIndex)
 const TextTree::Node& TextTree::GetNode(uint32_t nodeIndex) const
 {
     assert(nodeIndex < nodes_.size());
-    if (nodeIndex > nodes_.size())
+    if (nodeIndex >= nodes_.size())
     {
         return *static_cast<Node*>(nullptr); // Force AV.
     }

Original file line number	Diff line number	Diff line change
`@@ -337,7 +337,7 @@ TextTree::Node::Type TextTree::Node::GetGenericType() const noexcept`
`337`	`337`	`TextTree::Node& TextTree::GetNode(uint32_t nodeIndex)`
`338`	`338`	`{`
`339`	`339`	`assert(nodeIndex < nodes_.size());`
`340`		`- if (nodeIndex > nodes_.size())`
	`340`	`+ if (nodeIndex >= nodes_.size())`
`341`	`341`	`{`
`342`	`342`	`return static_cast<Node>(nullptr); // Force AV.`
`343`	`343`	`}`
`@@ -348,7 +348,7 @@ TextTree::Node& TextTree::GetNode(uint32_t nodeIndex)`
`348`	`348`	`const TextTree::Node& TextTree::GetNode(uint32_t nodeIndex) const`
`349`	`349`	`{`
`350`	`350`	`assert(nodeIndex < nodes_.size());`
`351`		`- if (nodeIndex > nodes_.size())`
	`351`	`+ if (nodeIndex >= nodes_.size())`
`352`	`352`	`{`
`353`	`353`	`return static_cast<Node>(nullptr); // Force AV.`
`354`	`354`	`}`