Add support for sdk-maintainer-approved in pullapprove, update docs (project-chip#40195)

* Add pullapprove rules for SDK maintainers

* Move doc lins to top of the page, for simplified reading

* Re-organize documentation to group contributing together

* Add PR reviews bits

* Restyle, some wording updates

* Update docs/contributing/index.md

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* Add new works and resort word file

* Fix links

---------

Co-authored-by: Andrei Litvin <andreilitvin@google.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

Author: 3 people

.github/.wordlist.txt

@@ -274,8 +274,8 @@ codelabs
 ColorControl
 Combinators
 Comcast
-Commandline
 CommandHandlerInterface
+Commandline
 CommandName
 Commissionable
 CommissionableDataProvider
@@ -303,8 +303,8 @@ connstring
 conntype
 const
 ContentApp
-ContentApp's
 ContentAppPlatform
+ContentApp's
 ContentLaunch
 ContentLauncher
 contrib
@@ -472,8 +472,8 @@ DS
 DSLS
 duplicative
 DUT
-DUTS
 DUT's
+DUTS
 DV
 DVK
 dynload
@@ -533,10 +533,10 @@ EthernetNetworkDiagnostics
 ethernets
 EthyleneConcentrationMeasurement
 EthyleneOxideConcentrationMeasurement
+EV
 EvalCode
 EvalCodeWithName
 EvalFrameDefault
-EV
 EVB
 EventLogging
 evk
@@ -571,9 +571,9 @@ feff
 ffaa
 ffeebaefa
 FFF
-FFFFFFFFFFFF0102
 fffe
 fffff
+FFFFFFFFFFFF0102
 FFmpeg
 Fi
 filepath
@@ -618,13 +618,13 @@ GenericWiFiConfigurationManagerImpl
 GetDeviceId
 GetDeviceInfo
 GetDns
-getter
-getters
 GetInDevelopmentTests
 GetIP
 getManualTests
 GetSafeAttributePersistenceProvider
 getstarted
+getter
+getters
 GH
 ghcr
 ghp
@@ -677,9 +677,10 @@ HomePod
 HomePods
 hostapd
 hostname
+hotfixes
 href
-HSM
 hsm
+HSM
 HTTPS
 Humidistat
 HW
@@ -760,14 +761,14 @@ itemName
 iterable
 itsfoss
 IW
+JCM
 JDK
+jf
 jinja
-JCM
 JLink
 JLinkExe
 JLinkRTTClient
 JN
-jf
 jni
 jpg
 jre
@@ -838,6 +839,8 @@ LightingApp
 LightingColor
 LightingState
 LinkSoftwareAndDocumentationPack
+linter
+linters
 lladdr
 LocalConfigDisabled
 localedef
@@ -1235,8 +1238,8 @@ repo
 repos
 req
 Requestor
-Requestor's
 RequestorCanConsent
+Requestor's
 Requestors
 responder
 RestrictedEvent
@@ -1271,8 +1274,8 @@ RTOS
 RTT
 RTX
 runArgs
-runIf
 RUNAS
+runIf
 RunMain
 runtime
 RVC
@@ -1294,8 +1297,8 @@ SDB
 SDC
 SDHC
 SDK
-SDK's
 sdkconfig
+SDK's
 SDKs
 SDKTARGETSYSROOT
 sdl
@@ -1422,6 +1425,7 @@ sysv
 TargetNavigator
 TBD
 tbody
+TBR
 tcl
 TCP
 teardown
@@ -1498,8 +1502,8 @@ triaged
 triaging
 TriggerEffect
 TRNG
-trustm
 TrustedRootCertificates
+trustm
 tsan
 TSG
 tsv
@@ -1531,6 +1535,7 @@ Ultrafast
 UNBLUR
 uncommissioned
 Unencrypted
+unfixable
 unfocus
 Unicast
 UniFlash
@@ -1564,8 +1569,8 @@ util
 utils
 UUID
 ux
-validator
 valgrind
+validator
 vcom
 VCP
 Vectorcall
@@ -1678,4 +1683,3 @@ Zigbee
 zigbeealliance
 zigbeethread
 zsdk
-TBR

.github/PULL_REQUEST_TEMPLATE.md

@@ -6,8 +6,8 @@
     If fixing an error, explain the root cause and the chosen solution's rationale, especially if not obvious.
     Include context like links to related documents/issues/test plans and highlight notable information or specific concerns.
 
-    See guidelines: https://project-chip.github.io/connectedhomeip-doc/pull_request_guidelines.html#pr-summary-description
-    See title formatting: https://project-chip.github.io/connectedhomeip-doc/pull_request_guidelines.html#title-formatting
+    See guidelines: https://project-chip.github.io/connectedhomeip-doc/contributing/pull_request_guidelines.html#pr-summary-description
+    See title formatting: https://project-chip.github.io/connectedhomeip-doc/contributing/pull_request_guidelines.html#title-formatting
 
     Please replace this HTML comment with the actual PR summary.
 -->
@@ -35,7 +35,7 @@
     As a general rule, a proposed PR change must not break the existing code and must be well-tested.
     Please include information about testing.
 
-    See testing guidelines: https://project-chip.github.io/connectedhomeip-doc/pull_request_guidelines.html#testing
+    See testing guidelines: https://project-chip.github.io/connectedhomeip-doc/contributing/pull_request_guidelines.html#testing
 
     Examples:
         added unit tests
@@ -52,12 +52,12 @@ The checklist below will help the reviewer finish PR review in time and keep the
 code readable:
 
 -   [ ] PR title is
-        [descriptive](https://project-chip.github.io/connectedhomeip-doc/pull_request_guidelines.html#title-formatting)
+        [descriptive](https://project-chip.github.io/connectedhomeip-doc/contributing/pull_request_guidelines.html#title-formatting)
 -   [ ] Apply the
         [_“When in Rome…”_](https://project-chip.github.io/connectedhomeip-doc/style/CODING_STYLE_GUIDE.html)
         rule (coding style)
 -   [ ] PR size is short
 -   [ ] Try to avoid "squashing" and "force-update" in commit history
 -   [ ] CI time didn't increase
 
-See: [Pull Request Guidelines](https://project-chip.github.io/connectedhomeip-doc/pull_request_guidelines.html)
+See: [Pull Request Guidelines](https://project-chip.github.io/connectedhomeip-doc/contributing/pull_request_guidelines.html)

.pullapprove.yml

@@ -48,6 +48,13 @@ overrides:
     status: success
     explanation: "PR has been fast tracked, bypassing reviews"
 
+  ############################################################
+  #  Approved by matter-sdk-maintainers
+  ############################################################
+  - if: "'sdk-maintainers-approved' in labels and len(groups.approved.include('sdk-maintainers')) >= 1"
+    status: success
+    explanation: "Approved by SDK maintainer and label is set."
+
 ############################################################
 #  Notifications
 ############################################################
@@ -253,6 +260,15 @@ groups:
     reviews:
       request: 0 # Do not auto-add
 
+  sdk-maintainers:
+    type: optional
+    conditions:
+      - files.include('*')
+    reviewers:
+      teams: [matter-sdk-maintainers]
+    reviews:
+      request: 0 # Do not auto-add
+
   ############################################################
   #  Folder specific review requirements. A PR must meet all
   #  folder specific review requirements for all folders that

CONTRIBUTING.md

@@ -166,7 +166,7 @@ Aim to make pull requests easy to read both when viewed in a list (title only)
 as well as clear in content within the description.
 
 Pull request guidelines described in detail
-[here](./docs/pull_request_guidelines.md)
+[here](./docs/contributing/pull_request_guidelines.md)
 
 ### Review Requirements
 

README.md

@@ -1,3 +1,9 @@
+# Documentation links
+
+-   [![Ask DeepWiki](https://deepwiki.com/badge.svg)](https://deepwiki.com/project-chip/connectedhomeip)
+-   [Matter SDK documentation page](https://project-chip.github.io/connectedhomeip-doc/index.html)
+-   [Matter SDK Coverage Report](https://matter-build-automation.ue.r.appspot.com/)
+
 # Matter
 
 [![Builds](https://github.com/project-chip/connectedhomeip/workflows/Builds/badge.svg)](https://github.com/project-chip/connectedhomeip/actions/workflows/build.yaml)
@@ -34,18 +40,13 @@
 [![Cirque](https://github.com/project-chip/connectedhomeip/workflows/Cirque/badge.svg)](https://github.com/project-chip/connectedhomeip/actions/workflows/cirque.yaml)
 [![QEMU](https://github.com/project-chip/connectedhomeip/workflows/QEMU/badge.svg)](https://github.com/project-chip/connectedhomeip/actions/workflows/qemu.yaml)
 
--   [Matter SDK Coverage Report](https://matter-build-automation.ue.r.appspot.com/)
-
 **Tools**
 
 [![ZAP Templates](https://github.com/project-chip/connectedhomeip/workflows/ZAP/badge.svg)](https://github.com/project-chip/connectedhomeip/actions/workflows/zap_templates.yaml)
 
 **Documentation**
 
 [![Documentation Build](https://github.com/project-chip/connectedhomeip/actions/workflows/docbuild.yaml/badge.svg)](https://github.com/project-chip/connectedhomeip/actions/workflows/docbuild.yaml)
-[![Ask DeepWiki](https://deepwiki.com/badge.svg)](https://deepwiki.com/project-chip/connectedhomeip)
-
--   [Matter SDK documentation page](https://project-chip.github.io/connectedhomeip-doc/index.html)
 
 # About
 

docs/PROJECT_FLOW.md

@@ -28,7 +28,7 @@ base. They should be easy to review, as a "yes, that's better". Refrain from
 requesting review until all PR checks have completed successfully, lest you tire
 your reviewers.
 
-See a guideline [here](./pull_request_guidelines.md)
+See a guideline [here](./contributing/pull_request_guidelines.md)
 
 ### Milestones
 

docs/BUG_REPORT.md docs/contributing/BUG_REPORT.mddocs/BUG_REPORT.md renamed to docs/contributing/BUG_REPORT.md

@@ -0,0 +1,17 @@
+# Contributing to matter
+
+The following docs present information about contributing to matter: how to
+create quality bug reports, how to organize pull requests and how pull requests
+are reviewed.
+
+```{toctree}
+:glob:
+:maxdepth: 1
+:hidden:
+
+*
+
+```
+
+-   [Reporting bugs](./BUG_REPORT.md)
+-   [Pull request guidelines](./pull_request_guidelines.md)