FeatureView - unexpected keyword argument 'features'

[oonisim]

Environment

FEAST 0.51
Python 3.11
MacOS (Apple Silicon)

Issue

credit_history = FeatureView(
    name="credit_history",
    entities=["dob_ssn"],
    ttl=timedelta(days=90),
    features=[        # <--- No more such argument
        Feature(name="credit_card_due", dtype=ValueType.INT64),
        Feature(name="mortgage_due", dtype=ValueType.INT64),
        Feature(name="student_loan_due", dtype=ValueType.INT64),
        Feature(name="vehicle_loan_due", dtype=ValueType.INT64),
        Feature(name="hard_pulls", dtype=ValueType.INT64),
        Feature(name="missed_payments_2y", dtype=ValueType.INT64),
        Feature(name="missed_payments_1y", dtype=ValueType.INT64),
        Feature(name="missed_payments_6m", dtype=ValueType.INT64),
        Feature(name="bankruptcies", dtype=ValueType.INT64),
    ],
    batch_source=credit_history_source,
)

$ feast apply
Traceback (most recent call last):
  File "/Users/onishima/venv/feast/bin/feast", line 8, in <module>
    sys.exit(cli())
             ^^^^^
  File "/Users/onishima/venv/feast/lib/python3.11/site-packages/click/core.py", line 1442, in __call__
    return self.main(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/onishima/venv/feast/lib/python3.11/site-packages/click/core.py", line 1363, in main
    rv = self.invoke(ctx)
         ^^^^^^^^^^^^^^^^
  File "/Users/onishima/venv/feast/lib/python3.11/site-packages/click/core.py", line 1830, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/onishima/venv/feast/lib/python3.11/site-packages/click/core.py", line 1226, in invoke
    return ctx.invoke(self.callback, **ctx.params)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/onishima/venv/feast/lib/python3.11/site-packages/click/core.py", line 794, in invoke
    return callback(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/onishima/venv/feast/lib/python3.11/site-packages/click/decorators.py", line 34, in new_func
    return f(get_current_context(), *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/onishima/venv/feast/lib/python3.11/site-packages/feast/cli/cli.py", line 272, in apply_total_command
    apply_total(repo_config, repo, skip_source_validation)
  File "/Users/onishima/venv/feast/lib/python3.11/site-packages/feast/repo_operations.py", line 392, in apply_total
    repo = _get_repo_contents(repo_path, repo_config.project)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/onishima/venv/feast/lib/python3.11/site-packages/feast/repo_operations.py", line 244, in _get_repo_contents
    repo = parse_repo(repo_path)
           ^^^^^^^^^^^^^^^^^^^^^
  File "/Users/onishima/venv/feast/lib/python3.11/site-packages/feast/repo_operations.py", line 135, in parse_repo
    module = importlib.import_module(module_path)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/python@3.11/3.11.13/Frameworks/Python.framework/Versions/3.11/lib/python3.11/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen importlib._bootstrap>", line 1204, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1176, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1147, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 690, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 940, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "/Users/onishima/Documents/home/repository/git/FEAST/feast-aws-credit-scoring-tutorial/feature_repo/features.py", line 20, in <module>
    zipcode_features = FeatureView(
                       ^^^^^^^^^^^^
TypeError: FeatureView.__init__() got an unexpected keyword argument 'features'

[oonisim]

Fix

from datetime import timedelta
from feast import (
    Entity,
    FeatureService,
    FeatureView,
    Field,
    RedshiftSource,
)
from feast.value_type import (
    ValueType
)
from feast.types import (
    String,
    Int64
)

zipcode = Entity(name="zipcode", value_type=ValueType.INT64)

zipcode_source = RedshiftSource(
    # API changed
    # Unable to infer a name for this data source. Either table or name must be specified
    # https://github.com/feast-dev/feast-aws-credit-scoring-tutorial/issues/8
    name="zipcode_features",
    database="dev",
    query="SELECT * FROM spectrum.zipcode_features",
    # API changed
    # RedshiftSource.__init__() got an unexpected keyword argument 'event_timestamp_column'
    # event_timestamp_column="event_timestamp",
    timestamp_field="event_timestamp",
    created_timestamp_column="created_timestamp",
)

zipcode_features = FeatureView(
    name="zipcode_features",
    # entities=["zipcode"],
    entities=[zipcode],
    ttl=timedelta(days=3650),
    # features=[
        #Feature(name="city", dtype=ValueType.STRING),
        #Feature(name="state", dtype=ValueType.STRING),
        #Feature(name="location_type", dtype=ValueType.STRING),
        #Feature(name="tax_returns_filed", dtype=ValueType.INT64),
        #Feature(name="population", dtype=ValueType.INT64),
        #Feature(name="total_wages", dtype=ValueType.INT64),
    # ],
    schema=[
        Field(name="city", dtype=String),
        Field(name="state", dtype=String),
        Field(name="location_type", dtype=String),
        Field(name="tax_returns_filed", dtype=Int64),
        Field(name="population", dtype=Int64),
        Field(name="total_wages", dtype=Int64),
    ],
    # API Change
    # FeatureView.__init__() got an unexpected keyword argument 'batch_source'
    #batch_source=zipcode_source,
    source=zipcode_source,
)

dob_ssn = Entity(
    name="dob_ssn",
    value_type=ValueType.STRING,
    description="Date of birth and last four digits of social security number",
)

credit_history_source = RedshiftSource(
    # API changed
    # Unable to infer a name for this data source. Either table or name must be specified
    # https://github.com/feast-dev/feast-aws-credit-scoring-tutorial/issues/8
    name="credit_history",
    database="dev",
    query="SELECT * FROM spectrum.credit_history",
    # API changed
    # RedshiftSource.__init__() got an unexpected keyword argument 'event_timestamp_column'
    # event_timestamp_column="event_timestamp",
    timestamp_field="event_timestamp",
    created_timestamp_column="created_timestamp",
)

credit_history = FeatureView(
    name="credit_history",
    # entities=["dob_ssn"],
    entities=[dob_ssn],
    ttl=timedelta(days=90),
    # API Change
    # FeatureView.__init__() got an unexpected keyword argument 'features'
    # https://github.com/feast-dev/feast-aws-credit-scoring-tutorial/issues/9
    #features=[
        #Feature(name="credit_card_due", dtype=ValueType.INT64),
        #Feature(name="mortgage_due", dtype=ValueType.INT64),
        #Feature(name="student_loan_due", dtype=ValueType.INT64),
        #Feature(name="vehicle_loan_due", dtype=ValueType.INT64),
        #Feature(name="hard_pulls", dtype=ValueType.INT64),
        #Feature(name="missed_payments_2y", dtype=ValueType.INT64),
        #Feature(name="missed_payments_1y", dtype=ValueType.INT64),
        #Feature(name="missed_payments_6m", dtype=ValueType.INT64),
        #Feature(name="bankruptcies", dtype=ValueType.INT64),
    #],
    schema=[
        Field(name="credit_card_due", dtype=Int64),
        Field(name="mortgage_due", dtype=Int64),
        Field(name="student_loan_due", dtype=Int64),
        Field(name="vehicle_loan_due", dtype=Int64),
        Field(name="hard_pulls", dtype=Int64),
        Field(name="missed_payments_2y", dtype=Int64),
        Field(name="missed_payments_1y", dtype=Int64),
        Field(name="missed_payments_6m", dtype=Int64),
        Field(name="bankruptcies", dtype=Int64),
    ],
    # API Change
    # FeatureView.__init__() got an unexpected keyword argument 'batch_source'
    # batch_source=credit_history_source,
    source=credit_history_source
)

Result

$ feast apply
No project found in the repository. Using project name credit_scoring_aws defined in feature_store.yaml
Applying changes for project credit_scoring_aws
Deploying infrastructure for zipcode_features
Deploying infrastructure for credit_history

[oonisim]

Fixed for FEAST 0.51 feast-aws-credit-scoring-tutorial.tgz