Skip to content

Commit 002c075

Browse files
authored
chore: Fix publish, versions issue (#4946)
fix publish, versions issue Signed-off-by: Tommy Hughes <tohughes@redhat.com>
1 parent 2fd6d1a commit 002c075

File tree

4 files changed

+27
-39
lines changed

4 files changed

+27
-39
lines changed

.github/workflows/publish.yml

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,6 @@ on:
1717
type: string
1818

1919
jobs:
20-
get-version:
21-
uses: ./.github/workflows/get_semantic_release_version.yml
22-
with:
23-
custom_version: ${{ github.event.inputs.custom_version }}
24-
token: ${{ github.event.inputs.token }}
25-
2620
publish-python-sdk:
2721
uses: ./.github/workflows/publish_python_sdk.yml
2822
with:
@@ -31,21 +25,21 @@ jobs:
3125

3226
build-publish-docker-images:
3327
uses: ./.github/workflows/publish_images.yml
34-
needs: [ get-version, publish-python-sdk ]
28+
needs: [ publish-python-sdk ]
3529
with:
3630
custom_version: ${{ github.event.inputs.custom_version }}
3731
token: ${{ github.event.inputs.token }}
3832

3933
publish-helm-charts:
4034
uses: ./.github/workflows/publish_helm_charts.yml
41-
needs: [ get-version, publish-python-sdk ]
35+
needs: [ publish-python-sdk ]
4236
with:
4337
custom_version: ${{ github.event.inputs.custom_version }}
4438
token: ${{ github.event.inputs.token }}
4539

4640
publish-java-sdk:
4741
uses: ./.github/workflows/publish_java_sdk.yml
48-
needs: [ get-version, publish-python-sdk ]
42+
needs: [ publish-python-sdk ]
4943
with:
5044
custom_version: ${{ github.event.inputs.custom_version }}
5145
token: ${{ github.event.inputs.token }}

.github/workflows/publish_helm_charts.yml

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -25,20 +25,17 @@ on:
2525
type: string
2626

2727
jobs:
28-
get-version:
29-
uses: ./.github/workflows/get_semantic_release_version.yml
30-
with:
31-
custom_version: ${{ github.event.inputs.custom_version }}
32-
token: ${{ github.event.inputs.token }}
33-
3428
publish-helm-charts:
3529
if: github.repository == 'feast-dev/feast'
3630
runs-on: ubuntu-latest
37-
needs: get-version
3831
env:
3932
HELM_VERSION: v3.8.0
40-
VERSION_WITHOUT_PREFIX: ${{ needs.get-version.outputs.version_without_prefix }}
4133
steps:
34+
- id: get-version
35+
uses: ./.github/workflows/get_semantic_release_version.yml
36+
with:
37+
custom_version: ${{ github.event.inputs.custom_version }}
38+
token: ${{ github.event.inputs.token }}
4239
- uses: actions/checkout@v4
4340
- name: Authenticate to Google Cloud
4441
uses: 'google-github-actions/auth@v1'
@@ -56,7 +53,11 @@ jobs:
5653
- name: Validate Helm chart prior to publishing
5754
run: ./infra/scripts/helm/validate-helm-chart-publish.sh
5855
- name: Validate all version consistency
56+
env:
57+
VERSION_WITHOUT_PREFIX: ${{ steps.get-version.outputs.version_without_prefix }}
5958
run: ./infra/scripts/helm/validate-helm-chart-versions.sh $VERSION_WITHOUT_PREFIX
6059
- name: Publish Helm charts
60+
env:
61+
VERSION_WITHOUT_PREFIX: ${{ steps.get-version.outputs.version_without_prefix }}
6162
run: ./infra/scripts/helm/push-helm-charts.sh $VERSION_WITHOUT_PREFIX
6263

.github/workflows/publish_java_sdk.yml

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -26,18 +26,16 @@ on:
2626

2727

2828
jobs:
29-
get-version:
30-
uses: ./.github/workflows/get_semantic_release_version.yml
31-
with:
32-
custom_version: ${{ github.event.inputs.custom_version }}
33-
token: ${{ github.event.inputs.token }}
34-
3529
publish-java-sdk:
3630
if: github.repository == 'feast-dev/feast'
3731
container: maven:3.6-jdk-11
3832
runs-on: ubuntu-latest
39-
needs: [ get-version ]
4033
steps:
34+
- id: get-version
35+
uses: ./.github/workflows/get_semantic_release_version.yml
36+
with:
37+
custom_version: ${{ github.event.inputs.custom_version }}
38+
token: ${{ github.event.inputs.token }}
4139
- uses: actions/checkout@v4
4240
with:
4341
submodules: 'true'
@@ -59,7 +57,7 @@ jobs:
5957
${{ runner.os }}-it-maven-
6058
- name: Publish java sdk
6159
env:
62-
VERSION_WITHOUT_PREFIX: ${{ needs.get-version.outputs.version_without_prefix }}
60+
VERSION_WITHOUT_PREFIX: ${{ steps.get-version.outputs.version_without_prefix }}
6361
GPG_PUBLIC_KEY: ${{ secrets.GPG_PUBLIC_KEY }}
6462
GPG_PRIVATE_KEY: ${{ secrets.GPG_PRIVATE_KEY }}
6563
MAVEN_SETTINGS: ${{ secrets.MAVEN_SETTINGS }}

.github/workflows/publish_python_sdk.yml

Lines changed: 9 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -25,24 +25,19 @@ on:
2525
type: string
2626

2727
jobs:
28-
get-version:
29-
uses: ./.github/workflows/get_semantic_release_version.yml
30-
with:
31-
custom_version: ${{ github.event.inputs.custom_version }}
32-
token: ${{ github.event.inputs.token }}
33-
34-
build_wheels:
35-
uses: ./.github/workflows/build_wheels.yml
36-
needs: get-version
37-
with:
38-
release_version: ${{ needs.get-version.outputs.release_version }}
39-
highest_semver_tag: ${{ needs.get-version.outputs.highest_semver_tag }}
40-
4128
publish-python-sdk:
4229
if: github.repository == 'feast-dev/feast'
4330
runs-on: ubuntu-latest
44-
needs: [ get-version, build_wheels ]
4531
steps:
32+
- id: get-version
33+
uses: ./.github/workflows/get_semantic_release_version.yml
34+
with:
35+
custom_version: ${{ github.event.inputs.custom_version }}
36+
token: ${{ github.event.inputs.token }}
37+
- uses: ./.github/workflows/build_wheels.yml
38+
with:
39+
release_version: ${{ steps.get-version.outputs.release_version }}
40+
highest_semver_tag: ${{ steps.get-version.outputs.highest_semver_tag }}
4641
- uses: actions/download-artifact@v4.1.7
4742
with:
4843
name: python-wheels

0 commit comments

Comments
 (0)