fix reviews

Signed-off-by: aaronzuo <anarionzuo@outlook.com>

Author: Anarion-zuo

.github/workflows/pr_integration_tests.yml

@@ -127,6 +127,7 @@ jobs:
           SERVER_PID=$!
           echo $SERVER_PID > /tmp/feast_server_pid
           for i in $(seq 1 60); do
+            kill -0 "$SERVER_PID" || { echo "server died"; exit 1; }
             if curl -fsS http://127.0.0.1:6566/health >/dev/null; then
               break
             fi
@@ -143,7 +144,7 @@ jobs:
             -H "Content-Type: application/json" \
             -H "mcp-protocol-version: 2025-03-26" \
             --data '{}' \
-            http://127.0.0.1:6566/mcp || true
+            http://127.0.0.1:6566/mcp
 
           SESSION_ID=$(grep -i "^mcp-session-id:" /tmp/mcp_headers | head -1 | awk '{print $2}' | tr -d '\r')
           if [ -z "${SESSION_ID}" ]; then

sdk/python/feast/feature_server.py

@@ -710,7 +710,7 @@ def _add_mcp_support_if_enabled(app, store: "feast.FeatureStore"):
                 )
 
                 mcp_transport_not_supported_error = McpTransportNotSupportedError
-            except Exception as e:
+            except ImportError as e:
                 logger.error(f"Error checking/adding MCP support: {e}")
                 return
 

sdk/python/feast/infra/mcp_servers/mcp_server.py

@@ -45,7 +45,7 @@ def add_mcp_support_to_app(app, store: FeatureStore, config) -> Optional["FastAp
         )
 
         transport: Literal["sse", "http"] = (
-            getattr(config, "mcp_transport", "sse") or "sse"
+            getattr(config, "mcp_transport", "sse")
         )
         if transport == "http":
             mount_http = getattr(mcp, "mount_http", None)
@@ -60,8 +60,10 @@ def add_mcp_support_to_app(app, store: FeatureStore, config) -> Optional["FastAp
             if mount_sse is not None:
                 mount_sse()
             else:
+                logging.warning("transport sse not supported, fallback to the deprecated mount().")
                 mcp.mount()
         else:
+            # Code should not reach here
             raise McpTransportNotSupportedError(
                 f"Unsupported mcp_transport={transport!r}. Expected 'sse' or 'http'."
             )
@@ -79,5 +81,5 @@ def add_mcp_support_to_app(app, store: FeatureStore, config) -> Optional["FastAp
     except McpTransportNotSupportedError:
         raise
     except Exception as e:
-        logger.error(f"Failed to initialize MCP integration: {e}")
+        logger.error(f"Failed to initialize MCP integration: {e}", exc_info=True)
         return None