Skip to content

Commit 66aa7b8

Browse files
Anshi Shrivastavantkathole
authored andcommitted
Fix: Rename example_repo.py to feature_definitions.py in templates
1 parent 25604d6 commit 66aa7b8

File tree

33 files changed

+316
-25
lines changed

33 files changed

+316
-25
lines changed

docs/getting-started/quickstart.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ Creating a new Feast repository in /home/Jovyan/my_project.
9797
Let's take a look at the resulting demo repo itself. It breaks down into
9898

9999
* `data/` contains raw demo parquet data
100-
* `example_repo.py` contains demo feature definitions
100+
* `feature_definitions.py` contains demo feature definitions
101101
* `feature_store.yaml` contains a demo setup configuring where data sources are
102102
* `test_workflow.py` showcases how to run all key Feast commands, including defining, retrieving, and pushing features.
103103
You can run this with `python test_workflow.py`.
@@ -117,7 +117,7 @@ entity_key_serialization_version: 3
117117
```
118118
{% endtab %}
119119
120-
{% tab title="example_repo.py" %}
120+
{% tab title="feature_definitions.py" %}
121121
```python
122122
# This is an example feature definition file
123123

@@ -310,7 +310,7 @@ We'll walk through some snippets of code below and explain
310310
### Step 4: Register feature definitions and deploy your feature store
311311

312312
The `apply` command scans python files in the current directory for feature view/entity definitions, registers the
313-
objects, and deploys infrastructure. In this example, it reads `example_repo.py` and sets up SQLite online store tables. Note that we had specified SQLite as the default online store by
313+
objects, and deploys infrastructure. In this example, it reads `feature_definitions.py` and sets up SQLite online store tables. Note that we had specified SQLite as the default online store by
314314
configuring `online_store` in `feature_store.yaml`.
315315

316316
{% tabs %}
@@ -496,7 +496,7 @@ print(training_df.head())
496496
{% endtabs %}
497497
### Step 6: Ingest batch features into your online store
498498

499-
We now serialize the latest values of features since the beginning of time to prepare for serving. Note, `materialize_incremental` serializes all new features since the last `materialize` call, or since the time provided minus the `ttl` timedelta. In this case, this will be `CURRENT_TIME - 1 day` (`ttl` was set on the `FeatureView` instances in [feature_repo/feature_repo/example_repo.py](feature_repo/feature_repo/example_repo.py)).
499+
We now serialize the latest values of features since the beginning of time to prepare for serving. Note, `materialize_incremental` serializes all new features since the last `materialize` call, or since the time provided minus the `ttl` timedelta. In this case, this will be `CURRENT_TIME - 1 day` (`ttl` was set on the `FeatureView` instances in [feature_repo/feature_repo/feature_definitions.py](feature_repo/feature_repo/feature_definitions.py)).
500500

501501
{% tabs %}
502502
{% tab title="Bash (with timestamp)" %}

docs/reference/online-stores/dragonfly.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ There are several options available to get Dragonfly up and running quickly. We
4848

4949
`feast apply`
5050

51-
The `apply` command scans python files in the current directory (`example_repo.py` in this case) for feature view/entity definitions, registers the objects, and deploys infrastructure.
51+
The `apply` command scans python files in the current directory (`feature_definitions.py` in this case) for feature view/entity definitions, registers the objects, and deploys infrastructure.
5252
You should see the following output:
5353

5454
```

examples/rhoai-quickstart/feast-demo-quickstart.ipynb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -230,7 +230,7 @@
230230
"id": "cd23ce19-03fa-4353-86d3-261c7f514fd8",
231231
"metadata": {},
232232
"source": [
233-
"File `data/driver_stats.parquet` is generated by the `feast init` command and it acts a historical information source to this example. We have defined this source in the [my_feast_project/feature_repo/example_repo.py](./my_feast_project/feature_repo/example_repo.py) file.\n",
233+
"File `data/driver_stats.parquet` is generated by the `feast init` command and it acts a historical information source to this example. We have defined this source in the [my_feast_project/feature_repo/feature_definitions.py](./my_feast_project/feature_repo/feature_definitions.py) file.\n",
234234
"\n",
235235
"```python\n",
236236
"driver_stats_source = FileSource(\n",

sdk/python/feast/templates/aws/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
A quick view of what's in this repository:
33

44
* `data/` contains raw demo parquet data
5-
* `example_repo.py` contains demo feature definitions
5+
* `feature_definitions.py` contains demo feature definitions
66
* `feature_store.yaml` contains a demo setup configuring where data sources are
77
* `test_workflow.py` showcases how to run all key Feast commands, including defining, retrieving, and pushing features.
88

sdk/python/feast/templates/aws/bootstrap.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ def bootstrap():
5555
)
5656

5757
repo_path = pathlib.Path(__file__).parent.absolute() / "feature_repo"
58-
example_py_file = repo_path / "example_repo.py"
58+
example_py_file = repo_path / "feature_definitions.py"
5959
replace_str_in_file(example_py_file, "%REDSHIFT_DATABASE%", database)
6060

6161
config_file = repo_path / "feature_store.yaml"

sdk/python/feast/templates/aws/feature_repo/example_repo.py renamed to sdk/python/feast/templates/aws/feature_repo/feature_definitions.py

File renamed without changes.

sdk/python/feast/templates/cassandra/bootstrap.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -273,8 +273,8 @@ def bootstrap():
273273
driver_stats_path = data_path / "driver_stats.parquet"
274274
driver_df.to_parquet(path=str(driver_stats_path), allow_truncated_timestamps=True)
275275

276-
# example_repo.py
277-
example_py_file = repo_path / "example_repo.py"
276+
# feature_definitions.py
277+
example_py_file = repo_path / "feature_definitions.py"
278278
replace_str_in_file(
279279
example_py_file, "%PARQUET_PATH%", str(driver_stats_path.relative_to(repo_path))
280280
)

sdk/python/feast/templates/cassandra/feature_repo/example_repo.py renamed to sdk/python/feast/templates/cassandra/feature_repo/feature_definitions.py

File renamed without changes.

sdk/python/feast/templates/couchbase/feature_repo/example_repo.py renamed to sdk/python/feast/templates/couchbase/feature_repo/feature_definitions.py

File renamed without changes.

sdk/python/feast/templates/gcp/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
A quick view of what's in this repository:
33

44
* `data/` contains raw demo parquet data
5-
* `example_repo.py` contains demo feature definitions
5+
* `feature_definitions.py` contains demo feature definitions
66
* `feature_store.yaml` contains a demo setup configuring where data sources are
77
* `test_workflow.py` showcases how to run all key Feast commands, including defining, retrieving, and pushing features.
88

0 commit comments

Comments
 (0)