check for case-insensitive matches across types

Author: Prathap-P

sdk/python/feast/infra/registry/base_registry.py

@@ -26,7 +26,6 @@
 from feast.entity import Entity
 from feast.errors import (
     ConflictingFeatureViewNames,
-    FeatureViewNotFoundException,
 )
 from feast.feature_service import FeatureService
 from feast.feature_view import FeatureView
@@ -281,46 +280,17 @@ def _ensure_feature_view_name_is_unique(
         The primary validation happens in _validate_all_feature_views() during feast plan/apply.
         """
         name = feature_view.name
+        case_insensitive_name = name.lower()
         new_type = type(feature_view).__name__
+        for existing_feature_view in self.list_all_feature_views(
+            project, allow_cache=allow_cache
+        ):
+            if existing_feature_view.name.lower() != case_insensitive_name:
+                continue
 
-        def _check_conflict(getter, not_found_exc, existing_type: str):
-            try:
-                getter(name, project, allow_cache=allow_cache)
+            existing_type = type(existing_feature_view).__name__
+            if existing_type != new_type:
                 raise ConflictingFeatureViewNames(name, existing_type, new_type)
-            except not_found_exc:
-                pass
-
-        # Check StreamFeatureView before FeatureView since StreamFeatureView is a subclass
-        # Note: All getters raise FeatureViewNotFoundException (not type-specific exceptions)
-        if isinstance(feature_view, StreamFeatureView):
-            _check_conflict(
-                self.get_feature_view, FeatureViewNotFoundException, "FeatureView"
-            )
-            _check_conflict(
-                self.get_on_demand_feature_view,
-                FeatureViewNotFoundException,
-                "OnDemandFeatureView",
-            )
-        elif isinstance(feature_view, FeatureView):
-            _check_conflict(
-                self.get_stream_feature_view,
-                FeatureViewNotFoundException,
-                "StreamFeatureView",
-            )
-            _check_conflict(
-                self.get_on_demand_feature_view,
-                FeatureViewNotFoundException,
-                "OnDemandFeatureView",
-            )
-        elif isinstance(feature_view, OnDemandFeatureView):
-            _check_conflict(
-                self.get_feature_view, FeatureViewNotFoundException, "FeatureView"
-            )
-            _check_conflict(
-                self.get_stream_feature_view,
-                FeatureViewNotFoundException,
-                "StreamFeatureView",
-            )
 
     @abstractmethod
     def delete_feature_view(self, name: str, project: str, commit: bool = True):

sdk/python/tests/integration/registration/test_universal_registry.py

@@ -2061,6 +2061,60 @@ def simple_udf(x: int):
     test_registry.teardown()
 
 
+@pytest.mark.integration
+@pytest.mark.parametrize("test_registry", all_fixtures)
+def test_cross_type_feature_view_name_conflict_case_insensitive(
+    test_registry: BaseRegistry,
+):
+    """
+    Test that cross-type feature view name checks are case-insensitive.
+    """
+    project = "project"
+
+    entity = Entity(name="driver_entity", join_keys=["test_key"])
+    file_source = FileSource(name="my_file_source", path="test.parquet")
+    feature_view = FeatureView(
+        name="Shared_Feature_View_Name",
+        entities=[entity],
+        schema=[Field(name="feature1", dtype=Float32)],
+        source=file_source,
+    )
+
+    stream_source = KafkaSource(
+        name="kafka",
+        timestamp_field="event_timestamp",
+        kafka_bootstrap_servers="",
+        message_format=AvroFormat(""),
+        topic="topic",
+        batch_source=FileSource(path="some path"),
+        watermark_delay_threshold=timedelta(days=1),
+    )
+
+    def simple_udf(x: int):
+        return x + 3
+
+    stream_feature_view = StreamFeatureView(
+        name="shared_feature_view_name",
+        entities=[entity],
+        ttl=timedelta(days=30),
+        schema=[Field(name="feature1", dtype=Float32)],
+        source=stream_source,
+        udf=simple_udf,
+    )
+
+    test_registry.apply_feature_view(feature_view, project)
+
+    with pytest.raises(ConflictingFeatureViewNames) as exc_info:
+        test_registry.apply_feature_view(stream_feature_view, project)
+
+    error_message = str(exc_info.value)
+    assert "FeatureView" in error_message
+    assert "StreamFeatureView" in error_message
+
+    test_registry.delete_feature_view("Shared_Feature_View_Name", project)
+    test_registry.teardown()
+
+
 @pytest.mark.integration
 @pytest.mark.parametrize("test_registry", all_fixtures)
 def test_cross_type_feature_view_odfv_conflict(test_registry: BaseRegistry):

sdk/python/tests/unit/infra/registry/test_sql_registry.py

@@ -105,3 +105,33 @@ def test_feature_view_name_conflict_between_stream_and_batch(sqlite_registry):
 
     with pytest.raises(ConflictingFeatureViewNames):
         sqlite_registry.apply_feature_view(stream_view, "test_project")
+
+
+def test_feature_view_name_conflict_is_case_insensitive(sqlite_registry):
+    entity = Entity(
+        name="driver",
+        value_type=ValueType.STRING,
+        join_keys=["driver_id"],
+    )
+    sqlite_registry.apply_entity(entity, "test_project")
+
+    file_source = FileSource(
+        path="driver_stats.parquet",
+        timestamp_field="event_timestamp",
+        created_timestamp_column="created",
+    )
+
+    batch_view = _build_feature_view("Driver_Activity", entity, file_source)
+    sqlite_registry.apply_feature_view(batch_view, "test_project")
+
+    push_source = PushSource(name="driver_push", batch_source=file_source)
+    stream_view = StreamFeatureView(
+        name="driver_activity",
+        source=push_source,
+        entities=[entity],
+        schema=[Field(name="conv_rate", dtype=Float32)],
+        timestamp_field="event_timestamp",
+    )
+
+    with pytest.raises(ConflictingFeatureViewNames):
+        sqlite_registry.apply_feature_view(stream_view, "test_project")