infra/feast-operator: move helm generation from manifests to build-installer per maintainer feedback

Signed-off-by: matt <[email protected]>

Author: mkerkstra

infra/feast-operator/Makefile

@@ -99,8 +99,6 @@ help: ## Display this help.
 .PHONY: manifests
 manifests: controller-gen ## Generate WebhookConfiguration, ClusterRole and CustomResourceDefinition objects.
 	$(CONTROLLER_GEN) rbac:roleName=manager-role crd:maxDescLen=120 webhook paths="./..." output:crd:artifacts:config=config/crd/bases
-	# Generate dynamic Helm chart from updated manifests
-	$(MAKE) helm-generate
 
 .PHONY: generate
 generate: controller-gen ## Generate code containing DeepCopy, DeepCopyInto, and DeepCopyObject method implementations.
@@ -193,6 +191,8 @@ build-installer: manifests generate-ref kustomize related-image-fs ## Generate a
 	mkdir -p dist
 	cd config/manager && $(KUSTOMIZE) edit set image controller=${IMG}
 	$(KUSTOMIZE) build config/default > dist/install.yaml
+	# Generate dynamic Helm chart as part of release build flow
+	$(MAKE) helm-generate
 
 ##@ Deployment
 
@@ -409,10 +409,6 @@ helm-generate: kustomize helmify related-image-fs ## Generate Helm chart dynamic
 	@rm -rf $(HELM_CHART_DIR)/$(HELM_CHART_NAME)
 	$(KUSTOMIZE) build config/default | $(HELMIFY) -crd-dir $(HELM_CHART_NAME)
 	@mv $(HELM_CHART_NAME) $(HELM_CHART_DIR)/
-	@echo "Setting chart version to $(VERSION)..."
-	@sed -i.bak 's/version: 0.1.0/version: $(VERSION)/' $(HELM_CHART_DIR)/$(HELM_CHART_NAME)/Chart.yaml
-	@sed -i.bak 's/appVersion: "0.1.0"/appVersion: "$(VERSION)"/' $(HELM_CHART_DIR)/$(HELM_CHART_NAME)/Chart.yaml
-	@rm -f $(HELM_CHART_DIR)/$(HELM_CHART_NAME)/Chart.yaml.bak
 	@echo "Dynamic Helm chart generated at $(HELM_CHART_DIR)/$(HELM_CHART_NAME)"
 	@echo "Chart replaces the manually maintained chart - review and commit changes"