Skip to content

Commit ee9c38d

Browse files
committed
fix: avoid creating empty Milvus indexes
1 parent 96051fa commit ee9c38d

File tree

1 file changed

+7
-4
lines changed
  • sdk/python/feast/infra/online_stores/milvus_online_store

1 file changed

+7
-4
lines changed

sdk/python/feast/infra/online_stores/milvus_online_store/milvus.py

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -202,6 +202,7 @@ def _get_or_create_collection(
202202
schema=schema,
203203
)
204204
index_params = self.client.prepare_index_params()
205+
added_index = False
205206
for vector_field in schema.fields:
206207
if (
207208
vector_field.dtype
@@ -222,10 +223,12 @@ def _get_or_create_collection(
222223
index_name=f"vector_index_{vector_field.name}",
223224
params={"nlist": config.online_store.nlist},
224225
)
225-
self.client.create_index(
226-
collection_name=collection_name,
227-
index_params=index_params,
228-
)
226+
added_index = True
227+
if added_index:
228+
self.client.create_index(
229+
collection_name=collection_name,
230+
index_params=index_params,
231+
)
229232
else:
230233
self.client.load_collection(collection_name)
231234
self._collections[collection_name] = self.client.describe_collection(

0 commit comments

Comments
 (0)