Look for other opportunities to use Go 1.25

The easy one is sync.WaitGroup.Go. At least for the cases where I'm not
doing weird and special things with WaitGroups.

Despite all I've done with the pre-release versions, I had no idea
net/http was getting built-in CSRF protection until today. It's not
perfect since it relies on a relatively new browser feature, but it's
certainly better than the "don't use this" comment I have in the RPC
handler package right now. I'd like to take my time working it in,
though.

Author: featherbread

internal/api/rpc/rpc.go

@@ -13,6 +13,7 @@
 // This framework is not considered acceptable for Internet-facing production
 // use. For example, the Content-Type enforcement described above is the only
 // mitigation against cross-site request forgery attacks.
+// (TODO: Consider adopting http.CrossOriginProtection from Go 1.25.)
 package rpc
 
 import (

internal/api/tunerstatus.go

@@ -48,11 +48,7 @@ func (tsh *TunerStatusHandler) ServeHTTP(w http.ResponseWriter, r *http.Request)
 	}
 	defer tsh.socket.Close()
 
-	tsh.waitGroup.Add(1)
-	go func() {
-		defer tsh.waitGroup.Done()
-		tsh.drainClient()
-	}()
+	tsh.waitGroup.Go(tsh.drainClient)
 
 	tsh.watch = tsh.tuner.WatchStatus(tsh.sendNewTunerStatus)
 	defer tsh.watch.Cancel()

internal/api/webrtc.go

@@ -86,11 +86,7 @@ func (wh *WebRTCHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
 	}
 	defer wh.rtcPeer.Close()
 
-	wh.waitGroup.Add(1)
-	go func() {
-		defer wh.waitGroup.Done()
-		wh.handleClientSessionAnswers()
-	}()
+	wh.waitGroup.Go(wh.handleClientSessionAnswers)
 
 	wh.watch = wh.tuner.WatchTracks(wh.handleTrackUpdate)
 	defer wh.watch.Cancel()

internal/watch/watch_test.go

@@ -48,11 +48,10 @@ func TestValueStress(t *testing.T) {
 	}
 
 	var setGroup sync.WaitGroup
-	setGroup.Add(nWrites - 1)
 	for i := 1; i <= nWrites-1; i++ {
 		// This will quickly make the race detector complain if Set is not properly
 		// synchronized.
-		go func() { defer setGroup.Done(); v.Set(i) }()
+		setGroup.Go(func() { v.Set(i) })
 	}
 	setGroup.Wait()