Commit 69d82f1
committed
Remove internal/slack dependency on internal/store
Because the Slack package imported the entire store package for the sake
of a single defined type that wasn't even used anywhere else, the Lambda
handler was getting a bunch of Firestore junk linked in that I had
clearly not intended (as evidenced by me importing only the DynamoDB
store into the main package).
This shaves about 4 MB off of the darwin/arm64 copy of the binary, which
admittedly isn't a great metric to base this on but is the easiest one
for me to look at.
There's still work to be done here, since I'm still seeing the gRPC
libraries linked in even though Firestore is gone. Is Amazon secretly
using gRPC too? Or have I missed some other dependency?1 parent 60a80d2 commit 69d82f1
2 files changed
+2
-3
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | | - | |
15 | 14 | | |
16 | 15 | | |
17 | 16 | | |
| |||
27 | 26 | | |
28 | 27 | | |
29 | 28 | | |
30 | | - | |
| 29 | + | |
31 | 30 | | |
32 | 31 | | |
33 | 32 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
20 | | - | |
| 20 | + | |
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
| |||
0 commit comments