Try a few more pedantic Clippy lints

You still can't convince me that an if-else is _more_ readable than my
match on a boolean in LocatedError::from_parts. I also don't care for
the insistence on replacing closures directly with their functions;
shouldn't the compiler be able to optimize that?

I'd love to turn on the one about un-backticked items in doc comments,
but it keeps picking up on "MessagePack" despite that being the human
name of that particular data format. I'm not sure if you can customize
exclusions to that rule.

Author: featherbread

src/lib.rs

@@ -21,7 +21,9 @@
 	clippy::unnecessary_cast,
 	// More general style-type things.
 	clippy::from_over_into,
+	clippy::needless_raw_string_hashes,
 	clippy::semicolon_if_nothing_returned,
+	clippy::similar_names,
 )]
 #![warn(
 	// Print macros can panic, and should only be for temporary debugging.

src/main.rs

@@ -11,7 +11,9 @@
 	clippy::unnecessary_cast,
 	// More general style-type things.
 	clippy::from_over_into,
+	clippy::needless_raw_string_hashes,
 	clippy::semicolon_if_nothing_returned,
+	clippy::similar_names,
 )]
 #![warn(
 	// Print macros can panic, and should only be for temporary debugging.
@@ -175,10 +177,10 @@ where
 	let argv0 = usage_name();
 	let _ = write!(
 		w,
-		r#"Usage: {argv0} {USAGE}
+		r"Usage: {argv0} {USAGE}
 Formats: json, msgpack, toml, yaml
 Try '{argv0} --help' for more information.
-"#
+"
 	);
 }
 

src/msgpack.rs

@@ -13,7 +13,7 @@ use crate::transcode;
 
 /// The maximum allowed nesting depth of MessagePack values.
 ///
-/// This particular value is the undocumented default from rmp_serde, which
+/// This particular value is the undocumented default from [`rmp_serde`], which
 /// seems to be enough to reliably prevent stack overflows on debug builds of
 /// the program using the default main thread stack size on Linux and macOS.
 const DEPTH_LIMIT: usize = 1024;

src/transcode/stream.rs

@@ -329,8 +329,7 @@ impl<'de, S: Serializer> de::Visitor<'de> for &mut Visitor<S> {
 	}
 
 	fn visit_seq<A: de::SeqAccess<'de>>(self, mut de: A) -> Result<Self::Value, A::Error> {
-		let ser = self.0.take_parent();
-		let mut seq = match ser.serialize_seq(de.size_hint()) {
+		let mut seq = match self.0.take_parent().serialize_seq(de.size_hint()) {
 			Ok(seq) => seq,
 			Err(ser_err) => {
 				self.0.capture_error(ErrorSource::Ser, ser_err);
@@ -360,8 +359,7 @@ impl<'de, S: Serializer> de::Visitor<'de> for &mut Visitor<S> {
 	}
 
 	fn visit_map<A: de::MapAccess<'de>>(self, mut de: A) -> Result<Self::Value, A::Error> {
-		let ser = self.0.take_parent();
-		let mut map = match ser.serialize_map(de.size_hint()) {
+		let mut map = match self.0.take_parent().serialize_map(de.size_hint()) {
 			Ok(map) => map,
 			Err(ser_err) => {
 				self.0.capture_error(ErrorSource::Ser, ser_err);

src/yaml/chunker.rs

@@ -198,13 +198,13 @@ mod tests {
 
 	#[test]
 	fn chunker_normal_usage() {
-		const INPUT: &str = r#"---
+		const INPUT: &str = r"---
 test: true
 ---
 12345
 ---
 [list, of strings]
-"#;
+";
 
 		let chunker = Chunker::new(INPUT.as_bytes());
 		let docs = chunker.collect::<Result<Vec<_>, io::Error>>().unwrap();

src/yaml/chunker/parser.rs

@@ -115,7 +115,7 @@ where
 	///
 	/// # Safety
 	///
-	/// The data pointer provided to yaml_parser_set_input must be a valid
+	/// The data pointer provided to `yaml_parser_set_input` must be a valid
 	/// `ReadState<R>` pointer.
 	unsafe fn read_handler(
 		read_state: *mut c_void,