Skip to content

Commit 5efaf1e

Browse files
compose: ensure dockerfile is unique per config
1 parent 902d3f3 commit 5efaf1e

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

docker_compose.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ func WriteDockerCompose(config config.Config, dir string, bakeEnv bool) error {
9090
App: ComposeService{
9191
Image: utils.DefaultNamespace + "/" + config.Name,
9292
Build: ComposeBuild{
93-
Dockerfile: "./Dockerfile",
93+
Dockerfile: "./" + config.Name + ".dockerfile",
9494
Labels: labels,
9595
Shm_Size: "512m",
9696
Args: args,
@@ -124,7 +124,7 @@ func WriteDockerfile(config config.Config, dir string, pupsArgs string, bakeEnv
124124
return err
125125
}
126126

127-
file := strings.TrimRight(dir, "/") + "/" + "Dockerfile"
127+
file := strings.TrimRight(dir, "/") + "/" + config.Name + ".dockerfile"
128128
if err := os.WriteFile(file, []byte(config.Dockerfile(pupsArgs, bakeEnv)), 0660); err != nil {
129129
return errors.New("error writing dockerfile Dockerfile " + file)
130130
}

main_test.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,13 +64,14 @@ var _ = Describe("Generate", func() {
6464
out, err = os.ReadFile(testDir + "/config.yaml")
6565
Expect(err).To(BeNil())
6666
Expect(string(out[:])).To(ContainSubstring("DISCOURSE_DEVELOPER_EMAILS: '[email protected],[email protected]'"))
67-
out, err = os.ReadFile(testDir + "/Dockerfile")
67+
out, err = os.ReadFile(testDir + "/test.dockerfile")
6868
Expect(err).To(BeNil())
6969
Expect(string(out[:])).To(ContainSubstring("RUN cat /temp-config.yaml"))
7070

7171
out, err = os.ReadFile(testDir + "/docker-compose.yaml")
7272
Expect(err).To(BeNil())
7373
Expect(string(out[:])).To(ContainSubstring("build:"))
74+
Expect(string(out[:])).To(ContainSubstring("dockerfile: ./test.dockerfile"))
7475
Expect(string(out[:])).To(ContainSubstring("image: local_discourse/test"))
7576
})
7677
})

0 commit comments

Comments
 (0)