WIP

Author: fratzinger

README.md

@@ -2,13 +2,13 @@
 
 #### hooks
 
-- added alterData, alterResult, deprecated alterItems
-- added discardData, discardResult, deprecated discard
-  - moved to omitData, omitResult, deprecated omit
-- added keepData, keepResult, deprecated keep
-  - moved to pickData, pickResult, deprecated pick
-- added lowercaseData, lowercaseResult, deprecated lowercase
-- added setNowData, setNowResult, deprecated setNow
+- added alterData, alterResult, rm alterItems
+- added discardData, discardResult, rm discard
+  - moved to omitData, omitResult, rm omit
+- added keepData, keepResult, rm keep
+  - moved to pickData, pickResult, rm pick
+- added lowercaseData, lowercaseResult, rm lowercase
+- added setNowData, setNowResult, rm setNow
 
 - removed several checks that are handled by typescript
 - removed check for `preventChanges(true, ...fieldNames)`
@@ -29,6 +29,8 @@
 
 - rm support for spread argument
 
+- rm 'actOnDispatch' & 'actOnDefault'
+
 #### predicates
 
 - renamed 'isNot' to 'not' (added alias for 'isNot')

package.json

@@ -25,7 +25,7 @@
     "release:major": "npm version major && npm publish",
     "changelog": "github_changelog_generator --max-issues 200 -u feathersjs-ecosystem -p feathers-hooks-common && git add CHANGELOG.md && git commit -am \"Updating changelog\"",
     "lint": "eslint .",
-    "update-dependencies": "ncu -u -x ajv",
+    "update-dependencies": "ncu -u",
     "test:unit": "vitest run",
     "coverage": "vitest run --coverage",
     "test": "npm run lint && npm run coverage",
@@ -64,9 +64,7 @@
   ],
   "dependencies": {
     "@feathersjs/errors": "^5.0.31",
-    "ajv": "^6.12.6",
     "fast-copy": "^3.0.2",
-    "graphql": "^16.10.0",
     "lodash": "^4.17.21",
     "neotraverse": "^0.6.18"
   },

src/hooks/act-on-dispatch/act-on-dispatch.test.ts

@@ -1,4 +1,4 @@
-import type { HookContext } from '@feathersjs/feathers';
+import type { HookContext, NextFunction } from '@feathersjs/feathers';
 import { replaceData } from '../../utils/replace-items/replace-data';
 import { isPromise } from '../../common';
 
@@ -8,8 +8,8 @@ import { isPromise } from '../../common';
  */
 export const alterData =
   <T = any, H extends HookContext = HookContext>(cb: (record: T, context: H) => any) =>
-  (context: H) =>
-    replaceData(context, (item: any) => {
+  async (context: H, next?: NextFunction) => {
+    await replaceData(context, (item: any) => {
       const result = cb(item, context);
 
       if (isPromise(result)) {
@@ -18,3 +18,8 @@ export const alterData =
         return result ?? item;
       }
     });
+
+    if (next) {
+      return next();
+    }
+  };