Fix multi record remove cache (#605)

Author: uulwake

lib/services/cache.js

@@ -16,7 +16,14 @@ module.exports = function (cacheMap, keyFieldName, options = {}) {
     const query = context.params.query || {};
 
     if (context.type === 'after') {
-      if (context.method === 'remove') return;
+      if (context.method === 'remove') {
+        items.forEach(item => {
+          const idName = getIdName(keyFieldName, item);
+          const key = makeCacheKey(item[idName]);
+          cacheMap.delete(key);
+        });
+        return;
+      }
 
       if (query.$select) return;
 
@@ -31,6 +38,7 @@ module.exports = function (cacheMap, keyFieldName, options = {}) {
 
     switch (context.method) {
       case 'find': // fall through
+      case 'remove': // skip remove in before remove
       case 'create':
         return;
       case 'get': {

tests/services/cache.test.js

@@ -159,6 +159,29 @@ describe('service cache', () => {
       cache(cacheMap, 'id')(hookBeforeSingle);
       assert.deepEqual(cacheMap.get(1), 123);
     });
+
+    it('NOT before multi-record remove', () => {
+      hookBeforeMulti.method = 'remove';
+
+      cacheMap.set(1, 123);
+      cacheMap.set(2, 321);
+
+      cache(cacheMap, 'id')(hookBeforeMulti);
+      assert.deepEqual(cacheMap.get(1), 123);
+      assert.deepEqual(cacheMap.get(2), 321);
+    });
+
+    it('After multi-record remove', () => {
+      hookAfterMulti.method = 'remove';
+
+      cacheMap.set(1, 123);
+      cacheMap.set(2, 321);
+
+      cache(cacheMap, 'id')(hookAfterMulti);
+
+      assert.deepEqual(cacheMap.get(1), undefined, 'id 1');
+      assert.deepEqual(cacheMap.get(2), undefined, 'id 2');
+    });
   });
 
   describe('Loads cache', () => {