Fixing preventChanges (#680)

Author: zaheraldefai

src/hooks/prevent-changes.ts

@@ -22,18 +22,18 @@ export function preventChanges (
 
   return (context: any) => {
     checkContext(context, 'before', ['patch'], 'preventChanges');
-    const { data } = context;
+    let data = { ...context.data };
 
     fieldNames.forEach(name => {
       if (_has(data, name)) {
         if (ifThrow) {
           throw new BadRequest(`Field ${name} may not be patched. (preventChanges)`);
         }
         // Delete data.contactPerson.name
-        context.data = _omit(data, name);
+        data = _omit(data, name);
       }
     });
 
-    return context;
+    return { ...context, data };
   };
 }

test/hooks/prevent-changes.test.ts

@@ -130,6 +130,16 @@ describe('services preventChanges', () => {
       assert.deepEqual(context.data,
         { first: 'John', last: 'Doe', a: { b: 'john', c: { d: {} } } },
         '5');
+
+      context = preventChanges(false, 'first', 'last')(clone(hookBefore));
+      assert.deepEqual(context.data,
+        { a: { b: 'john', c: { d: { e: 1 } } } }
+      );
+
+      context = preventChanges(false, 'first', 'a.b', 'a.c.d.e')(clone(hookBefore));
+      assert.deepEqual(context.data,
+        { last: 'Doe', a: { c: { d: { } } } }
+      );
     });
   });
 });