fix: add js extension to lodash imports (#684)

fratzinger · web-flow · commit 846dcfa197e6 · 2022-07-31T12:58:35.000+02:00
* fix: add js extension to lodash imports

* chore: update dependencies
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -13,7 +13,7 @@
     }
   },
   "scripts": {
-    "compile": "shx rm -rf dist/ && tsup src/index.ts --format cjs,esm --dts",
+    "compile": "shx rm -rf dist/ && tsup src/index.ts --format cjs,esm --dts --treeshake",
     "docs": "vuepress dev docs",
     "docs:build": "vuepress build docs",
     "prepublishOnly": "npm run compile",
@@ -86,25 +86,25 @@
     "@types/debug": "^4.1.7",
     "@types/lodash": "^4.14.182",
     "@types/mocha": "^9.1.1",
-    "@types/node": "^17.0.35",
+    "@types/node": "^18.6.3",
     "@types/traverse": "^0.6.32",
-    "@typescript-eslint/eslint-plugin": "^5.25.0",
-    "@typescript-eslint/parser": "^5.25.0",
-    "c8": "^7.11.3",
+    "@typescript-eslint/eslint-plugin": "^5.31.0",
+    "@typescript-eslint/parser": "^5.31.0",
+    "c8": "^7.12.0",
     "chai": "^4.3.6",
     "clone": "^2.1.2",
-    "eslint": "^8.16.0",
+    "eslint": "^8.20.0",
     "eslint-plugin-import": "^2.26.0",
     "eslint-plugin-prefer-arrow": "^1.2.3",
     "feathers-memory": "^4.1.0",
     "mocha": "^10.0.0",
     "mongodb": "^4.6.0",
-    "npm-check-updates": "^13.0.3",
+    "npm-check-updates": "^16.0.3",
     "shx": "^0.3.4",
     "sift": "^16.0.0",
-    "ts-node": "^10.8.0",
-    "tsup": "^5.12.8",
-    "typescript": "^4.6.4",
+    "ts-node": "^10.9.1",
+    "tsup": "^6.2.1",
+    "typescript": "^4.7.4",
     "vuepress": "^1.9.7",
     "vuepress-theme-default-prefers-color-scheme": "^2.0.0"
   },
diff --git a/src/common/pluck.ts b/src/common/pluck.ts
@@ -1,4 +1,4 @@
-import _pick from 'lodash/pick';
+import _pick from 'lodash/pick.js';
 
 export function pluck <T extends Record<string, any>> (
   items: T,
diff --git a/src/common/set-fields.ts b/src/common/set-fields.ts
@@ -1,4 +1,4 @@
-import _set from 'lodash/set';
+import _set from 'lodash/set.js';
 
 export function setFields <T extends Record<string, any>> (
   items: T | T[],
diff --git a/src/common/transform-items.ts b/src/common/transform-items.ts
@@ -1,4 +1,4 @@
-import _get from 'lodash/get';
+import _get from 'lodash/get.js';
 
 export function transformItems <T extends Record<string, any>> (
   items: T | T[],
diff --git a/src/hooks/de-populate.ts b/src/hooks/de-populate.ts
@@ -1,5 +1,5 @@
 import type { Hook } from '@feathersjs/feathers';
-import _omit from 'lodash/omit';
+import _omit from 'lodash/omit.js';
 import { getItems } from '../utils/get-items';
 import { replaceItems } from '../utils/replace-items';
 
diff --git a/src/hooks/discard-query.ts b/src/hooks/discard-query.ts
@@ -1,5 +1,5 @@
 import type { Hook } from '@feathersjs/feathers';
-import _omit from 'lodash/omit';
+import _omit from 'lodash/omit.js';
 import { checkContext } from '../utils/check-context';
 
 /**
diff --git a/src/hooks/discard.ts b/src/hooks/discard.ts
@@ -1,5 +1,5 @@
 import type { Hook } from '@feathersjs/feathers';
-import _omit from 'lodash/omit';
+import _omit from 'lodash/omit.js';
 import { checkContextIf } from './check-context-if';
 import { getItems } from '../utils/get-items';
 import { replaceItems } from '../utils/replace-items';
diff --git a/src/hooks/keep-in-array.ts b/src/hooks/keep-in-array.ts
@@ -1,8 +1,8 @@
 import errors from '@feathersjs/errors';
 const { BadRequest } = errors;
-import _get from 'lodash/get';
-import _set from 'lodash/set';
-import _has from 'lodash/has';
+import _get from 'lodash/get.js';
+import _set from 'lodash/set.js';
+import _has from 'lodash/has.js';
 import { getItems } from '../utils/get-items';
 import type { Hook } from '@feathersjs/feathers';
 
diff --git a/src/hooks/keep-query-in-array.ts b/src/hooks/keep-query-in-array.ts
@@ -1,9 +1,9 @@
 import { checkContext } from '../utils/check-context';
 import errors from '@feathersjs/errors';
 const { BadRequest } = errors;
-import _get from 'lodash/get';
-import _set from 'lodash/set';
-import _has from 'lodash/has';
+import _get from 'lodash/get.js';
+import _set from 'lodash/set.js';
+import _has from 'lodash/has.js';
 import type { Hook } from '@feathersjs/feathers';
 
 /**
diff --git a/src/hooks/keep.ts b/src/hooks/keep.ts
@@ -1,6 +1,6 @@
-import _get from 'lodash/get';
-import _set from 'lodash/set';
-import _has from 'lodash/has';
+import _get from 'lodash/get.js';
+import _set from 'lodash/set.js';
+import _has from 'lodash/has.js';
 
 import { checkContextIf } from './check-context-if';
 import { getItems } from '../utils/get-items';
diff --git a/src/hooks/lower-case.ts b/src/hooks/lower-case.ts
@@ -1,4 +1,4 @@
-import _set from 'lodash/set';
+import _set from 'lodash/set.js';
 import errors from '@feathersjs/errors';
 const { BadRequest } = errors;
 
diff --git a/src/hooks/populate.ts b/src/hooks/populate.ts
@@ -1,5 +1,5 @@
-import _get from 'lodash/get';
-import _set from 'lodash/set';
+import _get from 'lodash/get.js';
+import _set from 'lodash/set.js';
 import errors from '@feathersjs/errors';
 const { BadRequest } = errors;
 
diff --git a/src/hooks/prevent-changes.ts b/src/hooks/prevent-changes.ts
@@ -1,5 +1,5 @@
-import _has from 'lodash/has';
-import _omit from 'lodash/omit';
+import _has from 'lodash/has.js';
+import _omit from 'lodash/omit.js';
 
 import { checkContext } from '../utils/check-context';
 import errors from '@feathersjs/errors';
diff --git a/src/hooks/required.ts b/src/hooks/required.ts
@@ -1,7 +1,7 @@
-import _get from 'lodash/get';
+import _get from 'lodash/get.js';
 import errors from '@feathersjs/errors';
 const { BadRequest } = errors;
-import _has from 'lodash/has';
+import _has from 'lodash/has.js';
 
 import { checkContext } from '../utils/check-context';
 import { getItems } from '../utils/get-items';
diff --git a/src/hooks/serialize.ts b/src/hooks/serialize.ts
@@ -1,6 +1,6 @@
-import _get from 'lodash/get';
-import _set from 'lodash/set';
-import _omit from 'lodash/omit';
+import _get from 'lodash/get.js';
+import _set from 'lodash/set.js';
+import _omit from 'lodash/omit.js';
 
 import { getItems } from '../utils/get-items';
 import { replaceItems } from '../utils/replace-items';
diff --git a/src/hooks/set-field.ts b/src/hooks/set-field.ts
@@ -1,6 +1,6 @@
-import _get from 'lodash/get';
-import _setWith from 'lodash/setWith';
-import _clone from 'lodash/clone';
+import _get from 'lodash/get.js';
+import _setWith from 'lodash/setWith.js';
+import _clone from 'lodash/clone.js';
 import _debug from 'debug';
 import { checkContext } from '../utils/check-context';
 import errors from '@feathersjs/errors';
diff --git a/src/hooks/set-slug.ts b/src/hooks/set-slug.ts
@@ -1,4 +1,4 @@
-import _set from 'lodash/set';
+import _set from 'lodash/set.js';
 import errors from '@feathersjs/errors';
 const { GeneralError } = errors;
 import type { Hook } from '@feathersjs/feathers';
diff --git a/src/utils/calling-params.ts b/src/utils/calling-params.ts
@@ -1,6 +1,6 @@
 import type { HookContext, Params } from '@feathersjs/feathers';
-import _get from 'lodash/get';
-import _set from 'lodash/set';
+import _get from 'lodash/get.js';
+import _set from 'lodash/set.js';
 import type { CallingParamsOptions, SyncContextFunction } from '../types';
 
 const stndAuthProps = ['provider', 'authenticated', 'user']; // feathers-authentication
diff --git a/test/hooks/populate-1deep-1child.test.ts b/test/hooks/populate-1deep-1child.test.ts
@@ -1,6 +1,6 @@
 
 import { assert } from 'chai';
-import _set from 'lodash/set';
+import _set from 'lodash/set.js';
 
 import configApp from '../helpers/config-app';
 import getInitDb from '../helpers/get-init-db';

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-import _pick from 'lodash/pick';`
	`1`	`+import _pick from 'lodash/pick.js';`
`2`	`2`
`3`	`3`	`export function pluck <T extends Record<string, any>> (`
`4`	`4`	`items: T,`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-import _set from 'lodash/set';`
	`1`	`+import _set from 'lodash/set.js';`
`2`	`2`
`3`	`3`	`export function setFields <T extends Record<string, any>> (`
`4`	`4`	`items: T \| T[],`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-import _get from 'lodash/get';`
	`1`	`+import _get from 'lodash/get.js';`
`2`	`2`
`3`	`3`	`export function transformItems <T extends Record<string, any>> (`
`4`	`4`	`items: T \| T[],`