fixed UniqueViolationError bug for mysql clients (#141)

* fixed UniqueViolationError bug when using mysql

* fixed a typo and added a test

* Update index.test.js

* Update error-handler.js

Co-authored-by: Dekel Barzilay <[email protected]>

Author: Tr3ffel

src/error-handler.js

@@ -39,11 +39,17 @@ export default function errorHandler (error) {
   } else if (error instanceof NotFoundError) {
     feathersError = new errors.NotFound(message);
   } else if (error instanceof UniqueViolationError) {
-    feathersError = new errors.Conflict(`${error.columns.join(', ')} must be unique`, {
-      columns: error.columns,
-      table: error.table,
-      constraint: error.constraint
-    });
+    if (error.client === 'mysql') {
+      feathersError = new errors.Conflict(error.nativeError.sqlMessage, {
+        constraint: error.constraint
+      });
+    } else {
+      feathersError = new errors.Conflict(`${error.columns.join(', ')} must be unique`, {
+        columns: error.columns,
+        table: error.table,
+        constraint: error.constraint
+      });
+    }
   } else if (error instanceof NotNullViolationError) {
     feathersError = new errors.BadRequest(`${error.column} must not be null`, {
       column: error.column,

test/index.test.js

@@ -373,6 +373,18 @@ describe('Feathers Objection Service', () => {
         expect(errorHandler.bind(null, error)).to.throw(errors.Conflict);
       });
 
+      it('UniqueViolation error mysql', () => {
+        const error = new UniqueViolationError({
+          nativeError: { sqlMessage: 'test' },
+          client: 'mysql',
+          table: undefined,
+          columns: undefined,
+          constraint: 'test_constraint'
+        });
+
+        expect(errorHandler.bind(null, error)).to.throw(error.Conflict, 'test');
+      });
+
       it('ConstraintViolation error', () => {
         const error = new ConstraintViolationError({
           nativeError: new Error(),