Changed create to insert & get by returned row fields by default (#90)

* Changed create to insert & get by returned row fields by default

* Added test on create with ID when ID gets overridden in model

Co-authored-by: Dekel Barzilay <[email protected]>

Author: dekelev

src/index.js

@@ -476,18 +476,20 @@ class Service extends AdapterService {
         .then(row => {
           if (params.query && params.query.$noSelect) { return data; }
 
-          let id = null;
+          let id;
 
           if (Array.isArray(this.id)) {
             id = [];
 
             for (const idKey of this.id) {
-              id.push(typeof data[idKey] !== 'undefined' ? data[idKey] : row[idKey]);
+              id.push(row && row[idKey] ? row[idKey] : data[idKey]);
             }
           } else {
-            id = typeof data[this.id] !== 'undefined' ? data[this.id] : row[this.id];
+            id = row && row[this.id] ? row[this.id] : data[this.id];
           }
 
+          if (!id || (Array.isArray(id) && !id.length)) { return data; }
+
           return this._get(id, params);
         })
         .catch(errorHandler);

test/company.js

@@ -81,4 +81,8 @@ export default class Company extends Model {
       }
     }
   }
+
+  $beforeInsert () {
+    if (this.id) { this.id = 99; }
+  }
 }

test/index.test.js

@@ -1768,4 +1768,21 @@ describe('Feathers Objection Service', () => {
       });
     });
   });
+
+  describe('Create with ID', () => {
+    beforeEach(async () => {
+      await companies.create({ name: 'Apple' });
+    });
+
+    afterEach(async () => {
+      await companies.remove(null);
+    });
+
+    it('create with id when id is overridden in model', () => {
+      return companies.create({ id: 1, name: 'Google' }).then(data => {
+        expect(data).to.be.ok;
+        expect(data.name).to.be.equal('Google');
+      });
+    });
+  });
 });