Skip to content

Commit 069fe39

Browse files
committed
fix #58 empty error state on action service failure
If an action service method call resulted in an error an empty object is committed to the `set*Error` mutation rather than the error details. This was an unintended result of `Object.assign({}, error)` which always returned an empty object. The mutation is responsible for serializing the error, via the ‘serialize-error’ package, and updating the `errorOn*` state so passing the rejected error object as the mutation argument should work.
1 parent 6a23c35 commit 069fe39

File tree

2 files changed

+430
-279
lines changed

2 files changed

+430
-279
lines changed

src/service-module/actions.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ export default function makeServiceActions (service) {
1717
return response
1818
}
1919
const handleError = error => {
20-
commit('setFindError', Object.assign({}, error))
20+
commit('setFindError', error)
2121
commit('unsetFindPending')
2222
return Promise.reject(error)
2323
}
@@ -57,7 +57,7 @@ export default function makeServiceActions (service) {
5757
return item
5858
})
5959
.catch(error => {
60-
commit('setGetError', Object.assign({}, error))
60+
commit('setGetError', error)
6161
commit('unsetGetPending')
6262
return Promise.reject(error)
6363
})
@@ -74,7 +74,7 @@ export default function makeServiceActions (service) {
7474
return item
7575
})
7676
.catch(error => {
77-
commit('setCreateError', Object.assign({}, error))
77+
commit('setCreateError', error)
7878
commit('unsetCreatePending')
7979
return Promise.reject(error)
8080
})
@@ -90,7 +90,7 @@ export default function makeServiceActions (service) {
9090
return item
9191
})
9292
.catch(error => {
93-
commit('setUpdateError', Object.assign({}, error))
93+
commit('setUpdateError', error)
9494
commit('unsetUpdatePending')
9595
return Promise.reject(error)
9696
})
@@ -106,7 +106,7 @@ export default function makeServiceActions (service) {
106106
return item
107107
})
108108
.catch(error => {
109-
commit('setPatchError', Object.assign({}, error))
109+
commit('setPatchError', error)
110110
commit('unsetPatchPending')
111111
return Promise.reject(error)
112112
})
@@ -122,7 +122,7 @@ export default function makeServiceActions (service) {
122122
return item
123123
})
124124
.catch(error => {
125-
commit('setRemoveError', Object.assign({}, error))
125+
commit('setRemoveError', error)
126126
commit('unsetRemovePending')
127127
return Promise.reject(error)
128128
})

0 commit comments

Comments
 (0)