Skip to content

Commit 08cd393

Browse files
committed
fix: tree shaking by using specific lodash modules
1 parent aa8ddd7 commit 08cd393

12 files changed

+26
-18
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@
110110
"fast-json-stable-stringify": "^2.0.0",
111111
"inflection": "^1.12.0",
112112
"jwt-decode": "^2.2.0",
113-
"lodash": "^4.17.11",
113+
"lodash": "^4.17.15",
114114
"lodash.isobject": "^3.0.2",
115115
"lodash.isplainobject": "^4.0.6",
116116
"lodash.merge": "^4.6.1",

src/make-find-mixin.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,8 @@ import {
1010
getQueryInfo,
1111
getItemsFromQueryInfo
1212
} from './utils'
13-
import { get as _get, debounce } from 'lodash'
13+
import debounce from 'lodash/debounce'
14+
import _get from 'lodash/get'
1415

1516
export default function makeFindMixin(options) {
1617
const {

src/service-module/global-clients.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ eslint
33
@typescript-eslint/explicit-function-return-type: 0,
44
@typescript-eslint/no-explicit-any: 0
55
*/
6-
import { get as _get } from 'lodash'
6+
import _get from 'lodash/get'
77

88
/**
99
* A global object that holds references to all Model Classes in the application.

src/service-module/make-model.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,8 @@ eslint
66
import { FeathersVuexOptions } from './types'
77
import { globalModels, prepareAddModel } from './global-models'
88
import { mergeWithAccessors, checkNamespace, getId } from '../utils'
9-
import { get as _get, merge as _merge } from 'lodash'
9+
import _merge from 'lodash/merge'
10+
import _get from 'lodash/get'
1011

1112
// A hack to prevent error with this.constructor.preferUpdate
1213
interface Function {

src/service-module/make-service-plugin.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import { FeathersVuexOptions, MakeServicePluginOptions } from './types'
77
import makeServiceModule from './make-service-module'
88
import { globalModels, prepareAddModel } from './global-models'
99
import { makeNamespace, getServicePath, assignIfNotPresent } from '../utils'
10-
import { get as _get } from 'lodash'
10+
import _get from 'lodash/get'
1111

1212
const defaults = {
1313
namespace: '', // The namespace for the Vuex module. Will generally be derived from the service.path, service.name, when available. Otherwise, it must be provided here, explicitly.

src/service-module/service-module.getters.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,9 @@ eslint
66
import sift from 'sift'
77
import commons from '@feathersjs/commons'
88
import dbCommons from '@feathersjs/adapter-commons'
9-
import { omit as _omit } from 'lodash'
109
import { globalModels as models } from './global-models'
11-
import { get as _get } from 'lodash'
10+
import _get from 'lodash/get'
11+
import _omit from 'lodash/omit'
1212

1313
const { _ } = commons
1414
const { filterQuery, sorter, select } = dbCommons

src/service-module/service-module.mutations.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,9 @@ import {
1313
getQueryInfo
1414
} from '../utils'
1515
import { globalModels as models } from './global-models'
16-
import { get as _get, isObject as _isObject, omit as _omit } from 'lodash'
16+
import _omit from 'lodash/omit'
17+
import _get from 'lodash/get'
18+
import _isObject from 'lodash/isObject'
1719

1820
export default function makeServiceMutations() {
1921
function addItems(state, items) {

src/service-module/service-module.state.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ eslint
44
@typescript-eslint/no-explicit-any: 0
55
*/
66

7-
import { omit as _omit } from 'lodash'
7+
import _omit from 'lodash/omit'
88

99
export default function makeDefaultState(servicePath, options) {
1010
const nonStateProps = [

src/utils.ts

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,11 @@ import decode from 'jwt-decode'
77
import inflection from 'inflection'
88
import Vue from 'vue'
99
import fastCopy from 'fast-copy'
10-
import {
11-
isPlainObject as _isPlainObject,
12-
isObject as _isObject,
13-
trim as _trim,
14-
omit as _omit,
15-
get as _get
16-
} from 'lodash'
10+
import _isPlainObject from 'lodash/isPlainObject'
11+
import _isObject from 'lodash/isObject'
12+
import _trim from 'lodash/trim'
13+
import _omit from 'lodash/omit'
14+
import _get from 'lodash/get'
1715
import ObjectID from 'bson-objectid'
1816
import { globalModels as models } from './service-module/global-models'
1917
import stringify from 'fast-json-stable-stringify'

test/service-module/make-service-plugin.test.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,8 @@ import { clearModels } from '../../src/service-module/global-models'
1010
import { clients } from '../../src/service-module/global-clients'
1111
import { feathersRestClient as feathers } from '../../test/fixtures/feathers-client'
1212
import feathersVuex from '../../src/index'
13-
import { pick as _pick, omit as _omit } from 'lodash'
13+
import _pick from 'lodash/pick'
14+
import _omit from 'lodash/omit'
1415

1516
Vue.use(Vuex)
1617

0 commit comments

Comments
 (0)