Update tests

Author: marsimeau

test/auth-module/actions.test.js

@@ -23,19 +23,19 @@ describe('Auth Module - Actions', () => {
     const authState = store.state.auth
     const actions = mapActions('auth', ['authenticate'])
 
-    assert(authState.accessToken === undefined)
-    assert(authState.errorOnAuthenticate === undefined)
-    assert(authState.errorOnLogout === undefined)
+    assert(authState.accessToken === null)
+    assert(authState.errorOnAuthenticate === null)
+    assert(authState.errorOnLogout === null)
     assert(authState.isAuthenticatePending === false)
     assert(authState.isLogoutPending === false)
-    assert(authState.payload === undefined)
+    assert(authState.payload === null)
 
     const request = {strategy: 'local', email: 'test', password: 'test'}
     actions.authenticate.call({$store: store}, request)
     .then(response => {
       assert(authState.accessToken === response.accessToken)
-      assert(authState.errorOnAuthenticate === undefined)
-      assert(authState.errorOnLogout === undefined)
+      assert(authState.errorOnAuthenticate === null)
+      assert(authState.errorOnLogout === null)
       assert(authState.isAuthenticatePending === false)
       assert(authState.isLogoutPending === false)
       let expectedPayload = {
@@ -47,12 +47,12 @@ describe('Auth Module - Actions', () => {
     })
 
     // Make sure proper state changes occurred before response
-    assert(authState.accessToken === undefined)
-    assert(authState.errorOnAuthenticate === undefined)
-    assert(authState.errorOnLogout === undefined)
+    assert(authState.accessToken === null)
+    assert(authState.errorOnAuthenticate === null)
+    assert(authState.errorOnLogout === null)
     assert(authState.isAuthenticatePending === true)
     assert(authState.isLogoutPending === false)
-    assert(authState.payload === undefined)
+    assert(authState.payload === null)
   })
 
   it('Logout', (done) => {
@@ -73,12 +73,12 @@ describe('Auth Module - Actions', () => {
     .then(authResponse => {
       actions.logout.call({$store: store})
       .then(response => {
-        assert(authState.accessToken === undefined)
-        assert(authState.errorOnAuthenticate === undefined)
-        assert(authState.errorOnLogout === undefined)
+        assert(authState.accessToken === null)
+        assert(authState.errorOnAuthenticate === null)
+        assert(authState.errorOnLogout === null)
         assert(authState.isAuthenticatePending === false)
         assert(authState.isLogoutPending === false)
-        assert(authState.payload === undefined)
+        assert(authState.payload === null)
         done()
       })
     })
@@ -101,7 +101,7 @@ describe('Auth Module - Actions', () => {
     const authState = store.state.auth
     const actions = mapActions('auth', ['authenticate'])
 
-    assert(authState.user === undefined)
+    assert(authState.user === null)
 
     const request = {strategy: 'local', email: 'test', password: 'test'}
     actions.authenticate.call({$store: store}, request)

test/auth-module/auth-module.test.js

@@ -15,12 +15,13 @@ describe('Auth Module', () => {
       })
       const authState = store.state.auth
       const expectedAuthState = {
-        accessToken: undefined,
-        errorOnAuthenticate: undefined,
-        errorOnLogout: undefined,
+        accessToken: null,
+        errorOnAuthenticate: null,
+        errorOnLogout: null,
         isAuthenticatePending: false,
         isLogoutPending: false,
-        payload: undefined
+        payload: null,
+        user: null
       }
 
       assert.deepEqual(authState, expectedAuthState, 'has the default state')

test/auth.test.js

@@ -88,7 +88,7 @@ describe('feathers-vuex:auth - Reducer', () => {
       isPending: false,
       isError: false,
       isSignedIn: false,
-      accessToken: undefined,
+      accessToken: null,
       error: undefined
     }
     const newState = reducer(state, {})
@@ -108,7 +108,7 @@ describe('feathers-vuex:auth - Reducer', () => {
       isPending: true,
       isError: false,
       isSignedIn: false,
-      accessToken: undefined,
+      accessToken: null,
       error: undefined
     }
     const newState = reducer(state, action)
@@ -144,7 +144,7 @@ describe('feathers-vuex:auth - Reducer', () => {
       isPending: false,
       isError: true,
       isSignedIn: false,
-      accessToken: undefined,
+      accessToken: null,
       error
     }
     const newState = reducer(state, action)
@@ -160,7 +160,7 @@ describe('feathers-vuex:auth - Reducer', () => {
       isPending: false,
       isError: false,
       isSignedIn: false,
-      accessToken: undefined,
+      accessToken: null,
       error: undefined
     }
     const newState = reducer(state, action)

test/service-module/actions.test.js

@@ -70,14 +70,14 @@ describe('Service Module - Actions', () => {
         const actions = mapActions('todos', ['find'])
 
         assert(todoState.ids.length === 0, 'no ids before find')
-        assert(todoState.errorOnFind === undefined, 'no error before find')
+        assert(todoState.errorOnFind === null, 'no error before find')
         assert(todoState.isFindPending === false, 'isFindPending is false')
         assert(todoState.idField === 'id', 'idField is `id`')
 
         actions.find.call({$store: store}, {})
           .then(response => {
             assert(todoState.ids.length === 10, 'three ids populated')
-            assert(todoState.errorOnFind === undefined, 'errorOnFind still undefined')
+            assert(todoState.errorOnFind === null, 'errorOnFind still null')
             assert(todoState.isFindPending === false, 'isFindPending is false')
             let expectedKeyedById = makeStore()
             assert.deepEqual(todoState.keyedById, expectedKeyedById, 'keyedById matches')
@@ -86,7 +86,7 @@ describe('Service Module - Actions', () => {
 
         // Make sure proper state changes occurred before response
         assert(todoState.ids.length === 0)
-        assert(todoState.errorOnFind === undefined)
+        assert(todoState.errorOnFind === null)
         assert(todoState.isFindPending === true)
         assert.deepEqual(todoState.keyedById, {})
       })
@@ -280,7 +280,7 @@ describe('Service Module - Actions', () => {
 
       // Make sure proper state changes occurred before response
       assert(brokenState.ids.length === 0)
-      assert(brokenState.errorOnFind === undefined)
+      assert(brokenState.errorOnFind === null)
       assert(brokenState.isFindPending === true)
     })
   })
@@ -294,14 +294,14 @@ describe('Service Module - Actions', () => {
       const actions = mapActions('todos', ['get'])
 
       assert(todoState.ids.length === 0)
-      assert(todoState.errorOnGet === undefined)
+      assert(todoState.errorOnGet === null)
       assert(todoState.isGetPending === false)
       assert(todoState.idField === 'id')
 
       actions.get.call({$store: store}, 0)
         .then(response => {
           assert(todoState.ids.length === 1, 'only one item is in the store')
-          assert(todoState.errorOnGet === undefined, 'there was no errorOnGet')
+          assert(todoState.errorOnGet === null, 'there was no errorOnGet')
           assert(todoState.isGetPending === false, 'isGetPending is set to false')
           let expectedKeyedById = {
             0: { id: 0, description: 'Do the first' }
@@ -323,7 +323,7 @@ describe('Service Module - Actions', () => {
 
       // Make sure proper state changes occurred before response
       assert(todoState.ids.length === 0)
-      assert(todoState.errorOnCreate === undefined)
+      assert(todoState.errorOnCreate === null)
       assert(todoState.isGetPending === true)
       assert.deepEqual(todoState.keyedById, {})
     })
@@ -343,7 +343,7 @@ describe('Service Module - Actions', () => {
 
       // Make sure proper state changes occurred before response
       assert(brokenState.ids.length === 0)
-      assert(brokenState.errorOnGet === undefined)
+      assert(brokenState.errorOnGet === null)
       assert(brokenState.isGetPending === true)
     })
   })
@@ -359,15 +359,15 @@ describe('Service Module - Actions', () => {
       actions.create.call({$store: store}, {description: 'Do the second'})
         .then(response => {
           assert(todoState.ids.length === 1)
-          assert(todoState.errorOnCreate === undefined)
+          assert(todoState.errorOnCreate === null)
           assert(todoState.isCreatePending === false)
           assert.deepEqual(todoState.keyedById[response.id], response)
           done()
         })
 
       // Make sure proper state changes occurred before response
       assert(todoState.ids.length === 0)
-      assert(todoState.errorOnCreate === undefined)
+      assert(todoState.errorOnCreate === null)
       assert(todoState.isCreatePending === true)
       assert(todoState.idField === 'id')
       assert.deepEqual(todoState.keyedById, {})
@@ -388,7 +388,7 @@ describe('Service Module - Actions', () => {
 
       // Make sure proper state changes occurred before response
       assert(brokenState.ids.length === 0)
-      assert(brokenState.errorOnCreate === undefined)
+      assert(brokenState.errorOnCreate === null)
       assert(brokenState.isCreatePending === true)
     })
   })
@@ -406,15 +406,15 @@ describe('Service Module - Actions', () => {
           actions.update.call({$store: store}, [0, {id: 0, description: 'Do da dishuz'}])
           .then(responseFromUpdate => {
             assert(todoState.ids.length === 1)
-            assert(todoState.errorOnUpdate === undefined)
+            assert(todoState.errorOnUpdate === null)
             assert(todoState.isUpdatePending === false)
             assert.deepEqual(todoState.keyedById[responseFromUpdate.id], responseFromUpdate)
             done()
           })
 
           // Make sure proper state changes occurred before response
           assert(todoState.ids.length === 1)
-          assert(todoState.errorOnUpdate === undefined)
+          assert(todoState.errorOnUpdate === null)
           assert(todoState.isUpdatePending === true)
           assert(todoState.idField === 'id')
         })
@@ -438,7 +438,7 @@ describe('Service Module - Actions', () => {
 
       // Make sure proper state changes occurred before response
       assert(brokenState.ids.length === 0)
-      assert(brokenState.errorOnUpdate === undefined)
+      assert(brokenState.errorOnUpdate === null)
       assert(brokenState.isUpdatePending === true)
     })
   })
@@ -456,15 +456,15 @@ describe('Service Module - Actions', () => {
           actions.patch.call({$store: store}, [0, {description: 'Write a Vue app'}])
           .then(responseFromPatch => {
             assert(todoState.ids.length === 1)
-            assert(todoState.errorOnPatch === undefined)
+            assert(todoState.errorOnPatch === null)
             assert(todoState.isPatchPending === false)
             assert.deepEqual(todoState.keyedById[responseFromPatch.id], responseFromPatch)
             done()
           })
 
           // Make sure proper state changes occurred before response
           assert(todoState.ids.length === 1)
-          assert(todoState.errorOnPatch === undefined)
+          assert(todoState.errorOnPatch === null)
           assert(todoState.isPatchPending === true)
           assert(todoState.idField === 'id')
         })
@@ -485,7 +485,7 @@ describe('Service Module - Actions', () => {
 
       // Make sure proper state changes occurred before response
       assert(brokenState.ids.length === 0)
-      assert(brokenState.errorOnPatch === undefined)
+      assert(brokenState.errorOnPatch === null)
       assert(brokenState.isPatchPending === true)
     })
   })
@@ -503,15 +503,15 @@ describe('Service Module - Actions', () => {
           actions.remove.call({$store: store}, 0)
           .then(responseFromRemove => {
             assert(todoState.ids.length === 0)
-            assert(todoState.errorOnRemove === undefined)
+            assert(todoState.errorOnRemove === null)
             assert(todoState.isRemovePending === false)
             assert.deepEqual(todoState.keyedById, {})
             done()
           })
 
           // Make sure proper state changes occurred before response
           assert(todoState.ids.length === 1)
-          assert(todoState.errorOnRemove === undefined)
+          assert(todoState.errorOnRemove === null)
           assert(todoState.isRemovePending === true)
           assert(todoState.idField === 'id')
         })
@@ -532,7 +532,7 @@ describe('Service Module - Actions', () => {
 
       // Make sure proper state changes occurred before response
       assert(brokenState.ids.length === 0)
-      assert(brokenState.errorOnRemove === undefined)
+      assert(brokenState.errorOnRemove === null)
       assert(brokenState.isRemovePending === true)
     })
   })

test/service-module/mutations.test.js

@@ -271,8 +271,8 @@ describe('Service Module - Mutations', function () {
     setCurrent(state, item2)
     clearCurrent(state)
 
-    assert(state.currentId === undefined)
-    assert(state.copy === undefined)
+    assert(state.currentId === null)
+    assert(state.copy === null)
   })
 
   it('copy works', function () {

test/service-module/service-module.test.js

@@ -105,14 +105,14 @@ describe('Service Module', () => {
       const todoState = store.state.todos
       const expectedState = {
         autoRemove: false,
-        copy: undefined,
-        currentId: undefined,
-        errorOnCreate: undefined,
-        errorOnGet: undefined,
-        errorOnPatch: undefined,
-        errorOnRemove: undefined,
-        errorOnUpdate: undefined,
-        errorOnFind: undefined,
+        copy: null,
+        currentId: null,
+        errorOnCreate: null,
+        errorOnGet: null,
+        errorOnPatch: null,
+        errorOnRemove: null,
+        errorOnUpdate: null,
+        errorOnFind: null,
         idField: 'id',
         ids: [],
         isFindPending: false,