find getter: take union by ID instead of concat with tempsById

Author: hamiltoes

src/service-module/service-module.getters.ts

@@ -9,6 +9,7 @@ import { filterQuery, sorter, select } from '@feathersjs/adapter-commons'
 import { globalModels as models } from './global-models'
 import _get from 'lodash/get'
 import _omit from 'lodash/omit'
+import _unionBy from 'lodash/unionBy'
 
 const FILTERS = ['$sort', '$limit', '$skip', '$select']
 const OPERATORS = ['$in', '$nin', '$lt', '$lte', '$gt', '$gte', '$ne', '$or']
@@ -26,7 +27,7 @@ export default function makeServiceGetters() {
       // Set params.temps to true to include the tempsById records
       params.temps = params.hasOwnProperty('temps') ? params.temps : false
 
-      const { paramsForServer, whitelist } = state
+      const { paramsForServer, whitelist, idField, tempIdField } = state
       const q = _omit(params.query || {}, paramsForServer)
       const customOperators = Object.keys(q).filter(
         k => k[0] === '$' && !defaultOps.includes(k)
@@ -39,7 +40,11 @@ export default function makeServiceGetters() {
       let values = _.values(state.keyedById)
 
       if (params.temps) {
-        values = values.concat(_.values(state.tempsById))
+        values = _unionBy(
+          values,
+          _.values(state.tempsById),
+          i => i[tempIdField] || i[idField]
+        )
       }
 
       values = values.filter(sift(query))