Skip to content

Commit 59477cd

Browse files
committed
fix: ModelInstanceClone: hide clone() and only show __isClone: true
1 parent bc1e7a1 commit 59477cd

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

src/service-module/make-base-model.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ export default function makeBaseModel(options: FeathersVuexOptions) {
9595
} = {}
9696

9797
public __id: string
98-
public __isClone: boolean
98+
public __isClone: true
9999
public data: Record<string, any>
100100

101101
public static merge = mergeWithAccessors

src/service-module/types.ts

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -291,10 +291,6 @@ export interface ModelInstance<D extends {} = AnyData> {
291291
* model is temporary?
292292
*/
293293
readonly __isTemp?: boolean
294-
/**
295-
* model is a clone?
296-
*/
297-
readonly __isClone?: boolean
298294

299295
/**
300296
* Creates a deep copy of the record and stores it on
@@ -346,7 +342,12 @@ export interface ModelInstance<D extends {} = AnyData> {
346342

347343
/** Model instance clone interface */
348344
export interface ModelInstanceClone<D extends {} = AnyData>
349-
extends ModelInstance<D> {
345+
extends Omit<ModelInstance<D>, 'clone'> {
346+
/**
347+
* model is a clone?
348+
*/
349+
readonly __isClone: true
350+
350351
/**
351352
* Commit changes from clone to original
352353
*/

0 commit comments

Comments
 (0)