remove unnecessary if statement in Model.getFromStore

hamiltoes · hamiltoes · commit 5bab70259bdc · 2020-04-13T13:56:00.000+12:00
diff --git a/src/service-module/make-base-model.ts b/src/service-module/make-base-model.ts
@@ -185,11 +185,7 @@ export default function makeBaseModel(options: FeathersVuexOptions) {
     }
 
     public static getFromStore(id, params?) {
-      if (params) {
-        return this._getters('get', id, params)
-      } else {
-        return this._getters('get', id)
-      }
+      return this._getters('get', id, params)
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -185,11 +185,7 @@ export default function makeBaseModel(options: FeathersVuexOptions) {`
`185`	`185`	`}`
`186`	`186`
`187`	`187`	`public static getFromStore(id, params?) {`
`188`		`- if (params) {`
`189`		`- return this._getters('get', id, params)`
`190`		`- } else {`
`191`		`- return this._getters('get', id)`
`192`		`- }`
	`188`	`+ return this._getters('get', id, params)`
`193`	`189`	`}`
`194`	`190`
`195`	`191`	`/**`