Merge pull request #421 from mrfrase3/patch-1

Allow simple data modification in clone

Author: marshallswain

src/service-module/make-base-model.ts

@@ -254,28 +254,28 @@ export default function makeBaseModel(options: FeathersVuexOptions) {
     /**
      * clone the current record using the `createCopy` mutation
      */
-    public clone() {
+    public clone(data) {
       const { idField, tempIdField } = this.constructor as typeof BaseModel
       if (this.__isClone) {
         throw new Error('You cannot clone a copy')
       }
       const id =
         getId(this, idField) != null ? getId(this, idField) : this[tempIdField]
-      return this._clone(id)
+      return this._clone(id, data)
     }
 
-    private _clone(id) {
+    private _clone(id, data = {}) {
       const { store, namespace, _commit, _getters } = this
         .constructor as typeof BaseModel
       const { keepCopiesInStore } = store.state[namespace]
 
       _commit.call(this.constructor, `createCopy`, id)
 
       if (keepCopiesInStore) {
-        return _getters.call(this.constructor, 'getCopyById', id)
+        return Object.assign(_getters.call(this.constructor, 'getCopyById', id), data)
       } else {
         // const { copiesById } = this.constructor as typeof BaseModel
-        return (this.constructor as typeof BaseModel).copiesById[id]
+        return Object.assign((this.constructor as typeof BaseModel).copiesById[id], data)
       }
     }
     /**

test/service-module/service-module.test.ts

@@ -387,6 +387,25 @@ describe('Service Module', function() {
       )
     })
 
+    it(`allows shallow assign of data when cloning`, function() {
+      const { serviceTodo, owners } = this
+      let serviceTodoClone = serviceTodo.clone({ isComplete: !serviceTodo.isComplete })
+
+      assert.equal(
+        !serviceTodo.isComplete,
+        serviceTodoClone.isComplete,
+        'clone value has changed'
+      )
+
+      serviceTodoClone.commit()
+
+      assert.equal(
+        serviceTodo.isComplete,
+        true,
+        'value has changed after commit'
+      )
+    })
+
     it('allows reseting copy changes back to match the original', function() {
       const { serviceTodo } = this
       let serviceTodoClone = serviceTodo.clone()