Lint cleanup

Author: marshallswain

src/make-find-mixin.ts

@@ -82,7 +82,7 @@ export default function makeFindMixin(options) {
       return providedParams
     } else {
       // Returning null fetchParams allows the query to be skipped.
-      return (fetchParams || fetchParams === null) ? fetchParams : params
+      return fetchParams || fetchParams === null ? fetchParams : params
     }
   }
 
@@ -100,7 +100,10 @@ export default function makeFindMixin(options) {
 
         // If both queries are provided, we're not using fall-through pagination.
         // User can pass `paginate: false` to force old behavior with a single query.
-        if (this[FETCH_PARAMS] && this[PARAMS] || this[PARAMS] && this[PARAMS].paginate === false) {
+        if (
+          (this[FETCH_PARAMS] && this[PARAMS]) ||
+          (this[PARAMS] && this[PARAMS].paginate === false)
+        ) {
           return this.$store.getters[`${serviceName}/find`](this[PARAMS]).data
         }
 
@@ -113,7 +116,11 @@ export default function makeFindMixin(options) {
           const pagination = this[PAGINATION][params.qid || this[QID]] || {}
           const response = skip != null && limit != null ? { limit, skip } : {}
           const queryInfo = getQueryInfo(params, response)
-          const items = getItemsFromQueryInfo(pagination, queryInfo, serviceState.keyedById)
+          const items = getItemsFromQueryInfo(
+            pagination,
+            queryInfo,
+            serviceState.keyedById
+          )
 
           if (items && items.length) {
             return items
@@ -149,9 +156,15 @@ export default function makeFindMixin(options) {
           const cachedDebounceFunction = this[`${FIND_ACTION}Debounced`]
           const mostRecentTime = this[`${FIND_ACTION}MostRecentDebounceTime`]
 
-          if (!cachedDebounceFunction || mostRecentTime != paramsToUse.debounce) {
+          if (
+            !cachedDebounceFunction ||
+            mostRecentTime != paramsToUse.debounce
+          ) {
             this[`${FIND_ACTION}MostRecentDebounceTime`] = paramsToUse.debounce
-            this[`${FIND_ACTION}Debounced`] = debounce(this[FIND_ACTION], paramsToUse.debounce)
+            this[`${FIND_ACTION}Debounced`] = debounce(
+              this[FIND_ACTION],
+              paramsToUse.debounce
+            )
           }
           return this[`${FIND_ACTION}Debounced`](paramsToUse)
         } else {
@@ -167,9 +180,10 @@ export default function makeFindMixin(options) {
         })
 
         if (!this[LOCAL]) {
-          const shouldExecuteQuery = typeof this[QUERY_WHEN] === 'function'
-            ? this[QUERY_WHEN](paramsToUse)
-            : this[QUERY_WHEN]
+          const shouldExecuteQuery =
+            typeof this[QUERY_WHEN] === 'function'
+              ? this[QUERY_WHEN](paramsToUse)
+              : this[QUERY_WHEN]
 
           if (shouldExecuteQuery) {
             if (paramsToUse) {
@@ -212,7 +226,8 @@ export default function makeFindMixin(options) {
         const pagination = this[PAGINATION]
         const { qid, queryId, pageId } = getQueryInfo(params)
         const queryInfo = _get(pagination, `[${qid}][${queryId}]`) || {}
-        const pageInfo = _get(pagination, `[${qid}][${queryId}][${pageId}]`) || {}
+        const pageInfo =
+          _get(pagination, `[${qid}][${queryId}][${pageId}]`) || {}
 
         return { queryInfo, pageInfo }
       }

src/service-module/make-model.ts

@@ -386,7 +386,7 @@ export default function makeModel(options: FeathersVuexOptions) {
       return _merge({}, this)
     }
   }
-  for (var n in EventEmitter.prototype) {
+  for (const n in EventEmitter.prototype) {
     BaseModel[n] = EventEmitter.prototype[n]
   }
 

src/utils.ts

@@ -105,10 +105,10 @@ export function readCookie(cookies, name) {
   if (!cookies) {
     return undefined
   }
-  var nameEQ = name + '='
-  var ca = cookies.split(';')
-  for (var i = 0; i < ca.length; i++) {
-    var c = ca[i]
+  const nameEQ = name + '='
+  const ca = cookies.split(';')
+  for (let i = 0; i < ca.length; i++) {
+    let c = ca[i]
     while (c.charAt(0) === ' ') {
       c = c.substring(1, c.length)
     }
@@ -142,7 +142,7 @@ const authDefaults = {
 export function getValidPayloadFromToken(token) {
   if (token) {
     try {
-      var payload = decode(token)
+      const payload = decode(token)
       return payloadIsValid(payload) ? payload : undefined
     } catch (error) {
       return undefined
@@ -240,7 +240,7 @@ export function getModelName(Model) {
 
 export function registerModel(Model, globalModels, apiPrefix, servicePath) {
   const modelName = getModelName(Model)
-  let path = apiPrefix ? `${apiPrefix}.${modelName}` : modelName
+  const path = apiPrefix ? `${apiPrefix}.${modelName}` : modelName
 
   setByDot(globalModels, path, Model)
   globalModels.byServicePath[servicePath] = Model
@@ -284,7 +284,8 @@ export function updateOriginal(original, newData) {
       // If the old prop is null or undefined, and the new prop is neither
     } else if (
       (oldProp === null || oldProp === undefined) &&
-      (newProp !== null && newProp !== undefined)
+      newProp !== null &&
+      newProp !== undefined
     ) {
       shouldCopyProp = true
       // If both old and new are arrays
@@ -310,7 +311,10 @@ export function updateOriginal(original, newData) {
   })
 }
 
-export function getQueryInfo(params: Params = {}, response: Partial<Pick<Paginated<any>, 'limit' | 'skip'>> = {}) {
+export function getQueryInfo(
+  params: Params = {},
+  response: Partial<Pick<Paginated<any>, 'limit' | 'skip'>> = {}
+) {
   const query = params.query || {}
   const qid: string = params.qid || 'default'
   const $limit =
@@ -369,9 +373,7 @@ export function makeNamespace(namespace, servicePath, nameStyle) {
 export function getServicePath(service: Service<any>, Model: any) {
   if (!service.name && !service.path && !Model.servicePath) {
     throw new Error(
-      `Service for model named ${
-        Model.name
-      } is missing a path or name property. The feathers adapter needs to be updated with a PR to expose this property. You can work around this by adding a static servicePath =  passing a 'servicePath' attribute in the options: makeServicePlugin({servicePath: '/path/to/my/service'})`
+      `Service for model named ${Model.name} is missing a path or name property. The feathers adapter needs to be updated with a PR to expose this property. You can work around this by adding a static servicePath =  passing a 'servicePath' attribute in the options: makeServicePlugin({servicePath: '/path/to/my/service'})`
     )
   }
 
@@ -380,7 +382,7 @@ export function getServicePath(service: Service<any>, Model: any) {
 
 export function randomString(length) {
   let text = ''
-  let possible =
+  const possible =
     'ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789'
 
   for (let i = 0; i < length; i++) {
@@ -413,8 +415,8 @@ export function mergeWithAccessors(
 ) {
   const sourceProps = Object.getOwnPropertyNames(source)
   const destProps = Object.getOwnPropertyNames(dest)
-  let sourceIsVueObservable = sourceProps.includes('__ob__')
-  let destIsVueObservable = destProps.includes('__ob__')
+  const sourceIsVueObservable = sourceProps.includes('__ob__')
+  const destIsVueObservable = destProps.includes('__ob__')
   sourceProps.forEach(key => {
     const sourceDesc = Object.getOwnPropertyDescriptor(source, key)
     const destDesc = Object.getOwnPropertyDescriptor(dest, key)
@@ -505,7 +507,7 @@ export function checkNamespace(namespace, item, debug) {
 }
 
 export function assignIfNotPresent(Model, props): void {
-  for (let key in props) {
+  for (const key in props) {
     if (!Model.hasOwnProperty(key)) {
       Model[key] = props[key]
     }

test/make-find-mixin.test.ts

@@ -21,18 +21,16 @@ function makeContext() {
 
   class FindModel extends BaseModel {
     public static modelName = 'FindModel'
-    public static test: boolean = true
+    public static test = true
   }
 
   return { FindModel, BaseModel, makeServicePlugin }
 }
 
-// @ts-ignore
 Vue.use(Vuex)
-// @ts-ignore
 Vue.use(FeathersVuex)
 
-describe('Find Mixin', function () {
+describe('Find Mixin', function() {
   const { makeServicePlugin, FindModel } = makeContext()
   const serviceName = 'todos'
   const store = new Vuex.Store({
@@ -44,7 +42,7 @@ describe('Find Mixin', function () {
     ]
   })
 
-  it('correctly forms mixin data', function () {
+  it('correctly forms mixin data', function() {
     const todosMixin = makeFindMixin({ service: 'todos' })
 
     interface TodosComponent {
@@ -75,7 +73,10 @@ describe('Find Mixin', function () {
     )
     assert(vm.todosServiceName === 'todos', 'service name was correct')
     assert(vm.isFindTodosPending === false, 'loading boolean is in place')
-    assert(vm.haveTodosBeenRequestedOnce === false, 'requested once boolean is in place')
+    assert(
+      vm.haveTodosBeenRequestedOnce === false,
+      'requested once boolean is in place'
+    )
     assert(vm.haveTodosLoadedOnce === false, 'loaded once boolean is in place')
     assert(typeof vm.findTodos === 'function', 'the find action is in place')
     assert(vm.todosLocal === false, 'local boolean is false by default')
@@ -95,7 +96,7 @@ describe('Find Mixin', function () {
     )
   })
 
-  it.skip('correctly forms mixin data for dynamic service', function () {
+  it.skip('correctly forms mixin data for dynamic service', function() {
     const tasksMixin = makeFindMixin({
       service() {
         return this.serviceName